From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8227 invoked by alias); 29 Jan 2011 00:02:06 -0000 Received: (qmail 8217 invoked by uid 22791); 29 Jan 2011 00:02:05 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-iy0-f169.google.com (HELO mail-iy0-f169.google.com) (209.85.210.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 29 Jan 2011 00:02:00 +0000 Received: by iyj17 with SMTP id 17so3618570iyj.0 for ; Fri, 28 Jan 2011 16:01:59 -0800 (PST) Received: by 10.231.200.134 with SMTP id ew6mr3449377ibb.164.1296259319030; Fri, 28 Jan 2011 16:01:59 -0800 (PST) Received: from bubble.grove.modra.org ([115.187.252.19]) by mx.google.com with ESMTPS id 34sm15164085ibi.2.2011.01.28.16.01.56 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 28 Jan 2011 16:01:58 -0800 (PST) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 25173170C272; Sat, 29 Jan 2011 10:31:49 +1030 (CST) Date: Sat, 29 Jan 2011 00:02:00 -0000 From: Alan Modra To: "Joseph S. Myers" Cc: binutils@sourceware.org Subject: Re: Fix use of uninitialized data in elf32-ppc.c Message-ID: <20110129000149.GH9489@bubble.grove.modra.org> Mail-Followup-To: "Joseph S. Myers" , binutils@sourceware.org References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00380.txt.bz2 On Fri, Jan 28, 2011 at 11:25:26PM +0000, Joseph S. Myers wrote: > This patch fixes nondeterministic behavior in the ppc32 linker arising > from the has_sda_refs field in struct ppc_elf_link_hash_entry not > being initialized. > > Tested with no regressions with cross to powerpc-linux-gnu. OK to > commit? Yes please. 2.21 too. > 2011-01-28 Joseph Myers > > * elf32-ppc.c (ppc_elf_link_hash_newfunc): Initialize has_sda_refs > field. -- Alan Modra Australia Development Lab, IBM