From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16002 invoked by alias); 10 Feb 2011 08:04:01 -0000 Received: (qmail 15991 invoked by uid 22791); 10 Feb 2011 08:04:00 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-pw0-f41.google.com (HELO mail-pw0-f41.google.com) (209.85.160.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 10 Feb 2011 08:03:53 +0000 Received: by pwj8 with SMTP id 8so379014pwj.0 for ; Thu, 10 Feb 2011 00:03:52 -0800 (PST) Received: by 10.142.242.18 with SMTP id p18mr19499675wfh.360.1297325030887; Thu, 10 Feb 2011 00:03:50 -0800 (PST) Received: from bubble.grove.modra.org ([115.187.252.19]) by mx.google.com with ESMTPS id w22sm1541557wfd.19.2011.02.10.00.03.47 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 10 Feb 2011 00:03:49 -0800 (PST) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 8E45716DE62A; Thu, 10 Feb 2011 18:33:43 +1030 (CST) Date: Thu, 10 Feb 2011 08:04:00 -0000 From: Alan Modra To: "H.J. Lu" Cc: binutils@sourceware.org Subject: Re: PATCH: PR ld/12356: [Regression] x86_64 kernel failed to link Message-ID: <20110210080343.GG7651@bubble.grove.modra.org> Mail-Followup-To: "H.J. Lu" , binutils@sourceware.org References: <20110113171002.GA19795@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110113171002.GA19795@intel.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00096.txt.bz2 On Thu, Jan 13, 2011 at 09:10:02AM -0800, H.J. Lu wrote: > 2011-01-13 H.J. Lu > > PR ld/12356 > * ld-scripts/defined.exp: Run defined5. > > * ld-scripts/defined5.d: New. > * ld-scripts/defined5.s: Likewise. > * ld-scripts/defined5.t: Likewise. This one didn't even assemble on AOUT targets due to lack of .section, and broke on COFF targets due to limitation in section name length. AOUT targets still fail after fixing the assembly problem since the format doesn't really allow arbitrary section addresses, so disable the test entirely for AOUT. * ld-scripts/defined.exp: Don't run defined5 for AOUT. * ld-scripts/defined5.s: Use .text for "defined" section. * ld-scripts/defined5.t: Adjust. Index: ld/testsuite/ld-scripts/defined5.s =================================================================== RCS file: /cvs/src/src/ld/testsuite/ld-scripts/defined5.s,v retrieving revision 1.1 diff -u -p -r1.1 defined5.s --- ld/testsuite/ld-scripts/defined5.s 13 Jan 2011 17:07:52 -0000 1.1 +++ ld/testsuite/ld-scripts/defined5.s 10 Feb 2011 04:00:31 -0000 @@ -1,6 +1,6 @@ .globl defined .data .byte 0 - .section .data.cacheline_aligned + .text defined: .byte 0 Index: ld/testsuite/ld-scripts/defined5.t =================================================================== RCS file: /cvs/src/src/ld/testsuite/ld-scripts/defined5.t,v retrieving revision 1.1 diff -u -p -r1.1 defined5.t --- ld/testsuite/ld-scripts/defined5.t 13 Jan 2011 17:07:52 -0000 1.1 +++ ld/testsuite/ld-scripts/defined5.t 10 Feb 2011 04:00:31 -0000 @@ -1,6 +1,6 @@ defined = addr1; SECTIONS { - .data.cacheline_aligned : { *(.data.cacheline_aligned) } + .text : { *(.text) } . = ALIGN (0x1000); .data : { *(.data) } addr1 = ADDR (.data); Index: ld/testsuite/ld-scripts/defined.exp =================================================================== RCS file: /cvs/src/src/ld/testsuite/ld-scripts/defined.exp,v retrieving revision 1.13 diff -u -p -r1.13 defined.exp --- ld/testsuite/ld-scripts/defined.exp 13 Jan 2011 17:07:52 -0000 1.13 +++ ld/testsuite/ld-scripts/defined.exp 10 Feb 2011 07:53:14 -0000 @@ -67,5 +67,7 @@ set prms_id 0 run_dump_test "defined2" run_dump_test "defined3" run_dump_test "defined4" -run_dump_test "defined5" +if ![is_aout_format] { + run_dump_test "defined5" +} set LDFLAGS "$saved_LDFLAGS" -- Alan Modra Australia Development Lab, IBM