From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-70178-listarch-binutils=sources.redhat.com@sourceware.org>
Received: (qmail 16727 invoked by alias); 17 Feb 2011 13:52:53 -0000
Received: (qmail 16717 invoked by uid 22791); 17 Feb 2011 13:52:52 -0000
X-SWARE-Spam-Status: No, hits=-4.3 required=5.0	tests=AWL,BAYES_00,NO_DNS_FOR_FROM,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mga11.intel.com (HELO mga11.intel.com) (192.55.52.93)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 17 Feb 2011 13:52:43 +0000
Received: from fmsmga001.fm.intel.com ([10.253.24.23])  by fmsmga102.fm.intel.com with ESMTP; 17 Feb 2011 05:52:42 -0800
X-ExtLoop1: 1
Received: from gnu-6.sc.intel.com ([10.3.194.135])  by fmsmga001.fm.intel.com with ESMTP; 17 Feb 2011 05:52:42 -0800
Received: by gnu-6.sc.intel.com (Postfix, from userid 500)	id 46FDC180F05; Thu, 17 Feb 2011 05:52:42 -0800 (PST)
Date: Thu, 17 Feb 2011 13:52:00 -0000
From: "H.J. Lu" <hongjiu.lu@intel.com>
To: binutils@sourceware.org
Subject: Re: PATCH: Don't check relocation overflow for x32.
Message-ID: <20110217135242.GA15266@intel.com>
Reply-To: "H.J. Lu" <hjl.tools@gmail.com>
References: <20110216145852.GA15249@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20110216145852.GA15249@intel.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Mailing-List: contact binutils-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <binutils.sourceware.org>
List-Subscribe: <mailto:binutils-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: binutils-owner@sourceware.org
X-SW-Source: 2011-02/txt/msg00209.txt.bz2

On Wed, Feb 16, 2011 at 06:58:52AM -0800, H.J. Lu wrote:
> I checked in this patch.
> 
> 
> H.J.
> ---
> diff --git a/bfd/ChangeLog b/bfd/ChangeLog
> index 1ab968c..7ce8b2f 100644
> --- a/bfd/ChangeLog
> +++ b/bfd/ChangeLog
> @@ -1,3 +1,9 @@
> +2011-02-16  H.J. Lu  <hongjiu.lu@intel.com>
> +
> +	* elf64-x86-64.c (elf_x86_64_check_relocs): Check relocation
> +	overflow only for ABI_64_P.
> +	(elf_x86_64_relocate_section): Likewise.
> +
>  2011-02-15  Tristan Gingold  <gingold@adacore.com>
>  
>  	* vms-alpha.c (alpha_vms_link_add_archive_symbols): Add a comment.
> diff --git a/bfd/elf64-x86-64.c b/bfd/elf64-x86-64.c
> index 343abce..70fe9b1 100644
> --- a/bfd/elf64-x86-64.c
> +++ b/bfd/elf64-x86-64.c
> @@ -1498,6 +1498,7 @@ not_pointer:
>  	     sections we don't care about, such as debug sections or
>  	     non-constant sections.  */
>  	  if (info->shared
> +	      && ABI_64_P (abfd)
>  	      && (sec->flags & SEC_ALLOC) != 0
>  	      && (sec->flags & SEC_READONLY) != 0)
>  	    {
> @@ -3148,6 +3149,7 @@ elf_x86_64_relocate_section (bfd *output_bfd,
>  	     for shared library since it may not be local when used
>  	     as function address.  */
>  	  if (info->shared
> +	      && ABI_64_P (output_bfd)
>  	      && h
>  	      && h->def_regular
>  	      && h->type == STT_FUNC

This patch is wrong. I reverted it.


H.J.