From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18005 invoked by alias); 17 Feb 2011 19:03:22 -0000 Received: (qmail 17986 invoked by uid 22791); 17 Feb 2011 19:03:21 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_BJ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 17 Feb 2011 19:03:19 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p1HJ2w9m024806 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 17 Feb 2011 14:02:58 -0500 Received: from tyan-ft48-01.lab.bos.redhat.com (tyan-ft48-01.lab.bos.redhat.com [10.16.42.4]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p1HJ2vMs020636 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 17 Feb 2011 14:02:57 -0500 Received: from tyan-ft48-01.lab.bos.redhat.com (localhost.localdomain [127.0.0.1]) by tyan-ft48-01.lab.bos.redhat.com (8.14.4/8.14.4) with ESMTP id p1HJ2t5L032397; Thu, 17 Feb 2011 20:02:55 +0100 Received: (from jakub@localhost) by tyan-ft48-01.lab.bos.redhat.com (8.14.4/8.14.4/Submit) id p1HJ2s5j030259; Thu, 17 Feb 2011 20:02:54 +0100 Date: Thu, 17 Feb 2011 19:03:00 -0000 From: Jakub Jelinek To: Kai Tietz Cc: GCC Patches , Binutils , gdb , Joel Brobecker Subject: Re: [RFC patch]: Adjust the use of 'long' type in dwarf2.h header Message-ID: <20110217190253.GC30899@tyan-ft48-01.lab.bos.redhat.com> Reply-To: Jakub Jelinek References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00228.txt.bz2 On Thu, Feb 17, 2011 at 07:58:56PM +0100, Kai Tietz wrote: > 2011/2/17 Kai Tietz : > > This patch addresses issues I've seen in binutils about > > cross-compilers and dwarf2 display via objdump -W on hosts, which have > > sizeof (long) < target's sizeof(void *). Additionally same issue of > > course can be seen on LLP64 targets, too. > > Those issues are caused by the fact that the dwarf2.h header in > > include/ is using unconditionally the type 'unsigned long' for > > vma-scalars. > > > > This patch address additionally the binutils' dwarf.(c|h) files and > > make them host bitness independent for gcc base toolchains supporting > > the 'long long' type. > > > > I've tested the attached patches for gdb, binutils, and gcc on > > i686-w64-mingw32, and x86_64-w64-mingw32 cross-toolchains hosted on > > cygwin. And I didn't found until now regressions. Later this day I > > want to do a regression test for linux64, too. I'd prefer if we could move those binutils specific internal implementation details out of the dwarf2.h header, keep it really just for the stuff defined in the standard, and add a new binutils specific header somewhere else which would contain binutils specific details. Jakub