From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: ktietz70@googlemail.com
Cc: pierre.muller@ics-cnrs.unistra.fr, gcc-patches@gcc.gnu.org,
binutils@sourceware.org, gdb@sourceware.org,
jakub@redhat.com, brobecker@adacore.com
Subject: Re: [RFC patch]: Adjust the use of 'long' type in dwarf2.h header
Date: Mon, 21 Feb 2011 15:43:00 -0000 [thread overview]
Message-ID: <201102211542.p1LFgucQ002211@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <AANLkTimHC_cR=Zb4JHBhBWcjn0Ypya1uzsjzZZRehSk=@mail.gmail.com> (message from Kai Tietz on Mon, 21 Feb 2011 16:25:35 +0100)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1429 bytes --]
> Date: Mon, 21 Feb 2011 16:25:35 +0100
> From: Kai Tietz <ktietz70@googlemail.com>
>
> 2011/2/21 Kai Tietz <ktietz70@googlemail.com>:
> > 2011/2/21 Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>:
> >>> Yes, I saw this too and it is a thorn here. But the issue about a
> >>> transformation function (like dwarf_vma) is that we have memory leaks
> >>> - as this function is to be used on some printf's more then once - as
> >>> static buffer would be overriden. Well printfs can be splitted into
> >>> smaller parts, but this then would make localization even harder.
> >>
> >> In GDB code, this is solved in utils.c source by the use of the
> >> get_cell function, which rotates over 16 char arrays of size 50 each
> >> currently, in dwarf.c 4 arrays of 16 char (as long as longest address is
> >> 64-bit)
> >> for this dwarf_vma function would probably be enough, no?
> >>
> >>
> >> Pierre Muller
> >> GDB pascal language maintainer
> >
> > Yes, this sounds ok. I think maximum here are right now 3 dwarf_vma
> > prints within one printf. So it should be ok. I'll add here such a
> > rotating function. I don't assume we need here to handle
> > multi-threading, so rotation code can be pretty simple.
> >
> > Kai
> >
>
> So this version uses new function dwarf_vma_print function for
> printf-messages, which are getting localized.
dwarf_vma_print is a really bad name for that function since it
doesn't print anything.
next prev parent reply other threads:[~2011-02-21 15:43 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-17 14:21 Kai Tietz
2011-02-17 18:59 ` Kai Tietz
2011-02-17 19:03 ` Jakub Jelinek
2011-02-17 19:07 ` Kai Tietz
2011-02-17 19:17 ` Jakub Jelinek
2011-02-18 9:50 ` Kai Tietz
2011-02-21 12:37 ` NightStrike
2011-02-21 13:10 ` Pierre Muller
[not found] ` <-8460070221060995487@unknownmsgid>
2011-02-21 13:27 ` Kai Tietz
2011-02-21 13:46 ` Pierre Muller
[not found] ` <-6930711422310680743@unknownmsgid>
2011-02-21 14:30 ` Kai Tietz
2011-02-21 15:25 ` Kai Tietz
2011-02-21 15:43 ` Mark Kettenis [this message]
2011-02-21 15:53 ` Kai Tietz
2011-02-22 15:21 ` Nick Clifton
2011-02-23 8:59 ` Kai Tietz
2011-02-23 15:12 ` Pierre Muller
[not found] ` <-2339605939192327273@unknownmsgid>
2011-02-23 17:42 ` Kai Tietz
2011-02-23 21:55 ` Pierre Muller
[not found] ` <-3886800211494155692@unknownmsgid>
2011-02-23 22:51 ` H.J. Lu
2011-02-24 11:33 ` Pierre Muller
[not found] ` <1561346207520594884@unknownmsgid>
2011-02-24 13:50 ` H.J. Lu
2011-02-25 10:40 ` [RFC] Use only dwarf_vma types in dwarf code (was RE: [RFC patch]: Adjust the use of 'long' type in dwarf2.h header) Pierre Muller
[not found] ` <5095785081977025060@unknownmsgid>
2011-02-25 12:23 ` Kai Tietz
2011-02-25 13:31 ` Pierre Muller
2011-02-25 13:35 ` [RFC-v2] Use only dwarf_vma types in dwarf code Pierre Muller
2011-03-25 15:16 ` Nick Clifton
2011-03-25 15:48 ` [RFA] Supplemtal patch for use " Pierre Muller
2011-03-25 18:04 ` Nick Clifton
2011-03-25 21:44 ` Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201102211542.p1LFgucQ002211@glazunov.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=binutils@sourceware.org \
--cc=brobecker@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gdb@sourceware.org \
--cc=jakub@redhat.com \
--cc=ktietz70@googlemail.com \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).