From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13728 invoked by alias); 21 Feb 2011 15:43:41 -0000 Received: (qmail 13707 invoked by uid 22791); 21 Feb 2011 15:43:39 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 21 Feb 2011 15:43:38 +0000 Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id p1LFgwiT021932; Mon, 21 Feb 2011 16:42:58 +0100 (CET) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id p1LFgucQ002211; Mon, 21 Feb 2011 16:42:56 +0100 (CET) Date: Mon, 21 Feb 2011 15:43:00 -0000 Message-Id: <201102211542.p1LFgucQ002211@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: ktietz70@googlemail.com CC: pierre.muller@ics-cnrs.unistra.fr, gcc-patches@gcc.gnu.org, binutils@sourceware.org, gdb@sourceware.org, jakub@redhat.com, brobecker@adacore.com In-reply-to: (message from Kai Tietz on Mon, 21 Feb 2011 16:25:35 +0100) Subject: Re: [RFC patch]: Adjust the use of 'long' type in dwarf2.h header References: <-8460070221060995487@unknownmsgid> <-6930711422310680743@unknownmsgid> Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00259.txt.bz2 > Date: Mon, 21 Feb 2011 16:25:35 +0100 > From: Kai Tietz > > 2011/2/21 Kai Tietz : > > 2011/2/21 Pierre Muller : > >>> Yes, I saw this too and it is a thorn here. But the issue about a > >>> transformation function (like dwarf_vma) is that we have memory leaks > >>> - as this function is to be used on some printf's more then once - as > >>> static buffer would be overriden. Well printfs can be splitted into > >>> smaller parts, but this then would make localization even harder. > >> > >>  In GDB code, this is solved in utils.c source by the use of the > >> get_cell function, which rotates over 16 char arrays of size 50 each > >> currently, in dwarf.c 4 arrays of 16 char (as long as longest address is > >> 64-bit) > >> for this dwarf_vma function would probably be enough, no? > >> > >> > >> Pierre Muller > >> GDB pascal language maintainer > > > > Yes, this sounds ok. I think maximum here are right now 3 dwarf_vma > > prints within one printf. So it should be ok. I'll add here such a > > rotating function. I don't assume we need here to handle > > multi-threading, so rotation code can be pretty simple. > > > > Kai > > > > So this version uses new function dwarf_vma_print function for > printf-messages, which are getting localized. dwarf_vma_print is a really bad name for that function since it doesn't print anything.