From: "H.J. Lu" <hongjiu.lu@intel.com>
To: binutils@sourceware.org
Subject: PATCH: PR ld/12507: Can't build a program with -flto -nostdlib
Date: Thu, 24 Feb 2011 22:59:00 -0000 [thread overview]
Message-ID: <20110224225913.GA3169@intel.com> (raw)
We should never mark entry symbol IR only. I checked in this patch as
an obvious fix.
H.J.
----
diff --git a/ld/ChangeLog b/ld/ChangeLog
index 7b3d9bd..c672209 100644
--- a/ld/ChangeLog
+++ b/ld/ChangeLog
@@ -1,3 +1,8 @@
+2011-02-24 H.J. Lu <hongjiu.lu@intel.com>
+
+ PR ld/12507
+ * plugin.c (get_symbols): Don't mark entry symbol IR only.
+
2011-02-18 John David Anglin <dave.anglin@nrc-cnnrc.gc.ca>
PR ld/12376
diff --git a/ld/plugin.c b/ld/plugin.c
index 628db41..7892e36 100644
--- a/ld/plugin.c
+++ b/ld/plugin.c
@@ -490,8 +490,10 @@ get_symbols (const void *handle, int nsyms, struct ld_plugin_symbol *syms)
even potentially-referenced, perhaps in a future final link if
this is a partial one, perhaps dynamically at load-time if the
symbol is externally visible. */
- ironly = !is_visible_from_outside (&syms[n], owner_sec, blhe)
- && !bfd_hash_lookup (non_ironly_hash, syms[n].name, FALSE, FALSE);
+ ironly = (!is_visible_from_outside (&syms[n], owner_sec, blhe)
+ && !bfd_hash_lookup (non_ironly_hash, syms[n].name,
+ FALSE, FALSE)
+ && strcmp (syms[n].name, entry_symbol.name) != 0);
/* If it was originally undefined or common, then it has been
resolved; determine how. */
next reply other threads:[~2011-02-24 22:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-24 22:59 H.J. Lu [this message]
2011-02-25 22:45 ` Dave Korn
2011-02-25 23:08 ` H.J. Lu
2011-02-25 23:30 ` Alan Modra
2011-02-25 23:45 ` H.J. Lu
2011-02-25 23:59 ` Alan Modra
2011-02-26 0:09 ` Rafael Ávila de Espíndola
2011-02-26 4:34 ` H.J. Lu
2011-02-26 5:16 ` Rafael Ávila de Espíndola
2011-02-26 5:32 ` H.J. Lu
2011-02-26 4:33 ` H.J. Lu
2011-02-26 4:36 ` H.J. Lu
2011-02-26 9:04 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110224225913.GA3169@intel.com \
--to=hongjiu.lu@intel.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).