From: Alan Modra <amodra@gmail.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: binutils@sourceware.org
Subject: Re: PATCH: PR ld/12507: Can't build a program with -flto -nostdlib
Date: Fri, 25 Feb 2011 23:30:00 -0000 [thread overview]
Message-ID: <20110225232948.GD5959@bubble.grove.modra.org> (raw)
In-Reply-To: <20110224225913.GA3169@intel.com>
On Thu, Feb 24, 2011 at 02:59:13PM -0800, H.J. Lu wrote:
> @@ -490,8 +490,10 @@ get_symbols (const void *handle, int nsyms, struct ld_plugin_symbol *syms)
> even potentially-referenced, perhaps in a future final link if
> this is a partial one, perhaps dynamically at load-time if the
> symbol is externally visible. */
> - ironly = !is_visible_from_outside (&syms[n], owner_sec, blhe)
> - && !bfd_hash_lookup (non_ironly_hash, syms[n].name, FALSE, FALSE);
> + ironly = (!is_visible_from_outside (&syms[n], owner_sec, blhe)
> + && !bfd_hash_lookup (non_ironly_hash, syms[n].name,
> + FALSE, FALSE)
> + && strcmp (syms[n].name, entry_symbol.name) != 0);
>
> /* If it was originally undefined or common, then it has been
> resolved; determine how. */
It would be better to put the entry symbol, and -u syms on the
entry_symbol chain, into non_ironly_hash.
--
Alan Modra
Australia Development Lab, IBM
next prev parent reply other threads:[~2011-02-25 23:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-24 22:59 H.J. Lu
2011-02-25 22:45 ` Dave Korn
2011-02-25 23:08 ` H.J. Lu
2011-02-25 23:30 ` Alan Modra [this message]
2011-02-25 23:45 ` H.J. Lu
2011-02-25 23:59 ` Alan Modra
2011-02-26 0:09 ` Rafael Ávila de Espíndola
2011-02-26 4:34 ` H.J. Lu
2011-02-26 5:16 ` Rafael Ávila de Espíndola
2011-02-26 5:32 ` H.J. Lu
2011-02-26 4:33 ` H.J. Lu
2011-02-26 4:36 ` H.J. Lu
2011-02-26 9:04 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110225232948.GD5959@bubble.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).