From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18402 invoked by alias); 25 Feb 2011 23:30:06 -0000 Received: (qmail 18371 invoked by uid 22791); 25 Feb 2011 23:30:04 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-pv0-f169.google.com (HELO mail-pv0-f169.google.com) (74.125.83.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 25 Feb 2011 23:30:00 +0000 Received: by pvg4 with SMTP id 4so491622pvg.0 for ; Fri, 25 Feb 2011 15:29:58 -0800 (PST) Received: by 10.142.207.4 with SMTP id e4mr2102857wfg.82.1298676596928; Fri, 25 Feb 2011 15:29:56 -0800 (PST) Received: from bubble.grove.modra.org ([115.187.252.19]) by mx.google.com with ESMTPS id w27sm1622624wfd.16.2011.02.25.15.29.54 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 25 Feb 2011 15:29:55 -0800 (PST) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 59B5916DE62C; Sat, 26 Feb 2011 09:59:48 +1030 (CST) Date: Fri, 25 Feb 2011 23:30:00 -0000 From: Alan Modra To: "H.J. Lu" Cc: binutils@sourceware.org Subject: Re: PATCH: PR ld/12507: Can't build a program with -flto -nostdlib Message-ID: <20110225232948.GD5959@bubble.grove.modra.org> Mail-Followup-To: "H.J. Lu" , binutils@sourceware.org References: <20110224225913.GA3169@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110224225913.GA3169@intel.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00322.txt.bz2 On Thu, Feb 24, 2011 at 02:59:13PM -0800, H.J. Lu wrote: > @@ -490,8 +490,10 @@ get_symbols (const void *handle, int nsyms, struct ld_plugin_symbol *syms) > even potentially-referenced, perhaps in a future final link if > this is a partial one, perhaps dynamically at load-time if the > symbol is externally visible. */ > - ironly = !is_visible_from_outside (&syms[n], owner_sec, blhe) > - && !bfd_hash_lookup (non_ironly_hash, syms[n].name, FALSE, FALSE); > + ironly = (!is_visible_from_outside (&syms[n], owner_sec, blhe) > + && !bfd_hash_lookup (non_ironly_hash, syms[n].name, > + FALSE, FALSE) > + && strcmp (syms[n].name, entry_symbol.name) != 0); > > /* If it was originally undefined or common, then it has been > resolved; determine how. */ It would be better to put the entry symbol, and -u syms on the entry_symbol chain, into non_ironly_hash. -- Alan Modra Australia Development Lab, IBM