From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19707 invoked by alias); 26 Feb 2011 09:14:01 -0000 Received: (qmail 19696 invoked by uid 22791); 26 Feb 2011 09:14:01 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-px0-f169.google.com (HELO mail-px0-f169.google.com) (209.85.212.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 26 Feb 2011 09:13:57 +0000 Received: by pxi9 with SMTP id 9so562153pxi.0 for ; Sat, 26 Feb 2011 01:13:55 -0800 (PST) Received: by 10.143.20.25 with SMTP id x25mr32608wfi.166.1298711635794; Sat, 26 Feb 2011 01:13:55 -0800 (PST) Received: from bubble.grove.modra.org ([115.187.252.19]) by mx.google.com with ESMTPS id w32sm2285608wfh.7.2011.02.26.01.13.53 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 26 Feb 2011 01:13:55 -0800 (PST) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id CB89216DE62C; Sat, 26 Feb 2011 19:43:47 +1030 (CST) Date: Sat, 26 Feb 2011 09:14:00 -0000 From: Alan Modra To: Dave Korn Cc: "binutils@sourceware.org" Subject: Re: [1/6][PATCH] Fix PE-COFF bug in orphan section alignment handling. Message-ID: <20110226091347.GK5959@bubble.grove.modra.org> Mail-Followup-To: Dave Korn , "binutils@sourceware.org" References: <4D684CB8.6020106@gmail.com> <4D684D00.70803@gmail.com> <4D684D1C.9090002@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D684D1C.9090002@gmail.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00355.txt.bz2 On Sat, Feb 26, 2011 at 12:45:16AM +0000, Dave Korn wrote: > + if (link_info.relocatable) > + os->bfd_section->alignment_power = os->section_alignment > + = s->alignment_power; Style and formatting issues here. Better written as if (link_info.relocatable) { os->section_alignment = s->alignment_power; os->bfd_section->alignment_power = s->alignment_power; } -- Alan Modra Australia Development Lab, IBM