From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26544 invoked by alias); 26 Feb 2011 09:28:14 -0000 Received: (qmail 26533 invoked by uid 22791); 26 Feb 2011 09:28:13 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-pv0-f169.google.com (HELO mail-pv0-f169.google.com) (74.125.83.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 26 Feb 2011 09:28:09 +0000 Received: by pvg4 with SMTP id 4so564202pvg.0 for ; Sat, 26 Feb 2011 01:28:08 -0800 (PST) Received: by 10.142.213.18 with SMTP id l18mr2428737wfg.383.1298712488138; Sat, 26 Feb 2011 01:28:08 -0800 (PST) Received: from bubble.grove.modra.org ([115.187.252.19]) by mx.google.com with ESMTPS id w19sm2294271wfd.20.2011.02.26.01.28.06 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 26 Feb 2011 01:28:07 -0800 (PST) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 0DCC116DE62C; Sat, 26 Feb 2011 19:58:00 +1030 (CST) Date: Sat, 26 Feb 2011 09:28:00 -0000 From: Alan Modra To: Dave Korn Cc: "binutils@sourceware.org" Subject: Re: [6/6][PATCH] Respect symbol wrappers when computing symbol resolutions. Message-ID: <20110226092800.GN5959@bubble.grove.modra.org> Mail-Followup-To: Dave Korn , "binutils@sourceware.org" References: <4D684CB8.6020106@gmail.com> <4D684D00.70803@gmail.com> <4D684D79.9090708@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D684D79.9090708@gmail.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00360.txt.bz2 On Sat, Feb 26, 2011 at 12:46:49AM +0000, Dave Korn wrote: > * plugin.c (get_symbols): Use wrapped lookup for undefined symbols. OK. > I'd like it if someone can confirm that I've correctly interpreted the > comment that precedes the definition of bfd_wrapped_link_hash_lookup, about > how it should "only be used for references to an undefined symbol, not for > definitions of a symbol"; I took that to mean that I should key off the > initial state of defined-ness of the symbol passed from the plugin and call > either a wrapped or unwrapped lookup accordingly Yes, I think that is correct. -- Alan Modra Australia Development Lab, IBM