From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1678 invoked by alias); 6 Mar 2011 08:33:10 -0000 Received: (qmail 1669 invoked by uid 22791); 6 Mar 2011 08:33:09 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-px0-f169.google.com (HELO mail-px0-f169.google.com) (209.85.212.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 06 Mar 2011 08:33:05 +0000 Received: by pxi9 with SMTP id 9so857328pxi.0 for ; Sun, 06 Mar 2011 00:33:03 -0800 (PST) Received: by 10.143.21.38 with SMTP id y38mr2141095wfi.342.1299400383847; Sun, 06 Mar 2011 00:33:03 -0800 (PST) Received: from bubble.grove.modra.org ([115.187.252.19]) by mx.google.com with ESMTPS id 25sm2267711wfb.10.2011.03.06.00.33.00 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 06 Mar 2011 00:33:02 -0800 (PST) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 22339170C1FA; Sun, 6 Mar 2011 19:02:56 +1030 (CST) Date: Sun, 06 Mar 2011 08:33:00 -0000 From: Alan Modra To: "H.J. Lu" Cc: binutils@sourceware.org Subject: Re: PATCH: Mention symbol name in non-constant .size expression Message-ID: <20110306083255.GJ6275@bubble.grove.modra.org> Mail-Followup-To: "H.J. Lu" , binutils@sourceware.org References: <20110305153249.GA32480@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110305153249.GA32480@intel.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00085.txt.bz2 On Sat, Mar 05, 2011 at 07:32:49AM -0800, H.J. Lu wrote: > + * config/obj-elf.c (elf_frob_symbol): Mention symbol name in > + non-constant .size expression. OK. I may revert this soon when/if I code up an idea I had of creating a hash table to store size expressions and their original file/line number. It seems silly to tack an extra field on all symbols just to handle .size on a few. -- Alan Modra Australia Development Lab, IBM