From: Alan Modra <amodra@gmail.com>
To: Hans-Peter Nilsson <hans-peter.nilsson@axis.com>
Cc: hjl.tools@gmail.com, hp@axis.com, binutils@sourceware.org
Subject: Re: PATCH: Mention symbol name in non-constant .size expression
Date: Mon, 07 Mar 2011 03:55:00 -0000 [thread overview]
Message-ID: <20110307035457.GL6275@bubble.grove.modra.org> (raw)
In-Reply-To: <201103070328.p273S2rm023864@ignucius.se.axis.com>
On Mon, Mar 07, 2011 at 04:28:02AM +0100, Hans-Peter Nilsson wrote:
> If there's no intention to actually fix it, I think xfail is
> more appropriate; no particular reason it should fail, IMHO.
The new test will fail for any target without DIFF_EXPR_OK defined.
HJ, I don't think it is worth going to the bother of firstly finding
out exactly what set of targets that is, then xfailing them all.
Please just revert the testsuite change that checks for the symbol
name.
--
Alan Modra
Australia Development Lab, IBM
next prev parent reply other threads:[~2011-03-07 3:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-05 15:32 H.J. Lu
2011-03-06 8:33 ` Alan Modra
2011-03-07 2:22 ` Hans-Peter Nilsson
2011-03-07 2:51 ` H.J. Lu
2011-03-07 3:28 ` Hans-Peter Nilsson
2011-03-07 3:55 ` Alan Modra [this message]
2011-03-07 5:43 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110307035457.GL6275@bubble.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=hans-peter.nilsson@axis.com \
--cc=hjl.tools@gmail.com \
--cc=hp@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).