public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Kai Tietz <ktietz70@googlemail.com>,
	gcc-patches@gcc.gnu.org, Eli Zaretskii <eliz@gnu.org>,
	binutils@sourceware.org
Subject: Re: [patch libiberty include]: Add additional helper functions for directory-separator searching
Date: Tue, 08 Mar 2011 13:33:00 -0000	[thread overview]
Message-ID: <201103081333.03177.pedro@codesourcery.com> (raw)
In-Reply-To: <AANLkTi=rdg9K1eeZxsbQGXT4DeP+bv4LU-h0+DKERa11@mail.gmail.com>

On Tuesday 08 March 2011 12:48:11, Kai Tietz wrote:

> Well, a better example is elfstab_offset_sections() in elfread.c.

  /* The ELF symbol info doesn't include path names, so strip the path
     (if any) from the psymtab filename.  */
  while (0 != (p = strchr (filename, '/')))
    filename = p + 1;

Looks like its looking for the last path separator, so
it might as well use filename_dirrchr instead.

> Another is in find_file_and_directory() in dwarf2read.c file.

Workaround for Irix.  Certainly that '/' should not depend
on the host gdb is running on.

-- 
Pedro Alves

  reply	other threads:[~2011-03-08 13:33 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-08 10:56 Kai Tietz
2011-03-08 11:12 ` Eli Zaretskii
2011-03-08 11:25   ` Kai Tietz
2011-03-08 11:53     ` Eli Zaretskii
2011-03-08 12:01       ` Kai Tietz
2011-03-08 12:43         ` Pedro Alves
2011-03-08 12:48           ` Kai Tietz
2011-03-08 13:33             ` Pedro Alves [this message]
2011-03-08 13:37               ` Kai Tietz
2011-03-08 18:39               ` Eli Zaretskii
2011-03-08 18:50                 ` Pedro Alves
2011-03-08 18:51                 ` Kai Tietz
2011-03-08 19:54                   ` Eli Zaretskii
     [not found] ` <E1Pwupb-0001ns-M8__47566.5626036518$1299582745$gmane$org@fencepost.gnu.org>
2011-03-08 11:55   ` Andreas Schwab
2011-03-08 15:11 ` Kai Tietz
2011-03-08 15:30   ` Kai Tietz
2011-03-08 18:37     ` Eli Zaretskii
2011-03-08 19:41       ` DJ Delorie
2011-03-08 19:59         ` Eli Zaretskii
2011-03-08 22:38         ` Pedro Alves
2011-03-09  5:29           ` Eli Zaretskii
2011-03-09 11:46             ` Pedro Alves
2011-03-09 12:35               ` Eli Zaretskii
2011-03-09 12:58                 ` Pedro Alves
2011-03-09 13:36                   ` Eli Zaretskii
2011-03-12 16:40                     ` Kai Tietz
2011-03-09 14:37                   ` Build regression [Re: [patch libiberty include]: Add additional helper functions for directory-separator searching] Jan Kratochvil
2011-03-09 15:02                     ` Pedro Alves
2011-03-09 15:08                       ` Jan Kratochvil
2011-03-12 16:44         ` [patch libiberty include]: Add additional helper functions for directory-separator searching Kai Tietz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201103081333.03177.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=binutils@sourceware.org \
    --cc=eliz@gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=ktietz70@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).