From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1211 invoked by alias); 14 Mar 2011 09:55:53 -0000 Received: (qmail 1198 invoked by uid 22791); 14 Mar 2011 09:55:52 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_05,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx2.mail.elte.hu (HELO mx2.mail.elte.hu) (157.181.151.9) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 14 Mar 2011 09:55:45 +0000 Received: from elvis.elte.hu ([157.181.1.14]) by mx2.mail.elte.hu with esmtp (Exim) id 1Pz4Uy-0002bp-KX from ; Mon, 14 Mar 2011 10:55:39 +0100 Received: by elvis.elte.hu (Postfix, from userid 1004) id B92433E233E; Mon, 14 Mar 2011 10:55:31 +0100 (CET) Date: Mon, 14 Mar 2011 09:55:00 -0000 From: Ingo Molnar To: Jan Beulich Cc: "H.J. Lu" , amodra@gmail.com, binutils@sourceware.org, linux-kernel@vger.kernel.org, "H. Peter Anvin" , Andrew Morton , Linus Torvalds , Thomas Gleixner Subject: Re: PATCH: Add --size-check=[error|warning] Message-ID: <20110314095534.GB18058@elte.hu> References: <20110311165802.GA3508@intel.com> <4D7A64670200007800035F4C@vpn.id2.novell.com> <4D7DE39302000078000362E6@vpn.id2.novell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D7DE39302000078000362E6@vpn.id2.novell.com> User-Agent: Mutt/1.5.20 (2009-08-17) Received-SPF: neutral (mx2.mail.elte.hu: 157.181.1.14 is neither permitted nor denied by domain of elte.hu) client-ip=157.181.1.14; envelope-from=mingo@elte.hu; helo=elvis.elte.hu; X-ELTE-SpamScore: -2.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.3.1 -2.0 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00237.txt.bz2 (H.J. Lu, did you drop me from the Cc: line?) * Jan Beulich wrote: > >> Please make it so that it'll be a warning by default, and an error > >> upon programmer request. Otherwise, for the very purpose of > > > > I disagree. It should be error by default since the input is bogus, > > Otherwise, those assembly bugs, benign or not, may not get > > fixed. > > > >> bisection, it won't help much as you would have to override > >> compiler/assembler flags during that process. > >> > > > > They can use a wrapper to pass --size-check=warning to > > assembler. I think it is a small price to pay for those mistakes. > > "Small" being relative here - it could be dozens if not hundreds of > people having to learn that this is necessary, many of them > possibly rather unfamiliar with gas and its command line options. > > Also, using a wrapper gets further complicated by the fact that > you may have to pass an extra -B to the compiler (not everyone > has full control over the file system of all the machines used to > do development), making sure this doesn't have any other > unwanted side effects. Correct. In reality if the kernel does not build or boot then most people just wont continue with the bisection. So this change actively degrades debuggability, for no good reason. The thing is, it is absolutely, breath-takingy incompetent for the new binutils version to break the Linux kernel build for 4 years of Linux kernel history retroactively (130,000 commits), just to 'warn' about a size bug in a few debug symbols that has no functional effects whatsoever and which few people care about. The correct solution is to turn it into a warning as me and others have suggested. No argument was offered *why* the build must be aborted. A warning serves the purpose of informing the developer just as much - and does not inconvenience the tester. Thanks, Ingo