From: Paul Brook <paul@codesourcery.com>
To: binutils@sourceware.org
Cc: Paul Carroll <pcarroll@codesourcery.com>
Subject: Re: [PATCH] ARM: objdump produces incorrect disassembly on multiple inputs
Date: Thu, 07 Apr 2011 13:27:00 -0000 [thread overview]
Message-ID: <201104071427.24516.paul@codesourcery.com> (raw)
In-Reply-To: <4D76BA21.90708@codesourcery.com>
> The 'objdump' utility will not disassembly instructions correctly when
> it processes multiple ARM input files.
> That is, if you compare the disassembly of each file individually
> against the output produced by processing all of the files at once, the
> output is different.
> This is due to the ARM disassembler using a couple of global symbols to
> track symbol entries in a given input file.
> The problem is that these global symbols are initialized once, but never
> reset back to their starting values when a new input file begins
> processing. As a result, 'objdump's view of the symbols for the new
> input file is messed up.
>
> This patch adds a call to initialize those 2 values at the start of
> processing each ARM input file. This fix is ARM-specific.
Wouldn't it be better to use info->private_data ?
Paul
next prev parent reply other threads:[~2011-04-07 13:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-08 23:22 Paul Carroll
2011-04-07 13:27 ` Paul Brook [this message]
2011-04-07 17:07 ` Paul Carroll
2011-04-07 21:19 ` Paul Brook
2011-04-08 0:21 ` Paul Carroll
2011-04-08 11:45 ` Paul Brook
2011-04-11 0:16 ` Alan Modra
2011-04-11 2:40 ` Paul Carroll
2011-04-11 15:16 ` Nick Clifton
2011-04-11 16:40 ` Paul Carroll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201104071427.24516.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=binutils@sourceware.org \
--cc=pcarroll@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).