[commit] Re: [ppc64] eu-strip vs. func addresses for GDB inferior calls #3

[Jan Kratochvil <jan.kratochvil@redhat.com>]

On Sun, 10 Apr 2011 05:35:03 +0200, Alan Modra wrote:
> On Sat, Apr 09, 2011 at 05:08:14PM +0200, Jan Kratochvil wrote:
> > 	* elf64-ppc.c (ppc64_elf_get_synthetic_symtab): Do not check for
> > 	SEC_LOAD.
> 
> OK.

Checked in:
	http://sourceware.org/ml/binutils-cvs/2011-04/msg00097.html

used a different / corrected comment:
+		  /* SEC_LOAD may not be set if SEC is from a separate debug
+		     info file.  */

instead of former:
+		  /* SEC_LOAD may not be set if ABFD is a separate debug info
+		     file.  */


gdb/
	Fix convert_code_addr_to_desc_addr for ppc64 files after eu-strip.
	* elfread.c (elf_symfile_read): New variable synth_abfd, pass it to
	bfd_get_synthetic_symtab.
	* jit.c (jit_register_code): Pass NULL to the new parameter parent.
	* machoread.c (macho_add_oso_symfile): Pass main_objfile to the new
	parameter parent, remove the call to add_separate_debug_objfile.
	* solib.c (solib_read_symbols): Pass NULL to the new parameter parent.
	* symfile-mem.c (symbol_file_add_from_memory): Likewise.
	* symfile.c (symbol_file_add_with_addrs_or_offsets): New parameter
	parent, new comment for it, call add_separate_debug_objfile for it.
	(symbol_file_add_separate): Pass objfile as the parameter parent,
	remove the call to add_separate_debug_objfile.
	(symbol_file_add_from_bfd): New parameter parent, pass it.
	(symbol_file_add): Pass NULL to the new parameter parent.
	* symfile.h (symbol_file_add_from_bfd): New parameter parent.

gdb/testsuite/
	* gdb.base/eu-strip-infcall.c: New file.
	* gdb.base/eu-strip-infcall.exp: New file.

Checked in:
	http://sourceware.org/ml/gdb-cvs/2011-04/msg00104.html


No regressions on {ppc64-m64,ppc64-m32}-rhel61-linux-gnu.


Thanks,
Jan


The corrected bfd/ part:

http://sourceware.org/ml/binutils-cvs/2011-04/msg00097.html

--- src/bfd/ChangeLog	2011/04/15 11:13:59	1.5305
+++ src/bfd/ChangeLog	2011/04/17 18:38:41	1.5306
@@ -1,3 +1,8 @@
+2011-04-17  Jan Kratochvil  <jan.kratochvil@redhat.com>
+
+	* elf64-ppc.c (ppc64_elf_get_synthetic_symtab): Do not check for
+	SEC_LOAD.
+
 2011-04-15  Sergio Durigan Junior  <sergiodj@redhat.com>
 
 	* elf-bfd.h (struct sdt_note): New struct.
--- src/bfd/elf64-ppc.c	2011/04/11 08:13:17	1.347
+++ src/bfd/elf64-ppc.c	2011/04/17 18:38:43	1.348
@@ -3317,8 +3317,9 @@
 		{
 		  if (sec->vma > ent)
 		    break;
-		  if ((sec->flags & SEC_ALLOC) == 0
-		      || (sec->flags & SEC_LOAD) == 0)
+		  /* SEC_LOAD may not be set if SEC is from a separate debug
+		     info file.  */
+		  if ((sec->flags & SEC_ALLOC) == 0)
 		    break;
 		  if ((sec->flags & SEC_CODE) != 0)
 		    s->section = sec;