From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25829 invoked by alias); 17 Apr 2011 18:41:57 -0000 Received: (qmail 25811 invoked by uid 22791); 17 Apr 2011 18:41:56 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_BJ,TW_YM,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 17 Apr 2011 18:41:39 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p3HIfd0V031266 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 17 Apr 2011 14:41:39 -0400 Received: from host1.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p3HIfbw7002323 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 17 Apr 2011 14:41:38 -0400 Received: from host1.jankratochvil.net (localhost [127.0.0.1]) by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p3HIfbaS003303; Sun, 17 Apr 2011 20:41:37 +0200 Received: (from jkratoch@localhost) by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id p3HIfafA003301; Sun, 17 Apr 2011 20:41:36 +0200 Date: Sun, 17 Apr 2011 18:41:00 -0000 From: Jan Kratochvil To: gdb-patches@sourceware.org, binutils@sourceware.org Subject: [commit] Re: [ppc64] eu-strip vs. func addresses for GDB inferior calls #3 Message-ID: <20110417184136.GB31211@host1.jankratochvil.net> References: <20110409150814.GA11013@host1.jankratochvil.net> <20110410033503.GL19002@bubble.grove.modra.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110410033503.GL19002@bubble.grove.modra.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00228.txt.bz2 On Sun, 10 Apr 2011 05:35:03 +0200, Alan Modra wrote: > On Sat, Apr 09, 2011 at 05:08:14PM +0200, Jan Kratochvil wrote: > > * elf64-ppc.c (ppc64_elf_get_synthetic_symtab): Do not check for > > SEC_LOAD. > > OK. Checked in: http://sourceware.org/ml/binutils-cvs/2011-04/msg00097.html used a different / corrected comment: + /* SEC_LOAD may not be set if SEC is from a separate debug + info file. */ instead of former: + /* SEC_LOAD may not be set if ABFD is a separate debug info + file. */ gdb/ Fix convert_code_addr_to_desc_addr for ppc64 files after eu-strip. * elfread.c (elf_symfile_read): New variable synth_abfd, pass it to bfd_get_synthetic_symtab. * jit.c (jit_register_code): Pass NULL to the new parameter parent. * machoread.c (macho_add_oso_symfile): Pass main_objfile to the new parameter parent, remove the call to add_separate_debug_objfile. * solib.c (solib_read_symbols): Pass NULL to the new parameter parent. * symfile-mem.c (symbol_file_add_from_memory): Likewise. * symfile.c (symbol_file_add_with_addrs_or_offsets): New parameter parent, new comment for it, call add_separate_debug_objfile for it. (symbol_file_add_separate): Pass objfile as the parameter parent, remove the call to add_separate_debug_objfile. (symbol_file_add_from_bfd): New parameter parent, pass it. (symbol_file_add): Pass NULL to the new parameter parent. * symfile.h (symbol_file_add_from_bfd): New parameter parent. gdb/testsuite/ * gdb.base/eu-strip-infcall.c: New file. * gdb.base/eu-strip-infcall.exp: New file. Checked in: http://sourceware.org/ml/gdb-cvs/2011-04/msg00104.html No regressions on {ppc64-m64,ppc64-m32}-rhel61-linux-gnu. Thanks, Jan The corrected bfd/ part: http://sourceware.org/ml/binutils-cvs/2011-04/msg00097.html --- src/bfd/ChangeLog 2011/04/15 11:13:59 1.5305 +++ src/bfd/ChangeLog 2011/04/17 18:38:41 1.5306 @@ -1,3 +1,8 @@ +2011-04-17 Jan Kratochvil + + * elf64-ppc.c (ppc64_elf_get_synthetic_symtab): Do not check for + SEC_LOAD. + 2011-04-15 Sergio Durigan Junior * elf-bfd.h (struct sdt_note): New struct. --- src/bfd/elf64-ppc.c 2011/04/11 08:13:17 1.347 +++ src/bfd/elf64-ppc.c 2011/04/17 18:38:43 1.348 @@ -3317,8 +3317,9 @@ { if (sec->vma > ent) break; - if ((sec->flags & SEC_ALLOC) == 0 - || (sec->flags & SEC_LOAD) == 0) + /* SEC_LOAD may not be set if SEC is from a separate debug + info file. */ + if ((sec->flags & SEC_ALLOC) == 0) break; if ((sec->flags & SEC_CODE) != 0) s->section = sec;