From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20403 invoked by alias); 5 May 2011 08:45:23 -0000 Received: (qmail 20381 invoked by uid 22791); 5 May 2011 08:45:19 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST,TW_WC X-Spam-Check-By: sourceware.org Received: from mail-pw0-f41.google.com (HELO mail-pw0-f41.google.com) (209.85.160.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 05 May 2011 08:45:03 +0000 Received: by pwi10 with SMTP id 10so1267770pwi.0 for ; Thu, 05 May 2011 01:45:03 -0700 (PDT) Received: by 10.68.5.3 with SMTP id o3mr2843873pbo.4.1304585102863; Thu, 05 May 2011 01:45:02 -0700 (PDT) Received: from bubble.grove.modra.org ([115.187.252.19]) by mx.google.com with ESMTPS id t9sm1300739pbq.31.2011.05.05.01.44.58 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 05 May 2011 01:45:01 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 5C627170C2B8; Thu, 5 May 2011 18:14:54 +0930 (CST) Date: Thu, 05 May 2011 08:45:00 -0000 From: Alan Modra To: Dave Korn Cc: Jan Kratochvil , Kai Tietz , Nick Clifton , Kai Tietz , "H.J. Lu" , Binutils Subject: Re: gas -Werror compilation break [Re: [patch ld bfd gas]: Handle linkonce for cfi generated debug_frame and eh_frame data] Message-ID: <20110505084454.GH7018@bubble.grove.modra.org> Mail-Followup-To: Dave Korn , Jan Kratochvil , Kai Tietz , Nick Clifton , Kai Tietz , "H.J. Lu" , Binutils References: <4DB6E500.5030807@redhat.com> <20110427203457.GA12977@host1.jankratochvil.net> <4DC1EF60.5050308@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4DC1EF60.5050308@gmail.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00062.txt.bz2 On Thu, May 05, 2011 at 01:29:20AM +0100, Dave Korn wrote: > This fixes the breakage, but doesn't address the issue that it looks to me > like there's an omitted call to md_fix_up_eh_frame() after the second > invocation of get_cfi_seg(). The second call is for .debug_frame, so I wouldn't expect that to need md_fix_up_eh_frame. > Verified that it fixes the build on i686-pc-cygwin and > x86_64-unknown-linux-gnu, OK to install? No, this will break all targets that don't define md_fix_up_eh_frame. I'll be committing the following instead, which I wrote a couple of days ago but didn't get around to installing, or even writing a changelog. Index: gas/dw2gencfi.c =================================================================== RCS file: /cvs/src/src/gas/dw2gencfi.c,v retrieving revision 1.52 diff -u -p -r1.52 dw2gencfi.c --- gas/dw2gencfi.c 26 Apr 2011 15:28:07 -0000 1.52 +++ gas/dw2gencfi.c 3 May 2011 07:15:36 -0000 @@ -76,6 +76,13 @@ #define DWARF2_ADDR_SIZE(bfd) (bfd_arch_bits_per_address (bfd) / 8) #endif +#if defined (TE_PE) || defined (TE_PEP) +#define SUPPORT_FRAME_LINKONCE 1 +#else +#define SUPPORT_FRAME_LINKONCE 0 +#endif + +#if SUPPORT_FRAME_LINKONCE /* Private segment collection list. */ struct dwcfi_seg_list { @@ -141,13 +148,11 @@ alloc_debugseg_item (segT seg, int subse static segT is_now_linkonce_segment (void) { -#if defined (TE_PE) || defined (TE_PEP) if ((bfd_get_section_flags (stdoutput, now_seg) & (SEC_LINK_ONCE | SEC_LINK_DUPLICATES_DISCARD | SEC_LINK_DUPLICATES_ONE_ONLY | SEC_LINK_DUPLICATES_SAME_SIZE | SEC_LINK_DUPLICATES_SAME_CONTENTS)) != 0) return now_seg; -#endif return NULL; } @@ -227,6 +232,7 @@ dwcfi_hash_find_or_make (segT cseg, cons return item; } +#endif /* ??? Share this with dwarf2cfg.c. */ #ifndef TC_DWARF2_EMIT_OFFSET @@ -255,7 +261,9 @@ struct cfi_escape_data struct cfi_insn_data { struct cfi_insn_data *next; +#if SUPPORT_FRAME_LINKONCE segT cur_seg; +#endif int insn; union { @@ -293,7 +301,9 @@ struct cfi_insn_data struct fde_entry { struct fde_entry *next; +#if SUPPORT_FRAME_LINKONCE segT cseg; +#endif symbolS *start_address; symbolS *end_address; struct cfi_insn_data *data; @@ -304,13 +314,17 @@ struct fde_entry expressionS lsda; unsigned int return_column; unsigned int signal_frame; +#if SUPPORT_FRAME_LINKONCE int handled; +#endif }; struct cie_entry { struct cie_entry *next; +#if SUPPORT_FRAME_LINKONCE segT cur_seg; +#endif symbolS *start_address; unsigned int return_column; unsigned int signal_frame; @@ -357,8 +371,10 @@ alloc_fde_entry (void) frchain_now->frch_cfi_data->cur_fde_data = fde; *last_fde_data = fde; last_fde_data = &fde->next; +#if SUPPORT_FRAME_LINKONCE fde->cseg = is_now_linkonce_segment (); fde->handled = 0; +#endif fde->last = &fde->data; fde->return_column = DWARF2_DEFAULT_RETURN_COLUMN; fde->per_encoding = DW_EH_PE_omit; @@ -382,8 +398,9 @@ alloc_cfi_insn_data (void) *cur_fde_data->last = insn; cur_fde_data->last = &insn->next; +#if SUPPORT_FRAME_LINKONCE insn->cur_seg = is_now_linkonce_segment (); - +#endif return insn; } @@ -1552,8 +1569,10 @@ output_cie (struct cie_entry *cie, bfd_b { for (i = cie->first; i != cie->last; i = i->next) { +#if SUPPORT_FRAME_LINKONCE if (i->cur_seg != cie->cur_seg) continue; +#endif output_cfi_insn (i); } } @@ -1663,10 +1682,10 @@ output_fde (struct fde_entry *fde, struc } for (; first; first = first->next) - { - if (first->cur_seg == fde->cseg) - output_cfi_insn (first); - } +#if SUPPORT_FRAME_LINKONCE + if (first->cur_seg == fde->cseg) +#endif + output_cfi_insn (first); frag_align (align, DW_CFA_nop, 0); symbol_set_value_now (end_address); @@ -1681,8 +1700,11 @@ select_cie_for_fde (struct fde_entry *fd for (cie = cie_root; cie; cie = cie->next) { - if (cie->cur_seg != fde->cseg - || cie->return_column != fde->return_column +#if SUPPORT_FRAME_LINKONCE + if (cie->cur_seg != fde->cseg) + continue; +#endif + if (cie->return_column != fde->return_column || cie->signal_frame != fde->signal_frame || cie->per_encoding != fde->per_encoding || cie->lsda_encoding != fde->lsda_encoding) @@ -1780,7 +1802,9 @@ select_cie_for_fde (struct fde_entry *fd cie = (struct cie_entry *) xmalloc (sizeof (struct cie_entry)); cie->next = cie_root; cie_root = cie; +#if SUPPORT_FRAME_LINKONCE cie->cur_seg = fde->cseg; +#endif cie->return_column = fde->return_column; cie->signal_frame = fde->signal_frame; cie->per_encoding = fde->per_encoding; @@ -1805,12 +1829,14 @@ select_cie_for_fde (struct fde_entry *fd #ifdef md_reg_eh_frame_to_debug_frame static void -cfi_change_reg_numbers (struct cfi_insn_data *insn, segT ccseg) +cfi_change_reg_numbers (struct cfi_insn_data *insn, segT ccseg ATTRIBUTE_UNUSED) { for (; insn; insn = insn->next) { +#if SUPPORT_FRAME_LINKONCE if (insn->cur_seg != ccseg) continue; +#endif switch (insn->insn) { case DW_CFA_advance_loc: @@ -1852,15 +1878,22 @@ cfi_change_reg_numbers (struct cfi_insn_ #endif static segT -get_cfi_seg (segT cseg, const char *base, flagword flags, int align) +get_cfi_seg (segT cseg ATTRIBUTE_UNUSED, + const char *base, flagword flags, int align) { +#if SUPPORT_FRAME_LINKONCE struct dwcfi_seg_list *l; l = dwcfi_hash_find_or_make (cseg, base, flags); - subseg_set (l->seg, l->subseg); - record_alignment (l->seg, align); - return l->seg; + cseg = l->seg; + subseg_set (cseg, l->subseg); +#else + cseg = subseg_new (base, 0); + bfd_set_section_flags (stdoutput, cseg, flags); +#endif + record_alignment (cseg, align); + return cseg; } void @@ -1881,11 +1914,24 @@ cfi_finish (void) save_flag_traditional_format = flag_traditional_format; flag_traditional_format = 1; +#if !SUPPORT_FRAME_LINKONCE + /* Open .eh_frame section. */ + cfi_seg = get_cfi_seg (NULL, ".eh_frame", + SEC_ALLOC | SEC_LOAD | SEC_DATA + | DWARF2_EH_FRAME_READ_ONLY, + EH_FRAME_ALIGNMENT); +#ifdef md_fix_up_eh_frame + md_fix_up_eh_frame (cfi_seg); +#else + (void) cfi_seg; +#endif +#endif + do { ccseg = NULL; - cfi_seg = NULL; seek_next_seg = 0; + for (cie = cie_root; cie; cie = cie_next) { cie_next = cie->next; @@ -1895,6 +1941,7 @@ cfi_finish (void) for (fde = all_fde_data; fde ; fde = fde->next) { +#if SUPPORT_FRAME_LINKONCE if (fde->handled != 0) continue; if (seek_next_seg && fde->cseg != ccseg) @@ -1912,10 +1959,13 @@ cfi_finish (void) EH_FRAME_ALIGNMENT); #ifdef md_fix_up_eh_frame md_fix_up_eh_frame (cfi_seg); +#else + (void) cfi_seg; #endif seek_next_seg = 1; } fde->handled = 1; +#endif if (fde->end_address == NULL) { @@ -1928,10 +1978,12 @@ cfi_finish (void) fde->next == NULL ? EH_FRAME_ALIGNMENT : 2); } } - while (seek_next_seg == 2); + while (SUPPORT_FRAME_LINKONCE && seek_next_seg == 2); +#if SUPPORT_FRAME_LINKONCE for (fde = all_fde_data; fde ; fde = fde->next) fde->handled = 0; +#endif flag_traditional_format = save_flag_traditional_format; } @@ -1940,11 +1992,16 @@ cfi_finish (void) { int alignment = ffs (DWARF2_ADDR_SIZE (stdoutput)) - 1; +#if !SUPPORT_FRAME_LINKONCE + get_cfi_seg (NULL, ".debug_frame", + SEC_READONLY | SEC_DEBUGGING, + alignment); +#endif do { ccseg = NULL; - cfi_seg = NULL; seek_next_seg = 0; + for (cie = cie_root; cie; cie = cie_next) { cie_next = cie->next; @@ -1954,6 +2011,7 @@ cfi_finish (void) for (fde = all_fde_data; fde ; fde = fde->next) { +#if SUPPORT_FRAME_LINKONCE if (fde->handled != 0) continue; if (seek_next_seg && fde->cseg != ccseg) @@ -1965,12 +2023,13 @@ cfi_finish (void) { ccseg = fde->cseg; /* Open .debug_frame section. */ - cfi_seg = get_cfi_seg (ccseg, ".debug_frame", - SEC_READONLY | SEC_DEBUGGING, - alignment); + get_cfi_seg (ccseg, ".debug_frame", + SEC_READONLY | SEC_DEBUGGING, + alignment); seek_next_seg = 1; } fde->handled = 1; +#endif if (fde->end_address == NULL) { as_bad (_("open CFI at the end of file; missing .cfi_endproc directive")); @@ -1984,10 +2043,12 @@ cfi_finish (void) output_fde (fde, cie, FALSE, first, alignment); } } - while (seek_next_seg == 2); + while (SUPPORT_FRAME_LINKONCE && seek_next_seg == 2); +#if SUPPORT_FRAME_LINKONCE for (fde = all_fde_data; fde ; fde = fde->next) fde->handled = 0; +#endif } } -- Alan Modra Australia Development Lab, IBM