From: Alan Modra <amodra@gmail.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Binutils <binutils@sourceware.org>
Subject: Re: PATCH: PR ld/12730: regression] crash when allocating in a static constructor
Date: Sat, 07 May 2011 14:05:00 -0000 [thread overview]
Message-ID: <20110507140441.GS7018@bubble.grove.modra.org> (raw)
In-Reply-To: <BANLkTimWntPAuVK8zNzK0kek0nFcfUJW+A@mail.gmail.com>
On Sat, May 07, 2011 at 06:39:42AM -0700, H.J. Lu wrote:
> + /* We need to reverse-copy input .ctors/.dtors sections if
> + they are placed in .init_array/.finit_array for output. */
> + if (o->size > address_size
> + && (o->name[6] == 0 || o->name[6] == '.')
Possible segv on accessing name[6]. Test this after the strncmp
calls. OK with that change.
> + && ((strncmp (o->name, ".ctors", 6) == 0
> + && strcmp (o->output_section->name,
> + ".init_array") == 0)
> + || (strncmp (o->name, ".dtors", 6) == 0
> + && strcmp (o->output_section->name,
> + ".fini_array") == 0)))
--
Alan Modra
Australia Development Lab, IBM
next prev parent reply other threads:[~2011-05-07 14:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-05 5:19 H.J. Lu
2011-05-05 8:27 ` Alan Modra
2011-05-05 13:27 ` H.J. Lu
2011-05-05 14:13 ` Alan Modra
2011-05-06 13:23 ` H.J. Lu
2011-05-06 16:16 ` H.J. Lu
2011-05-07 8:11 ` Alan Modra
2011-05-07 13:40 ` H.J. Lu
2011-05-07 14:05 ` Alan Modra [this message]
2011-05-09 13:53 ` Alan Modra
2011-05-09 14:09 ` H.J. Lu
2011-06-19 19:18 ` Thomas Schwinge
2011-06-21 15:14 ` Nick Clifton
2011-05-15 10:14 Craig Southeren
2011-05-16 0:15 ` Alan Modra
2011-05-16 0:37 ` Craig Southeren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110507140441.GS7018@bubble.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).