From: Alan Modra <amodra@gmail.com>
To: Bernd Schmidt <bernds@codesourcery.com>
Cc: binutils@sources.redhat.com, Paul Brook <paul@codesourcery.com>,
"Joseph S. Myers" <joseph@codesourcery.com>
Subject: Re: Fix ld testcases on c6x
Date: Wed, 11 May 2011 11:56:00 -0000 [thread overview]
Message-ID: <20110511115605.GF3625@bubble.grove.modra.org> (raw)
In-Reply-To: <4DCA6E9F.3030409@codesourcery.com>
On Wed, May 11, 2011 at 01:10:23PM +0200, Bernd Schmidt wrote:
> +if { ![ld_assemble $as "$as_opt $srcdir/$subdir/tbss.s" tmpdir/tbss.o ]
> + || ![ld_assemble $as "$as_opt $srcdir/$subdir/frame.s" tmpdir/frame.o] }
Passing options like this in the "source" parameter of ld_assemble
isn't the cleanest way. Better would be to twiddle ASFLAGS (See
ld-frv/tls.exp for an example). I'll OK your patch changed to use
ASFLAGS.
Best would be to add an "asflags" parameter to ld_assemble but I won't
ask for that since I probably wouldn't bother to do so myself..
Preapproved if you do care to go that route.
--
Alan Modra
Australia Development Lab, IBM
next prev parent reply other threads:[~2011-05-11 11:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-11 11:11 Bernd Schmidt
2011-05-11 11:20 ` Joseph S. Myers
2011-05-11 11:56 ` Alan Modra [this message]
2011-05-11 12:31 ` Bernd Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110511115605.GF3625@bubble.grove.modra.org \
--to=amodra@gmail.com \
--cc=bernds@codesourcery.com \
--cc=binutils@sources.redhat.com \
--cc=joseph@codesourcery.com \
--cc=paul@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).