From: Hans-Peter Nilsson <hans-peter.nilsson@axis.com>
To: gingold@adacore.com
Cc: binutils@sourceware.org
Subject: Re: [Patch] Add private dumper to objdump
Date: Mon, 16 May 2011 13:36:00 -0000 [thread overview]
Message-ID: <201105161335.p4GDZms9016712@ignucius.se.axis.com> (raw)
In-Reply-To: <43974448-D817-48FF-B7E8-1AE01EC9D0C9@adacore.com> (message from Tristan Gingold on Mon, 16 May 2011 14:22:32 +0200)
> From: Tristan Gingold <gingold@adacore.com>
> Date: Mon, 16 May 2011 14:22:32 +0200
> On May 10, 2011, at 4:46 AM, Alan Modra wrote:
>
> > On Thu, May 05, 2011 at 04:27:38PM +0200, Tristan Gingold wrote:
> >> * od-xcoff.c: New file.
> >> * objdump.h: New file.
> >> * objdump.c: Include objdump.h
> >> (dump_private_options, objdump_private_vectors): New variables.
> >> (usage): Mention -P/--private. Display handled options.
> >> (long_options): Add -P/--private.
> >> (dump_target_specific): New function.
> >> (dump_bfd): Handle dump_private_options.
> >> (main): Handle -P.
> >> * doc/binutils.texi (objdump): Document -P/--private.
> >> * configure.in (OBJDUMP_PRIVATE_VECTORS, OBJDUMP_PRIVATE_OFILES):
> >> New variables, compute them.
> >> (od_vectors): Add vectors for private dumpers. Make them uniq.
> >> (OBJDUMP_DEFS): Add OBJDUMP_PRIVATE_VECTORS.
> >> * Makefile.am (HFILES): Add objdump.h
> >> (CFILES): Add od-xcoff.c
> >> (OBJDUMP_PRIVATE_OFILES): New variable.
> >> (objdump_DEPENDENCIES): Append OBJDUMP_PRIVATE_OFILES.
> >> (objdump_LDADD): Ditto.
> >> (EXTRA_objdump_SOURCES): Define.
> >> * Makefile.in: Regenerate.
> >> * configure: Regenerate.
> >
> > OK.
>
> Thanks, committed.
Looks like you missed updating the test-suite. Changing the
format of objdump or readelf requires that. My autotester
complains for cris-axis-elf and cris-axis-linux-gnu:
Running /tmp/hpautotest-binutils/bsrc/src/ld/testsuite/ld-scripts/phdrs.exp ...
FAIL: PHDRS
Running /tmp/hpautotest-binutils/bsrc/src/ld/testsuite/ld-scripts/phdrs2.exp ...
FAIL: PHDRS2
But, I can't trivially figure out why the test-suite fails as it
does; it looks like the same thing would happen for all
architectures and the failure mode is weird. Quoting the ld.log
for the first failure ("same" for the second):
Running /tmp/hpautotest-binutils/bsrc/src/ld/testsuite/ld-scripts/phdrs.exp ...
/tmp/hpautotest-binutils/cris-axis-elf/ld/../gas/as-new -o tmpdir/phdrs.o /tmp/hpautotest-binutils/bsrc/src/ld/testsuite/ld-scripts/phdrs.s
Executing on host: sh -c {/tmp/hpautotest-binutils/cris-axis-elf/ld/../gas/as-new -o tmpdir/phdrs.o /tmp/hpautotest-binutils/bsrc/src/ld/testsuite/ld-scripts/phdrs.s 2>&1} /dev/null ld.tmp (timeout = 300)
/tmp/hpautotest-binutils/cris-axis-elf/ld/ld-new -o tmpdir/phdrs -T /tmp/hpautotest-binutils/bsrc/src/ld/testsuite/ld-scripts/phdrs.t tmpdir/phdrs.o
Executing on host: sh -c {/tmp/hpautotest-binutils/cris-axis-elf/ld/ld-new -o tmpdir/phdrs -T /tmp/hpautotest-binutils/bsrc/src/ld/testsuite/ld-scripts/phdrs.t tmpdir/phdrs.o 2>&1} /dev/null ld.tmp (timeout = 300)
/tmp/hpautotest-binutils/cris-axis-elf/ld/../binutils/objdump --private tmpdir/phdrs
Executing on host: sh -c {/tmp/hpautotest-binutils/cris-axis-elf/ld/../binutils/objdump --private tmpdir/phdrs 2>&1} /dev/null ld.tmp (timeout = 300)
/tmp/hpautotest-binutils/cris-axis-elf/ld/../binutils/objdump: 'a.out': No such file
/tmp/hpautotest-binutils/cris-axis-elf/ld/../binutils/objdump: 'a.out': No such file
/tmp/hpautotest-binutils/cris-axis-elf/ld/../binutils/objdump: 'a.out': No such file
FAIL: PHDRS
brgds, H-P
next prev parent reply other threads:[~2011-05-16 13:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-05 14:29 Tristan Gingold
2011-05-10 2:47 ` Alan Modra
2011-05-16 12:22 ` Tristan Gingold
2011-05-16 13:36 ` Hans-Peter Nilsson [this message]
2011-05-16 13:41 ` H.J. Lu
2011-05-16 13:44 ` Tristan Gingold
2011-05-16 13:48 ` H.J. Lu
2011-05-16 13:50 ` Tristan Gingold
2011-05-16 13:43 ` Tristan Gingold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201105161335.p4GDZms9016712@ignucius.se.axis.com \
--to=hans-peter.nilsson@axis.com \
--cc=binutils@sourceware.org \
--cc=gingold@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).