From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1219 invoked by alias); 16 May 2011 13:36:17 -0000 Received: (qmail 1156 invoked by uid 22791); 16 May 2011 13:36:16 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,TW_BJ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from anubis.se.axis.com (HELO anubis.se.axis.com) (195.60.68.12) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 16 May 2011 13:35:55 +0000 Received: from localhost (localhost [127.0.0.1]) by anubis.se.axis.com (Postfix) with ESMTP id E639319D18; Mon, 16 May 2011 15:35:49 +0200 (CEST) Received: from anubis.se.axis.com ([127.0.0.1]) by localhost (anubis.se.axis.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 3jYkUfEUrX+p; Mon, 16 May 2011 15:35:49 +0200 (CEST) Received: from seth.se.axis.com (seth.se.axis.com [10.0.2.172]) by anubis.se.axis.com (Postfix) with ESMTP id 04D2219D14; Mon, 16 May 2011 15:35:48 +0200 (CEST) Received: from ignucius.se.axis.com (ignucius.se.axis.com [10.88.21.50]) by seth.se.axis.com (Postfix) with ESMTP id CF6293E068; Mon, 16 May 2011 15:35:48 +0200 (CEST) Received: from ignucius.se.axis.com (localhost [127.0.0.1]) by ignucius.se.axis.com (8.12.8p1/8.12.8/Debian-2woody1) with ESMTP id p4GDZmF6016716; Mon, 16 May 2011 15:35:48 +0200 Received: (from hp@localhost) by ignucius.se.axis.com (8.12.8p1/8.12.8/Debian-2woody1) id p4GDZms9016712; Mon, 16 May 2011 15:35:48 +0200 Date: Mon, 16 May 2011 13:36:00 -0000 Message-Id: <201105161335.p4GDZms9016712@ignucius.se.axis.com> From: Hans-Peter Nilsson To: gingold@adacore.com CC: binutils@sourceware.org In-reply-to: <43974448-D817-48FF-B7E8-1AE01EC9D0C9@adacore.com> (message from Tristan Gingold on Mon, 16 May 2011 14:22:32 +0200) Subject: Re: [Patch] Add private dumper to objdump MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00213.txt.bz2 > From: Tristan Gingold > Date: Mon, 16 May 2011 14:22:32 +0200 > On May 10, 2011, at 4:46 AM, Alan Modra wrote: > > > On Thu, May 05, 2011 at 04:27:38PM +0200, Tristan Gingold wrote: > >> * od-xcoff.c: New file. > >> * objdump.h: New file. > >> * objdump.c: Include objdump.h > >> (dump_private_options, objdump_private_vectors): New variables. > >> (usage): Mention -P/--private. Display handled options. > >> (long_options): Add -P/--private. > >> (dump_target_specific): New function. > >> (dump_bfd): Handle dump_private_options. > >> (main): Handle -P. > >> * doc/binutils.texi (objdump): Document -P/--private. > >> * configure.in (OBJDUMP_PRIVATE_VECTORS, OBJDUMP_PRIVATE_OFILES): > >> New variables, compute them. > >> (od_vectors): Add vectors for private dumpers. Make them uniq. > >> (OBJDUMP_DEFS): Add OBJDUMP_PRIVATE_VECTORS. > >> * Makefile.am (HFILES): Add objdump.h > >> (CFILES): Add od-xcoff.c > >> (OBJDUMP_PRIVATE_OFILES): New variable. > >> (objdump_DEPENDENCIES): Append OBJDUMP_PRIVATE_OFILES. > >> (objdump_LDADD): Ditto. > >> (EXTRA_objdump_SOURCES): Define. > >> * Makefile.in: Regenerate. > >> * configure: Regenerate. > > > > OK. > > Thanks, committed. Looks like you missed updating the test-suite. Changing the format of objdump or readelf requires that. My autotester complains for cris-axis-elf and cris-axis-linux-gnu: Running /tmp/hpautotest-binutils/bsrc/src/ld/testsuite/ld-scripts/phdrs.exp ... FAIL: PHDRS Running /tmp/hpautotest-binutils/bsrc/src/ld/testsuite/ld-scripts/phdrs2.exp ... FAIL: PHDRS2 But, I can't trivially figure out why the test-suite fails as it does; it looks like the same thing would happen for all architectures and the failure mode is weird. Quoting the ld.log for the first failure ("same" for the second): Running /tmp/hpautotest-binutils/bsrc/src/ld/testsuite/ld-scripts/phdrs.exp ... /tmp/hpautotest-binutils/cris-axis-elf/ld/../gas/as-new -o tmpdir/phdrs.o /tmp/hpautotest-binutils/bsrc/src/ld/testsuite/ld-scripts/phdrs.s Executing on host: sh -c {/tmp/hpautotest-binutils/cris-axis-elf/ld/../gas/as-new -o tmpdir/phdrs.o /tmp/hpautotest-binutils/bsrc/src/ld/testsuite/ld-scripts/phdrs.s 2>&1} /dev/null ld.tmp (timeout = 300) /tmp/hpautotest-binutils/cris-axis-elf/ld/ld-new -o tmpdir/phdrs -T /tmp/hpautotest-binutils/bsrc/src/ld/testsuite/ld-scripts/phdrs.t tmpdir/phdrs.o Executing on host: sh -c {/tmp/hpautotest-binutils/cris-axis-elf/ld/ld-new -o tmpdir/phdrs -T /tmp/hpautotest-binutils/bsrc/src/ld/testsuite/ld-scripts/phdrs.t tmpdir/phdrs.o 2>&1} /dev/null ld.tmp (timeout = 300) /tmp/hpautotest-binutils/cris-axis-elf/ld/../binutils/objdump --private tmpdir/phdrs Executing on host: sh -c {/tmp/hpautotest-binutils/cris-axis-elf/ld/../binutils/objdump --private tmpdir/phdrs 2>&1} /dev/null ld.tmp (timeout = 300) /tmp/hpautotest-binutils/cris-axis-elf/ld/../binutils/objdump: 'a.out': No such file /tmp/hpautotest-binutils/cris-axis-elf/ld/../binutils/objdump: 'a.out': No such file /tmp/hpautotest-binutils/cris-axis-elf/ld/../binutils/objdump: 'a.out': No such file FAIL: PHDRS brgds, H-P