public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Alan Modra <amodra@gmail.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: binutils@sourceware.org
Subject: Re: PATCH: PR ld/12761: .gnu.warning.* doesn't work when building shared library
Date: Tue, 17 May 2011 01:51:00 -0000	[thread overview]
Message-ID: <20110517015038.GK20800@bubble.grove.modra.org> (raw)
In-Reply-To: <20110516190512.GA10653@intel.com>

On Mon, May 16, 2011 at 12:05:12PM -0700, H.J. Lu wrote:
> @@ -3423,7 +3423,7 @@ elf_link_add_object_symbols (bfd *abfd, struct bfd_link_info *info)
>       .gnu.warning.SYMBOL are treated as warning symbols for the given
>       symbol.  This differs from .gnu.warning sections, which generate
>       warnings when they are included in an output file.  */
> -  if (info->executable)
> +  if (info->executable || info->shared)
>      {
>        asection *s;
>  

Can one of the old-timers comment on this?  rev 1.1 of bfd/elflink.h
specifically excluded shared libs..

1.1          (rth      03-May-99):   if (! info->shared)

-- 
Alan Modra
Australia Development Lab, IBM

  reply	other threads:[~2011-05-17  1:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-16 19:05 H.J. Lu
2011-05-17  1:51 ` Alan Modra [this message]
2011-05-17  6:04 ` Ian Lance Taylor
2011-05-17 13:12   ` H.J. Lu
2011-05-17 14:30     ` Ian Lance Taylor
2011-05-17 14:36       ` H.J. Lu
2011-05-17 15:02         ` Ian Lance Taylor
2011-05-17 15:05           ` H.J. Lu
2011-05-17 16:34             ` Ian Lance Taylor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110517015038.GK20800@bubble.grove.modra.org \
    --to=amodra@gmail.com \
    --cc=binutils@sourceware.org \
    --cc=hjl.tools@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).