From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10240 invoked by alias); 17 May 2011 01:51:02 -0000 Received: (qmail 10142 invoked by uid 22791); 17 May 2011 01:51:01 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST X-Spam-Check-By: sourceware.org Received: from mail-pw0-f41.google.com (HELO mail-pw0-f41.google.com) (209.85.160.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 17 May 2011 01:50:45 +0000 Received: by pwi12 with SMTP id 12so92343pwi.0 for ; Mon, 16 May 2011 18:50:45 -0700 (PDT) Received: by 10.142.59.5 with SMTP id h5mr69977wfa.0.1305597044941; Mon, 16 May 2011 18:50:44 -0700 (PDT) Received: from bubble.grove.modra.org ([115.187.252.19]) by mx.google.com with ESMTPS id w14sm51368wfh.20.2011.05.16.18.50.42 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 16 May 2011 18:50:43 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id A525B16DE443; Tue, 17 May 2011 11:20:38 +0930 (CST) Date: Tue, 17 May 2011 01:51:00 -0000 From: Alan Modra To: "H.J. Lu" Cc: binutils@sourceware.org Subject: Re: PATCH: PR ld/12761: .gnu.warning.* doesn't work when building shared library Message-ID: <20110517015038.GK20800@bubble.grove.modra.org> Mail-Followup-To: "H.J. Lu" , binutils@sourceware.org References: <20110516190512.GA10653@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110516190512.GA10653@intel.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00231.txt.bz2 On Mon, May 16, 2011 at 12:05:12PM -0700, H.J. Lu wrote: > @@ -3423,7 +3423,7 @@ elf_link_add_object_symbols (bfd *abfd, struct bfd_link_info *info) > .gnu.warning.SYMBOL are treated as warning symbols for the given > symbol. This differs from .gnu.warning sections, which generate > warnings when they are included in an output file. */ > - if (info->executable) > + if (info->executable || info->shared) > { > asection *s; > Can one of the old-timers comment on this? rev 1.1 of bfd/elflink.h specifically excluded shared libs.. 1.1 (rth 03-May-99): if (! info->shared) -- Alan Modra Australia Development Lab, IBM