From: Hans-Peter Nilsson <hans-peter.nilsson@axis.com>
To: hjl.tools@gmail.com
Cc: hp@axis.com, amodra@gmail.com, binutils@sourceware.org
Subject: Re: Regressions with "bfd_arch_get_compatible"
Date: Sun, 05 Jun 2011 00:08:00 -0000 [thread overview]
Message-ID: <201106050007.p5507v3N006354@ignucius.se.axis.com> (raw)
In-Reply-To: <BANLkTik-FZYva5smzDiXJeDZWAOOJKZxQw@mail.gmail.com> (hjl.tools@gmail.com)
> Date: Sat, 4 Jun 2011 11:18:33 -0700
> From: "H.J. Lu" <hjl.tools@gmail.com>
> On Sat, Jun 4, 2011 at 5:16 AM, Hans-Peter Nilsson
> <hans-peter.nilsson@axis.com> wrote:
> >> Date: Sat, 4 Jun 2011 13:33:58 +0930
> >> From: Alan Modra <amodra@gmail.com>
> >
> >> Â Â Â * archures.c (bfd_arch_get_compatible): If one arch is unknown,
> >> Â Â Â return the other arch.
> >> Â Â Â * elfcode.h (elf_object_p): Allow explicit match to generic ELF
> >> Â Â Â target.
> >
> > Looks like the target lost leverage in bfd_arch_get_compatible.
> >
> > Regressions for cris-elf:
> >
>
> elf_object_p change also breaks Linux/x86-64. I checked in a patch
> to revert it. Please check if it fixes cris-elf.
The partial reversion did fix the regressions, but I also have
to point out that reverting like that seems like a breach of
protocol as I understand it.
brgds, H-P
next prev parent reply other threads:[~2011-06-05 0:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-04 4:04 bfd_arch_get_compatible Alan Modra
2011-06-04 12:16 ` Regressions with "bfd_arch_get_compatible" Hans-Peter Nilsson
2011-06-04 18:18 ` H.J. Lu
2011-06-05 0:08 ` Hans-Peter Nilsson [this message]
2011-06-04 17:20 ` bfd_arch_get_compatible H.J. Lu
2011-06-04 18:00 ` bfd_arch_get_compatible H.J. Lu
2011-06-06 1:26 ` bfd_arch_get_compatible Alan Modra
2011-06-06 2:13 ` bfd_arch_get_compatible H.J. Lu
2011-06-06 2:24 ` bfd_arch_get_compatible H.J. Lu
2011-06-06 2:39 ` bfd_arch_get_compatible Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201106050007.p5507v3N006354@ignucius.se.axis.com \
--to=hans-peter.nilsson@axis.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
--cc=hp@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).