From: Alan Modra <amodra@gmail.com>
To: Roland McGrath <mcgrathr@google.com>
Cc: bug-binutils@gnu.org, binutils@sourceware.org
Subject: Re: .gnu.warning.foo interferes with archive-member rules
Date: Wed, 08 Jun 2011 00:36:00 -0000 [thread overview]
Message-ID: <20110608003540.GC4172@bubble.grove.modra.org> (raw)
In-Reply-To: <BANLkTimL5RxUHv0JzxxV_JsMcyWwBKQh+eF7ene2SPAEJEjj8A@mail.gmail.com>
On Tue, Jun 07, 2011 at 09:50:18AM -0700, Roland McGrath wrote:
> Thanks! I don't understand your changes at all off hand, and I strongly
> suspected that the patch I tried was too simple-minded to be right.
Setting "follow" true for the elf_link_hash_lookup calls in
_bfd_elf_archive_symbol_lookup means we get to the real symbol in the
elf_link_add_archive_symbols loop you were patching. We want that
because elf_link_add_archive_symbols needs to make a decision
depending on whether the symbol is defined or not, and specially treat
commons. Indirect and warning syms can point to any other sym type.
The lang_one_common change is needed in any function called by
bfd_link_hash_traverse. When warning symbols are created, they
replace the "real" entry in the hash table, so you never get to see
the real symbol in a hash traversal.
--
Alan Modra
Australia Development Lab, IBM
next prev parent reply other threads:[~2011-06-08 0:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <x57jlixed1md.fsf@frobland.mtv.corp.google.com>
2011-06-07 9:08 ` Alan Modra
[not found] ` <BANLkTimL5RxUHv0JzxxV_JsMcyWwBKQh+eF7ene2SPAEJEjj8A@mail.gmail.com>
2011-06-08 0:36 ` Alan Modra [this message]
2011-06-08 4:48 ` H.J. Lu
2011-06-14 2:57 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110608003540.GC4172@bubble.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=bug-binutils@gnu.org \
--cc=mcgrathr@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).