From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9760 invoked by alias); 6 Jul 2011 03:27:08 -0000 Received: (qmail 9751 invoked by uid 22791); 6 Jul 2011 03:27:07 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-gy0-f169.google.com (HELO mail-gy0-f169.google.com) (209.85.160.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 06 Jul 2011 03:26:53 +0000 Received: by gyg13 with SMTP id 13so3068616gyg.0 for ; Tue, 05 Jul 2011 20:26:53 -0700 (PDT) Received: by 10.151.112.16 with SMTP id p16mr4806590ybm.252.1309922813373; Tue, 05 Jul 2011 20:26:53 -0700 (PDT) Received: from bubble.grove.modra.org ([115.187.252.19]) by mx.google.com with ESMTPS id c10sm2349811ybf.17.2011.07.05.20.26.50 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 05 Jul 2011 20:26:52 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 7B3A8175A005; Wed, 6 Jul 2011 12:56:46 +0930 (CST) Date: Wed, 06 Jul 2011 04:45:00 -0000 From: Alan Modra To: Tristan Gingold Cc: binutils Development Subject: Re: [patch/gas]: simplify frag_grow Message-ID: <20110706032646.GG26365@bubble.grove.modra.org> Mail-Followup-To: Tristan Gingold , binutils Development References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00069.txt.bz2 On Tue, Jul 05, 2011 at 02:04:35PM +0200, Tristan Gingold wrote: I agree with all your reasoning, but I'd like to keep the final check so that we don't depend on obstack_chunk_alloc being xmalloc. > - if (obstack_room (&frchain_now->frch_obstack) < nchars) > - as_fatal (_("can't extend frag %u chars"), nchars); > } -- Alan Modra Australia Development Lab, IBM