From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17477 invoked by alias); 9 Nov 2011 16:00:51 -0000 Received: (qmail 17457 invoked by uid 22791); 9 Nov 2011 16:00:49 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,TW_CP X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 09 Nov 2011 16:00:37 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=EU1-MAIL.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1ROAZm-00028V-Mr from pedro_alves@mentor.com ; Wed, 09 Nov 2011 08:00:34 -0800 Received: from scottsdale.localnet ([172.16.63.104]) by EU1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.1830); Wed, 9 Nov 2011 16:00:32 +0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [rfc][1/3] Remote core file generation: BFD support Date: Wed, 09 Nov 2011 16:00:00 -0000 User-Agent: KMail/1.13.6 (Linux/2.6.38-12-generic; KDE/4.7.2; x86_64; ; ) Cc: "Ulrich Weigand" , binutils@sourceware.org References: <201110211856.p9LIu92B012443@d06av02.portsmouth.uk.ibm.com> In-Reply-To: <201110211856.p9LIu92B012443@d06av02.portsmouth.uk.ibm.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201111091600.30812.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00061.txt.bz2 On Friday 21 October 2011 19:56:09, Ulrich Weigand wrote: > Index: bfd/elf32-arm.c > =================================================================== > RCS file: /cvs/src/src/bfd/elf32-arm.c,v > retrieving revision 1.278 > diff -u -p -r1.278 elf32-arm.c > --- bfd/elf32-arm.c 19 Oct 2011 07:17:13 -0000 1.278 > +++ bfd/elf32-arm.c 21 Oct 2011 16:49:54 -0000 > @@ -1986,6 +1986,55 @@ elf32_arm_nabi_grok_psinfo (bfd *abfd, E > return TRUE; > } > > +static char * > +elf32_arm_nabi_write_core_note (bfd *abfd, char *buf, int *bufsiz, > + int note_type, ...) > +{ > + switch (note_type) > + { > + default: > + return NULL; > + > + case NT_PRPSINFO: > + { > + char data[124]; > + va_list ap; > + > + va_start (ap, note_type); > + memset (data, 0, 28); > + strncpy (data + 28, va_arg (ap, const char *), 16); > + strncpy (data + 44, va_arg (ap, const char *), 80); The `data' buffer should be zero initialized, to avoid leaving garbage on the core, when the passed in fname and psargs are less than 16 and 80 bytes long respectively. It's true the caller does that itself today, but your patch 2 (rightly) makes it not do so anymore. -- Pedro Alves