From: Alan Modra <amodra@gmail.com>
To: binutils@sourceware.org
Subject: PR12758, lto vs archives.
Date: Sun, 15 Jan 2012 01:56:00 -0000 [thread overview]
Message-ID: <20120115015601.GF3708@bubble.grove.modra.org> (raw)
As the comment says, we only want to open new files. added.head points
at start of statement list, ie. we were reopening everything.
PR ld/12758
* ldlang.c (lang_process): Don't reopen all files, just those
newly added by plugin.
Index: ld/ldlang.c
===================================================================
RCS file: /cvs/src/src/ld/ldlang.c,v
retrieving revision 1.380
diff -u -p -r1.380 ldlang.c
--- ld/ldlang.c 15 Nov 2011 18:22:27 -0000 1.380
+++ ld/ldlang.c 15 Jan 2012 01:46:38 -0000
@@ -1,6 +1,6 @@
/* Linker command language support.
Copyright 1991, 1992, 1993, 1994, 1995, 1996, 1997, 1998, 1999, 2000,
- 2001, 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011
+ 2001, 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012
Free Software Foundation, Inc.
This file is part of the GNU Binutils.
@@ -6590,7 +6590,7 @@ lang_process (void)
plugin_error_plugin ());
/* Open any newly added files, updating the file chains. */
link_info.loading_lto_outputs = TRUE;
- open_input_bfds (added.head, OPEN_BFD_NORMAL);
+ open_input_bfds (*added.tail, OPEN_BFD_NORMAL);
/* Restore the global list pointer now they have all been added. */
lang_list_remove_tail (stat_ptr, &added);
/* And detach the fresh ends of the file lists. */
--
Alan Modra
Australia Development Lab, IBM
reply other threads:[~2012-01-15 1:56 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120115015601.GF3708@bubble.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).