public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* [Patch Darwin/testsuite/objcopy] Do not try to run the copy-2/3.d tests for darwin.
@ 2011-12-30 21:07 Iain Sandoe
  2012-01-02 11:27 ` Tristan Gingold
  0 siblings, 1 reply; 3+ messages in thread
From: Iain Sandoe @ 2011-12-30 21:07 UTC (permalink / raw)
  To: binutils Development; +Cc: Tristan Gingold

trying to work through the test-suite to find which fails represent  
stuff we still need to implement (and which are noise).

AFAICS, these two tests are not applicable to mach-o, certainly as  
they stand (they would require a different .s file to work).

OK?
Iain

binutils/testsuite:

	* binutils-all/copy-2.d: Do not run for Darwin.
	* binutils-all/copy-3.d: Likewise.

  binutils/testsuite/binutils-all/copy-2.d |    2 +-
  binutils/testsuite/binutils-all/copy-3.d |    2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/binutils/testsuite/binutils-all/copy-2.d b/binutils/ 
testsuite/binutils-all/copy-2.d
index 5636ff6..4640709 100644
--- a/binutils/testsuite/binutils-all/copy-2.d
+++ b/binutils/testsuite/binutils-all/copy-2.d
@@ -3,7 +3,7 @@
  #objcopy: --set-section-flags foo=contents,alloc,load,code
  #name: copy with setting section flags 2
  #source: copytest.s
-#not-target: *-*-*aout *-*-aix* h8300-*-* hppa*-*-hpux* m68k-*-netbsd  
m68k-*-openbsd* mips-sony-bsd* mips-*-ultrix* mips-*-osf* mips-*- 
ecoff* mips-*-irix mips-*-irix[2-4] mips-*-riscos* ns32k-*-netbsd
+#not-target: *-*-*aout *-*-aix* h8300-*-* hppa*-*-hpux* m68k-*-netbsd  
m68k-*-openbsd* mips-sony-bsd* mips-*-ultrix* mips-*-osf* mips-*- 
ecoff* mips-*-irix mips-*-irix[2-4] mips-*-riscos* ns32k-*-netbsd *-*- 
darwin*
  # Note - we use copytest.s and a section named "foo" rather
  # than .text because for some file formats (eg PE) the .text
  # section has a fixed set of flags and these cannot be changed.
diff --git a/binutils/testsuite/binutils-all/copy-3.d b/binutils/ 
testsuite/binutils-all/copy-3.d
index 551517c..2d42ce8 100644
--- a/binutils/testsuite/binutils-all/copy-3.d
+++ b/binutils/testsuite/binutils-all/copy-3.d
@@ -3,7 +3,7 @@
  #objcopy: --set-section-flags .text=alloc,data
  #name: copy with setting section flags 3
  #source: bintest.s
-#not-target: *-*-*aout *-*-*pe *-*-*coff hppa*-*-hpux* i*86-*-cygwin*  
i*86-*-mingw32* m68k-*-netbsd m68k-*-openbsd* ns32k-*-netbsd x86_64-*- 
mingw*
+#not-target: *-*-*aout *-*-*pe *-*-*coff hppa*-*-hpux* i*86-*-cygwin*  
i*86-*-mingw32* m68k-*-netbsd m68k-*-openbsd* ns32k-*-netbsd x86_64-*- 
mingw* *-*-darwin*
  # The .text # section in PE/COFF has a fixed set of flags and these
  # cannot be changed.  We skip it for them.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Patch Darwin/testsuite/objcopy] Do not try to run the copy-2/3.d tests for darwin.
  2011-12-30 21:07 [Patch Darwin/testsuite/objcopy] Do not try to run the copy-2/3.d tests for darwin Iain Sandoe
@ 2012-01-02 11:27 ` Tristan Gingold
  2012-01-16 23:31   ` Alan Modra
  0 siblings, 1 reply; 3+ messages in thread
From: Tristan Gingold @ 2012-01-02 11:27 UTC (permalink / raw)
  To: Iain Sandoe; +Cc: binutils Development


On Dec 30, 2011, at 10:07 PM, Iain Sandoe wrote:

> trying to work through the test-suite to find which fails represent stuff we still need to implement (and which are noise).
> 
> AFAICS, these two tests are not applicable to mach-o, certainly as they stand (they would require a different .s file to work).

Ok with me.  Need perhaps a confirmation from a global maintainer.

Tristan.

> 
> OK?
> Iain
> 
> binutils/testsuite:
> 
> 	* binutils-all/copy-2.d: Do not run for Darwin.
> 	* binutils-all/copy-3.d: Likewise.
> 
> binutils/testsuite/binutils-all/copy-2.d |    2 +-
> binutils/testsuite/binutils-all/copy-3.d |    2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/binutils/testsuite/binutils-all/copy-2.d b/binutils/testsuite/binutils-all/copy-2.d
> index 5636ff6..4640709 100644
> --- a/binutils/testsuite/binutils-all/copy-2.d
> +++ b/binutils/testsuite/binutils-all/copy-2.d
> @@ -3,7 +3,7 @@
> #objcopy: --set-section-flags foo=contents,alloc,load,code
> #name: copy with setting section flags 2
> #source: copytest.s
> -#not-target: *-*-*aout *-*-aix* h8300-*-* hppa*-*-hpux* m68k-*-netbsd m68k-*-openbsd* mips-sony-bsd* mips-*-ultrix* mips-*-osf* mips-*-ecoff* mips-*-irix mips-*-irix[2-4] mips-*-riscos* ns32k-*-netbsd
> +#not-target: *-*-*aout *-*-aix* h8300-*-* hppa*-*-hpux* m68k-*-netbsd m68k-*-openbsd* mips-sony-bsd* mips-*-ultrix* mips-*-osf* mips-*-ecoff* mips-*-irix mips-*-irix[2-4] mips-*-riscos* ns32k-*-netbsd *-*-darwin*
> # Note - we use copytest.s and a section named "foo" rather
> # than .text because for some file formats (eg PE) the .text
> # section has a fixed set of flags and these cannot be changed.
> diff --git a/binutils/testsuite/binutils-all/copy-3.d b/binutils/testsuite/binutils-all/copy-3.d
> index 551517c..2d42ce8 100644
> --- a/binutils/testsuite/binutils-all/copy-3.d
> +++ b/binutils/testsuite/binutils-all/copy-3.d
> @@ -3,7 +3,7 @@
> #objcopy: --set-section-flags .text=alloc,data
> #name: copy with setting section flags 3
> #source: bintest.s
> -#not-target: *-*-*aout *-*-*pe *-*-*coff hppa*-*-hpux* i*86-*-cygwin* i*86-*-mingw32* m68k-*-netbsd m68k-*-openbsd* ns32k-*-netbsd x86_64-*-mingw*
> +#not-target: *-*-*aout *-*-*pe *-*-*coff hppa*-*-hpux* i*86-*-cygwin* i*86-*-mingw32* m68k-*-netbsd m68k-*-openbsd* ns32k-*-netbsd x86_64-*-mingw* *-*-darwin*
> # The .text # section in PE/COFF has a fixed set of flags and these
> # cannot be changed.  We skip it for them.
> 
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Patch Darwin/testsuite/objcopy] Do not try to run the copy-2/3.d tests for darwin.
  2012-01-02 11:27 ` Tristan Gingold
@ 2012-01-16 23:31   ` Alan Modra
  0 siblings, 0 replies; 3+ messages in thread
From: Alan Modra @ 2012-01-16 23:31 UTC (permalink / raw)
  To: Tristan Gingold; +Cc: Iain Sandoe, binutils Development

On Mon, Jan 02, 2012 at 12:27:35PM +0100, Tristan Gingold wrote:
> 
> On Dec 30, 2011, at 10:07 PM, Iain Sandoe wrote:
> 
> > trying to work through the test-suite to find which fails represent stuff we still need to implement (and which are noise).
> > 
> > AFAICS, these two tests are not applicable to mach-o, certainly as they stand (they would require a different .s file to work).
> 
> Ok with me.  Need perhaps a confirmation from a global maintainer.

OK.

-- 
Alan Modra
Australia Development Lab, IBM

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-01-16 23:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-12-30 21:07 [Patch Darwin/testsuite/objcopy] Do not try to run the copy-2/3.d tests for darwin Iain Sandoe
2012-01-02 11:27 ` Tristan Gingold
2012-01-16 23:31   ` Alan Modra

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).