From: Alan Modra <amodra@gmail.com>
To: James Murray <jsm@jsm-net.demon.co.uk>
Cc: binutils@sourceware.org
Subject: Re: Duplicate 0x prefix - cr16 - bug. no. 10173
Date: Mon, 16 Jan 2012 23:52:00 -0000 [thread overview]
Message-ID: <20120116235212.GQ3708@bubble.grove.modra.org> (raw)
In-Reply-To: <1324919489.2430.89.camel@jsm2>
On Mon, Dec 26, 2011 at 05:11:29PM +0000, James Murray wrote:
> Regarding:
> http://sourceware.org/bugzilla/show_bug.cgi?id=10173
>
> The fix for the duplicate 0x prefix on numbers during disassembly was:
>
> --- src/opcodes/cr16-dis.c 2008/11/27 11:30:33 1.5
> +++ src/opcodes/cr16-dis.c 2009/06/15 15:24:52 1.6
> @@ -678,7 +678,9 @@
> + /* PR 10173: Avoid printing the 0x prefix twice. */
> + if (info->num_symbols > 0)
> + func (stream, "%s", "0x");
>
>
> I'm wondering if that might be better as
> + if (info->symtab_size > 0)
Applied.
--
Alan Modra
Australia Development Lab, IBM
prev parent reply other threads:[~2012-01-16 23:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-26 17:11 James Murray
2012-01-16 23:52 ` Alan Modra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120116235212.GQ3708@bubble.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=jsm@jsm-net.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).