public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: binutils@sourceware.org
Cc: Kito Cheng <kito@0xlab.org>, Ian Lance Taylor <iant@google.com>,
	Jim Huang <jserv@0xlab.org>
Subject: Re: [PATCH] Prevent broken sysv-style hash table when --hash-style=both
Date: Tue, 17 Jan 2012 20:56:00 -0000	[thread overview]
Message-ID: <201201171556.30697.vapier@gentoo.org> (raw)
In-Reply-To: <CA+yXCZCbS46y4i6gv_mFAJjnVh8QHHr=tD89WwHrRj7TYc4hGg@mail.gmail.com>

[-- Attachment #1: Type: Text/Plain, Size: 538 bytes --]

On Tuesday 17 January 2012 15:35:10 Kito Cheng wrote:
> Index: gold/layout.cc
> ===================================================================
> RCS file: /cvs/src/src/gold/layout.cc,v
> retrieving revision 1.222
> diff -r1.222 layout.cc
> 3835c3835
> <   if (strcmp(parameters->options().hash_style(), "sysv") == 0
> ---
> >   if (strcmp(parameters->options().hash_style(), "gnu") == 0

please submit patches in the unified diff format.  this is easy to do by default 
with cvs:
	$ echo 'diff -uNp' >> ~/.cvsrc
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2012-01-17 20:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-17 20:35 Kito Cheng
2012-01-17 20:56 ` Mike Frysinger [this message]
2012-01-17 21:10   ` Kito Cheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201201171556.30697.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=binutils@sourceware.org \
    --cc=iant@google.com \
    --cc=jserv@0xlab.org \
    --cc=kito@0xlab.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).