From: Alan Modra <amodra@gmail.com>
To: Mike Stump <mikestump@comcast.net>
Cc: binutils@sourceware.org
Subject: Re: 64-bit support for srec
Date: Thu, 02 Feb 2012 03:23:00 -0000 [thread overview]
Message-ID: <20120202032239.GA5266@bubble.grove.modra.org> (raw)
In-Reply-To: <3A288B3F-CBD9-4700-9C30-BCFE721F4B72@comcast.net>
On Wed, Feb 01, 2012 at 03:55:11PM -0800, Mike Stump wrote:
> --- 897,907 ----
> else if ((section->lma + offset + bytes_to_do - 1) <= 0xffffff
> && tdata->type <= 2)
> tdata->type = 2;
> ! else if ((section->lma + offset + bytes_to_do - 1) <= 0xffffffff
> ! && tdata->type <= 2)
Probably ought to be <= 3 here. Presumably the idea of the existing
code is that once you've used S3 records, don't drop back to S2.
> + case 4:
> + TOHEX (dst, (address >> 56), check_sum);
> + dst += 2;
What if "address" is only a 32-bit type? I think you need to
conditionalize all your new code on BFD64. And it would be sad if we
can't read back our own output..
--
Alan Modra
Australia Development Lab, IBM
next prev parent reply other threads:[~2012-02-02 3:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 23:55 Mike Stump
2012-02-02 3:23 ` Alan Modra [this message]
2012-02-03 0:37 ` Mike Stump
2012-02-03 1:35 ` Alan Modra
2012-02-03 1:40 ` Mike Stump
2012-02-02 0:35 Joel Sherrill
2012-02-02 1:57 ` Mike Stump
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120202032239.GA5266@bubble.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=mikestump@comcast.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).