From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27194 invoked by alias); 2 Feb 2012 03:23:00 -0000 Received: (qmail 27185 invoked by uid 22791); 2 Feb 2012 03:22:59 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,TW_XF X-Spam-Check-By: sourceware.org Received: from mail-pw0-f41.google.com (HELO mail-pw0-f41.google.com) (209.85.160.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 02 Feb 2012 03:22:47 +0000 Received: by mail-pw0-f41.google.com with SMTP id a12so1857477pba.0 for ; Wed, 01 Feb 2012 19:22:47 -0800 (PST) Received: by 10.68.208.228 with SMTP id mh4mr3816740pbc.13.1328152967090; Wed, 01 Feb 2012 19:22:47 -0800 (PST) Received: from bubble.grove.modra.org ([115.187.252.19]) by mx.google.com with ESMTPS id t10sm2669837pbb.18.2012.02.01.19.22.43 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 01 Feb 2012 19:22:45 -0800 (PST) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 9B129170C2EA; Thu, 2 Feb 2012 13:52:39 +1030 (CST) Date: Thu, 02 Feb 2012 03:23:00 -0000 From: Alan Modra To: Mike Stump Cc: binutils@sourceware.org Subject: Re: 64-bit support for srec Message-ID: <20120202032239.GA5266@bubble.grove.modra.org> Mail-Followup-To: Mike Stump , binutils@sourceware.org References: <3A288B3F-CBD9-4700-9C30-BCFE721F4B72@comcast.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3A288B3F-CBD9-4700-9C30-BCFE721F4B72@comcast.net> User-Agent: Mutt/1.5.20 (2009-06-14) X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00006.txt.bz2 On Wed, Feb 01, 2012 at 03:55:11PM -0800, Mike Stump wrote: > --- 897,907 ---- > else if ((section->lma + offset + bytes_to_do - 1) <= 0xffffff > && tdata->type <= 2) > tdata->type = 2; > ! else if ((section->lma + offset + bytes_to_do - 1) <= 0xffffffff > ! && tdata->type <= 2) Probably ought to be <= 3 here. Presumably the idea of the existing code is that once you've used S3 records, don't drop back to S2. > + case 4: > + TOHEX (dst, (address >> 56), check_sum); > + dst += 2; What if "address" is only a 32-bit type? I think you need to conditionalize all your new code on BFD64. And it would be sad if we can't read back our own output.. -- Alan Modra Australia Development Lab, IBM