From: Jakub Jelinek <jakub@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: DJ Delorie <dj@redhat.com>, Doug Evans <dje@google.com>,
gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org,
binutils@sourceware.org
Subject: Re: RFA: consolidate DWARF strings into libiberty
Date: Thu, 26 Apr 2012 15:28:00 -0000 [thread overview]
Message-ID: <20120426144248.GA16117@tyan-ft48-01.lab.bos.redhat.com> (raw)
In-Reply-To: <87ipgqfqwx.fsf@fleche.redhat.com>
On Mon, Apr 23, 2012 at 08:45:18AM -0600, Tom Tromey wrote:
> Tom> Here is a new patch for gcc.
> Tom> I still haven't updated the src side, but there's little to do there
> Tom> that isn't already done in this patch.
>
> Tom> Ok?
>
> Tom> Ping.
>
> Tom> Ping.
>
> This is the third ping.
>
> Please review the patch.
>
> There are two choices:
>
> 1. Approve the original patch, adding a file to libiberty.
> Given how much code in libiberty is already unrelated to portability,
> I would say this is the simplest route.
> From a quick glance -- concat.c, the demangler, crc32.c,
> dyn-string.c, fdmatch.c, fibheap.c, hashtab.c, hex.c, md5.c,
> objalloc.c, obstack.c, sha1.c, simple-object*.
Yeah, that would be my preference. libiberty is already a kitchen sink,
has been handled that way for many years, and creating a new kitchen sink
library is both overkill and will not make it a kitchen sink if only
this dwarf strings stuff is added to that and all the other kitchen sink
stuff stays in libiberty.
Jakub
next prev parent reply other threads:[~2012-04-26 14:43 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-15 18:00 Tom Tromey
2012-03-15 18:34 ` DJ Delorie
[not found] ` <201203151833.q2FIXeOs003077__40387.7084645957$1331836457$gmane$org@greed.delorie.com>
2012-03-15 18:42 ` Tom Tromey
2012-03-15 18:49 ` DJ Delorie
2012-03-15 18:54 ` Pedro Alves
2012-03-15 19:01 ` Jakub Jelinek
[not found] ` <201203151848.q2FImnAq004284__18018.6977530413$1331837385$gmane$org@greed.delorie.com>
2012-03-15 19:02 ` Tom Tromey
2012-03-19 16:10 ` Doug Evans
2012-03-19 16:14 ` DJ Delorie
[not found] ` <201203191613.q2JGCx5m011858__41727.2307830446$1332173667$gmane$org@greed.delorie.com>
2012-03-19 17:25 ` Tom Tromey
[not found] ` <87obrsmrma.fsf__45145.0892644518$1332177916$gmane$org@fleche.redhat.com>
2012-03-30 18:57 ` Tom Tromey
2012-04-05 19:29 ` Tom Tromey
2012-04-13 23:08 ` Tom Tromey
[not found] ` <87d37bwgq1.fsf__11149.6676145636$1334346880$gmane$org@fleche.redhat.com>
2012-04-23 14:50 ` Tom Tromey
2012-04-26 15:28 ` Jakub Jelinek [this message]
2012-04-26 20:39 ` DJ Delorie
2012-04-27 0:39 ` Jakub Jelinek
[not found] ` <20120426203911.GC16117__46696.8788685792$1335472814$gmane$org@tyan-ft48-01.lab.bos.redhat.com>
2012-04-27 14:25 ` Tom Tromey
2012-04-27 16:02 ` H.J. Lu
2012-04-27 16:09 ` H.J. Lu
2012-04-27 16:59 ` Tom Tromey
2012-04-27 17:22 ` Tom Tromey
2012-03-19 22:49 ` Doug Evans
[not found] ` <20120315190113.GB16117__13472.8689365604$1331838115$gmane$org@tyan-ft48-01.lab.bos.redhat.com>
2012-03-15 19:04 ` Tom Tromey
2012-03-15 19:30 ` Tom Tromey
2012-03-16 21:26 ` Richard Henderson
2012-04-07 14:02 ` nick clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120426144248.GA16117@tyan-ft48-01.lab.bos.redhat.com \
--to=jakub@redhat.com \
--cc=binutils@sourceware.org \
--cc=dj@redhat.com \
--cc=dje@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).