From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 880 invoked by alias); 10 Aug 2012 13:19:01 -0000 Received: (qmail 852 invoked by uid 22791); 10 Aug 2012 13:18:47 -0000 X-SWARE-Spam-Status: No, hits=-0.7 required=5.0 tests=AWL,BAYES_99,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KAM_STOCKGEN,KHOP_RCVD_TRUST,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,TW_LR,TW_LW,TW_WZ,TW_XF,TW_YM,T_FILL_THIS_FORM_SHORT,URIBL_RED X-Spam-Check-By: sourceware.org Received: from mail-yw0-f41.google.com (HELO mail-yw0-f41.google.com) (209.85.213.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 10 Aug 2012 13:18:25 +0000 Received: by yhr47 with SMTP id 47so1695601yhr.0 for ; Fri, 10 Aug 2012 06:18:25 -0700 (PDT) Received: by 10.66.73.133 with SMTP id l5mr6114333pav.74.1344604704393; Fri, 10 Aug 2012 06:18:24 -0700 (PDT) Received: from bubble.grove.modra.org ([115.187.252.19]) by mx.google.com with ESMTPS id pe8sm3331114pbc.76.2012.08.10.06.18.20 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 10 Aug 2012 06:18:23 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 382CEEA3195; Fri, 10 Aug 2012 22:48:16 +0930 (CST) Date: Fri, 10 Aug 2012 16:40:00 -0000 From: Alan Modra To: Ian Lance Taylor Cc: binutils@sourceware.org Subject: Re: powerpc gold work in progress Message-ID: <20120810131816.GA5588@bubble.grove.modra.org> Mail-Followup-To: Ian Lance Taylor , binutils@sourceware.org References: <20120809132716.GB30412@bubble.grove.modra.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00189.txt.bz2 Thanks for the review Ian! On Thu, Aug 09, 2012 at 05:55:45PM -0700, Ian Lance Taylor wrote: > I guess I don't understand how this can do what you want Uh, a little bit of self review would have led me to the same conclusion. See comments in revised version of find_shdr. The idea was to find a section header without needing to call strcmp, making use of the existing memmem return as a sh_name value. So an optimization of existing code. > I'm not sure it's really worth worrying about the possibility of > multiple sections named .eh_frame. The chances of us handling that > correctly are low. In the current code the reason that > check_eh_frame_flags is called first is an optimization: it saves the > call to strcmp. In your code, where you find the section name first, > I think it would be fine to skip the call to check_eh_frame_flags, and > probably just remove that function entirely. I hear what you're saying, which means I don't need a find_shdr that continues on from the last shdr found, as I thought I did. However, it's not that much more work so I left it in. I'm not trying to be difficult! If you really want check_eh_frame_flags removed I'm happy to do that and remove HDR as a parameter of find_shdr. > > - private: > > enum > > { > > GSYM_CODE = 0x7fffffff, > > Please don't just drop the private here. It's OK to make GSYM_CODE, > etc., public or protected, but the data members should still be > private. OK, I've rehashed this part of the patch. > > +protected: > > + // Post constructor setup. > > + void > > + do_setup() > > + { > > + // Call parent's setup method. > > + Sized_relobj_file::do_setup(); > > + > > + } > > Why override the parent method if all you are going to do is call it? Removed. This was just a leftover from a previous patch. I think I've covered your other comments in this revised patch. > Is it really true that the only way to find the .got2 section in an > input file is by name? Yes, unfortunately. 32-bit PIC plt call stubs use the got pointer reg to access the plt. With -fpic code, the got pointer reg is set to _GLOBAL_OFFSET_TABLE_, but -fPIC code has it somewhere in .got2, the offset given by the addend on a PLTREL24 reloc. So the linker needs to know the .got2 section and the offset in order to address plt entries. BTW, support for this is missing in gold/powerpc.cc, but see bfd/elf32-ppc.c. * object.h (Sized_relobj_file::find_shdr): New function. (Sized_relobj_file::find_special_sections): New function. * object.cc (Sized_relobj_file::find_shdr): New function. (Sized_relobj_file::find_eh_frame): Use find_shdr. (Sized_relobj_file::find_special_sections): New function, split out.. (Sized_relobj_file::do_read_symbols): ..from here. * output.h (Output_data_got::replace_constant): New function. (Output_data_got::num_entries): New function. (Output_data_got::last_got_offset,set_got_size): Use num_entries. (Output_data_got::got_offset): Protected rather than private. (Output_data_got::replace_got_entry): New function. * output.cc (Output_data_got::replace_got_entry): New function. * powerpc.cc (class Powerpc_relobj): New. (class Powerpc_relocate_functions): Delete all psymval variants or convert to value,addend type. Delete pcrela, pcrela_unaligned. Implement _ha functions using corresponding _hi function. (Powerpc_relobj::find_special_sections): New function. (Target_powerpc::do_make_elf_object): New function. (class Output_data_got_powerpc): New. (class Output_data_glink): New. (class Powerpc_scan_relocatable_reloc): New. Many more changes throughout file. Index: gold/object.h =================================================================== RCS file: /cvs/src/src/gold/object.h,v retrieving revision 1.117 diff -u -p -r1.117 object.h --- gold/object.h 26 Apr 2012 00:07:17 -0000 1.117 +++ gold/object.h 10 Aug 2012 13:13:53 -0000 @@ -349,7 +349,7 @@ class Object this->input_file_->file().remove_object(); } - // Return the name of the object as we would report it to the tuser. + // Return the name of the object as we would report it to the user. const std::string& name() const { return this->name_; } @@ -2116,6 +2116,15 @@ class Sized_relobj_file : public Sized_r Address map_to_kept_section(unsigned int shndx, bool* found) const; + // Find the section header with the given NAME. If HDR is non-NULL + // then it is a section header returned from a previous call to this + // function and the next section header with the same name will be + // returned. + const unsigned char* + find_shdr(const unsigned char* pshdrs, const char* name, + const char* names, section_size_type names_size, + const unsigned char* hdr) const; + // Compute final local symbol value. R_SYM is the local symbol index. // LV_IN points to a local symbol value containing the input value. // LV_OUT points to a local symbol value storing the final output value, @@ -2347,6 +2356,11 @@ class Sized_relobj_file : public Sized_r typedef std::vector Views; + // Stash away info for a number of special sections. + // Return true if any of the sections found require local symbols to be read. + virtual bool + do_find_special_sections(Read_symbols_data* sd); + // This may be overriden by a child class. virtual void do_relocate_sections(const Symbol_table* symtab, const Layout* layout, Index: gold/object.cc =================================================================== RCS file: /cvs/src/src/gold/object.cc,v retrieving revision 1.155 diff -u -p -r1.155 object.cc --- gold/object.cc 2 May 2012 21:37:23 -0000 1.155 +++ gold/object.cc 10 Aug 2012 13:13:53 -0000 @@ -510,6 +510,64 @@ Sized_relobj_file::che && (shdr->get_sh_flags() & elfcpp::SHF_ALLOC) != 0); } +// Find the section header with the given name. + +template +const unsigned char* +Sized_relobj_file::find_shdr( + const unsigned char* pshdrs, + const char* name, + const char* names, + section_size_type names_size, + const unsigned char* hdr) const +{ + const unsigned int shnum = this->shnum(); + const unsigned char* hdr_end = pshdrs + This::shdr_size * shnum; + size_t sh_name = 0; + + while (1) + { + if (hdr) + { + // We found HDR last time we were called, continue looking. + typename This::Shdr shdr(hdr); + sh_name = shdr.get_sh_name(); + } + else + { + // Look for the next occurrence of NAME in NAMES. + // The fact that .shstrtab produced by current GNU tools is + // string merged means we shouldn't have both .not.foo and + // .foo in .shstrtab, and multiple .foo sections should all + // have the same sh_name. However, this is not guaranteed + // by the ELF spec and not all ELF object file producers may + // be so clever. + size_t len = strlen(name) + 1; + const char *p = sh_name ? names + sh_name + len : names; + p = reinterpret_cast(memmem(p, names_size - (p - names), + name, len)); + if (p == NULL) + return NULL; + sh_name = p - names; + hdr = pshdrs; + if (sh_name == 0) + return hdr; + } + + hdr += This::shdr_size; + while (hdr < hdr_end) + { + typename This::Shdr shdr(hdr); + if (shdr.get_sh_name() == sh_name) + return hdr; + hdr += This::shdr_size; + } + hdr = NULL; + if (sh_name == 0) + return hdr; + } +} + // Return whether there is a GNU .eh_frame section, given the section // headers and the section names. @@ -520,26 +578,18 @@ Sized_relobj_file::fin const char* names, section_size_type names_size) const { - const unsigned int shnum = this->shnum(); - const unsigned char* p = pshdrs + This::shdr_size; - for (unsigned int i = 1; i < shnum; ++i, p += This::shdr_size) + const unsigned char* s = NULL; + + while (1) { - typename This::Shdr shdr(p); - if (this->check_eh_frame_flags(&shdr)) - { - if (shdr.get_sh_name() >= names_size) - { - this->error(_("bad section name offset for section %u: %lu"), - i, static_cast(shdr.get_sh_name())); - continue; - } + s = this->find_shdr(pshdrs, ".eh_frame", names, names_size, s); + if (s == NULL) + return false; - const char* name = names + shdr.get_sh_name(); - if (strcmp(name, ".eh_frame") == 0) - return true; - } + typename This::Shdr shdr(s); + if (this->check_eh_frame_flags(&shdr)) + return true; } - return false; } // Return TRUE if this is a section whose contents will be needed in the @@ -651,39 +701,46 @@ build_compressed_section_map( return uncompressed_map; } +// Stash away info for a number of special sections. +// Return true if any of the sections found require local symbols to be read. + +template +bool +Sized_relobj_file::do_find_special_sections( + Read_symbols_data* sd) +{ + const unsigned char* const pshdrs = sd->section_headers->data(); + const unsigned char* namesu = sd->section_names->data(); + const char* names = reinterpret_cast(namesu); + + if (this->find_eh_frame(pshdrs, names, sd->section_names_size)) + this->has_eh_frame_ = true; + + if (memmem(names, sd->section_names_size, ".zdebug_", 8) != NULL) + this->compressed_sections_ + = build_compressed_section_map(pshdrs, this->shnum(), names, + sd->section_names_size, this); + return (this->has_eh_frame_ + || (!parameters->options().relocatable() + && parameters->options().gdb_index() + && (memmem(names, sd->section_names_size, "debug_info", 12) == 0 + || memmem(names, sd->section_names_size, "debug_types", + 13) == 0))); +} + // Read the sections and symbols from an object file. template void Sized_relobj_file::do_read_symbols(Read_symbols_data* sd) { - bool need_local_symbols = false; - this->read_section_data(&this->elf_file_, sd); const unsigned char* const pshdrs = sd->section_headers->data(); this->find_symtab(pshdrs); - const unsigned char* namesu = sd->section_names->data(); - const char* names = reinterpret_cast(namesu); - if (memmem(names, sd->section_names_size, ".eh_frame", 10) != NULL) - { - if (this->find_eh_frame(pshdrs, names, sd->section_names_size)) - this->has_eh_frame_ = true; - } - if (memmem(names, sd->section_names_size, ".zdebug_", 8) != NULL) - this->compressed_sections_ = - build_compressed_section_map(pshdrs, this->shnum(), names, - sd->section_names_size, this); - - if (this->has_eh_frame_ - || (!parameters->options().relocatable() - && parameters->options().gdb_index() - && (memmem(names, sd->section_names_size, "debug_info", 12) == 0 - || memmem(names, sd->section_names_size, "debug_types", - 13) == 0))) - need_local_symbols = true; + bool need_local_symbols = this->do_find_special_sections(sd); sd->symbols = NULL; sd->symbols_size = 0; Index: gold/output.h =================================================================== RCS file: /cvs/src/src/gold/output.h,v retrieving revision 1.135 diff -u -p -r1.135 output.h --- gold/output.h 10 Jul 2012 14:54:29 -0000 1.135 +++ gold/output.h 10 Aug 2012 13:13:55 -0000 @@ -2257,6 +2257,13 @@ class Output_data_got : public Output_da return got_offset; } + // Replace GOT entry I with a new constant. + void + replace_constant(unsigned int i, Valtype constant) + { + this->replace_got_entry(i, Got_entry(constant)); + } + // Reserve a slot in the GOT for a local symbol. void reserve_local(unsigned int i, Relobj* object, unsigned int sym_index, @@ -2281,6 +2288,16 @@ class Output_data_got : public Output_da do_reserve_slot(unsigned int i) { this->free_list_.remove(i * got_size / 8, (i + 1) * got_size / 8); } + // Return the number of words in the GOT. + unsigned int + num_entries () const + { return this->entries_.size(); } + + // Return the offset into the GOT of GOT entry I. + unsigned int + got_offset(unsigned int i) const + { return i * (got_size / 8); } + private: // This POD class holds a single GOT entry. class Got_entry @@ -2352,20 +2369,19 @@ class Output_data_got : public Output_da unsigned int add_got_entry_pair(Got_entry got_entry_1, Got_entry got_entry_2); - // Return the offset into the GOT of GOT entry I. - unsigned int - got_offset(unsigned int i) const - { return i * (got_size / 8); } + // Replace GOT entry I with a new value. + void + replace_got_entry(unsigned int i, Got_entry got_entry); // Return the offset into the GOT of the last entry added. unsigned int last_got_offset() const - { return this->got_offset(this->entries_.size() - 1); } + { return this->got_offset(this->num_entries() - 1); } // Set the size of the section. void set_got_size() - { this->set_current_data_size(this->got_offset(this->entries_.size())); } + { this->set_current_data_size(this->got_offset(this->num_entries())); } // The list of GOT entries. Got_entries entries_; Index: gold/output.cc =================================================================== RCS file: /cvs/src/src/gold/output.cc,v retrieving revision 1.167 diff -u -p -r1.167 output.cc --- gold/output.cc 6 Jun 2012 22:12:47 -0000 1.167 +++ gold/output.cc 10 Aug 2012 13:13:54 -0000 @@ -1701,6 +1701,18 @@ Output_data_got::add_g } } +// Replace GOT entry I with a new value. + +template +void +Output_data_got::replace_got_entry( + unsigned int i, + Got_entry got_entry) +{ + gold_assert(i < this->entries_.size()); + this->entries_[i] = got_entry; +} + // Output_data_dynamic::Dynamic_entry methods. // Write out the entry. Index: gold/powerpc.cc =================================================================== RCS file: /cvs/src/src/gold/powerpc.cc,v retrieving revision 1.44 diff -u -p -r1.44 powerpc.cc --- gold/powerpc.cc 11 Jul 2012 14:18:40 -0000 1.44 +++ gold/powerpc.cc 10 Aug 2012 13:13:55 -0000 @@ -48,6 +48,50 @@ template class Output_data_plt_powerpc; template +class Output_data_got_powerpc; + +template +class Output_data_glink; + +template +class Powerpc_relobj : public Sized_relobj_file +{ +public: + Powerpc_relobj(const std::string& name, Input_file* input_file, off_t offset, + const typename elfcpp::Ehdr& ehdr) + : Sized_relobj_file(name, input_file, offset, ehdr), + got2_section_(0) + { } + + ~Powerpc_relobj() + { } + + unsigned int + got2_shndx() const + { + if (size == 32) + return this->got2_section_; + else + return 0; + } + + void + set_got2_shndx(unsigned int shndx) + { + if (size == 32) + this->got2_section_ = shndx; + else + gold_unreachable(); + } + + bool + do_find_special_sections(Read_symbols_data* sd); + +private: + unsigned int got2_section_; +}; + +template class Target_powerpc : public Sized_target { public: @@ -55,8 +99,7 @@ class Target_powerpc : public Sized_targ Target_powerpc() : Sized_target(&powerpc_info), - got_(NULL), got2_(NULL), toc_(NULL), - plt_(NULL), rela_dyn_(NULL), + got_(NULL), plt_(NULL), glink_(NULL), rela_dyn_(NULL), copy_relocs_(elfcpp::R_POWERPC_COPY), dynbss_(NULL), got_mod_index_offset_(-1U) { @@ -136,9 +179,9 @@ class Target_powerpc : public Sized_targ Output_section* output_section, off_t offset_in_output_section, const Relocatable_relocs*, - unsigned char* view, - typename elfcpp::Elf_types::Elf_Addr view_address, - section_size_type view_size, + unsigned char*, + typename elfcpp::Elf_types::Elf_Addr, + section_size_type, unsigned char* reloc_view, section_size_type reloc_view_size); @@ -146,7 +189,7 @@ class Target_powerpc : public Sized_targ bool do_is_defined_by_abi(const Symbol* sym) const { - return strcmp(sym->name(), "___tls_get_addr") == 0; + return strcmp(sym->name(), "__tls_get_addr") == 0; } // Return the size of the GOT section. @@ -157,6 +200,35 @@ class Target_powerpc : public Sized_targ return this->got_->data_size(); } + // Get the PLT section. + const Output_data_plt_powerpc* + plt_section() const + { + gold_assert(this->plt_ != NULL); + return this->plt_; + } + + // Get the .glink section. + const Output_data_glink* + glink_section() const + { + gold_assert(this->glink_ != NULL); + return this->glink_; + } + + // Get the GOT section. + const Output_data_got_powerpc* + got_section() const + { + gold_assert(this->got_ != NULL); + return this->got_; + } + + protected: + Object* + do_make_elf_object(const std::string&, Input_file*, off_t, + const elfcpp::Ehdr&); + // Return the number of entries in the GOT. unsigned int got_entry_count() const @@ -284,45 +356,41 @@ class Target_powerpc : public Sized_targ { public: unsigned int - get_size_for_reloc(unsigned int, Relobj*); + get_size_for_reloc(unsigned int, Relobj*) + { + gold_unreachable (); + return 0; + } }; + // Adjust TLS relocation type based on the options and whether this + // is a local symbol. + static tls::Tls_optimization + optimize_tls_reloc(bool is_final, int r_type); + // Get the GOT section, creating it if necessary. - Output_data_got* + Output_data_got_powerpc* got_section(Symbol_table*, Layout*); - Output_data_space* - got2_section() const - { - gold_assert(this->got2_ != NULL); - return this->got2_; - } + // Create glink. + void + make_glink_section(Layout*); - // Get the TOC section. - Output_data_space* - toc_section() const - { - gold_assert(this->toc_ != NULL); - return this->toc_; - } + // Create the PLT section. + void + make_plt_section(Layout*); // Create a PLT entry for a global symbol. void - make_plt_entry(Symbol_table*, Layout*, Symbol*); + make_plt_entry(Layout*, Symbol*, + const elfcpp::Rela&, + const Sized_relobj* object); // Create a GOT entry for the TLS module index. unsigned int got_mod_index_entry(Symbol_table* symtab, Layout* layout, Sized_relobj_file* object); - // Get the PLT section. - const Output_data_plt_powerpc* - plt_section() const - { - gold_assert(this->plt_ != NULL); - return this->plt_; - } - // Get the dynamic reloc section, creating it if necessary. Reloc_section* rela_dyn_section(Layout*); @@ -355,15 +423,13 @@ class Target_powerpc : public Sized_targ GOT_TYPE_TLS_PAIR = 2, // GOT entry for TLS module/offset pair }; - // The GOT section. - Output_data_got* got_; - // The GOT2 section. - Output_data_space* got2_; - // The TOC section. - Output_data_space* toc_; - // The PLT section. + // The GOT output section. + Output_data_got_powerpc* got_; + // The PLT output section. Output_data_plt_powerpc* plt_; - // The dynamic reloc section. + // The .glink output section. + Output_data_glink* glink_; + // The dynamic reloc output section. Reloc_section* rela_dyn_; // Relocs saved to avoid a COPY reloc. Copy_relocs copy_relocs_; @@ -481,7 +547,7 @@ template class Powerpc_relocate_functions { private: - // Do a simple relocation with the addend in the relocation. + // Do a simple RELA relocation template static inline void rela(unsigned char* view, @@ -493,7 +559,7 @@ private: typedef typename elfcpp::Swap::Valtype Valtype; Valtype* wv = reinterpret_cast(view); Valtype val = elfcpp::Swap::readval(wv); - Valtype reloc = ((value + addend) >> right_shift); + Valtype reloc = (value + addend) >> right_shift; val &= ~dst_mask; reloc &= dst_mask; @@ -501,87 +567,25 @@ private: elfcpp::Swap::writeval(wv, val | reloc); } - // Do a simple relocation using a symbol value with the addend in - // the relocation. + // Do a simple RELA relocation, unaligned. template static inline void - rela(unsigned char* view, - unsigned int right_shift, - elfcpp::Elf_Xword dst_mask, - const Sized_relobj_file* object, - const Symbol_value* psymval, - typename elfcpp::Swap::Valtype addend) - { - typedef typename elfcpp::Swap::Valtype Valtype; - Valtype* wv = reinterpret_cast(view); - Valtype val = elfcpp::Swap::readval(wv); - Valtype reloc = (psymval->value(object, addend) >> right_shift); - - val &= ~dst_mask; - reloc &= dst_mask; - - elfcpp::Swap::writeval(wv, val | reloc); - } - - // Do a simple relocation using a symbol value with the addend in - // the relocation, unaligned. - template - static inline void - rela_ua(unsigned char* view, unsigned int right_shift, + rela_ua(unsigned char* view, + unsigned int right_shift, elfcpp::Elf_Xword dst_mask, - const Sized_relobj_file* object, - const Symbol_value* psymval, + typename elfcpp::Swap::Valtype value, typename elfcpp::Swap::Valtype addend) { typedef typename elfcpp::Swap_unaligned::Valtype Valtype; - unsigned char* wv = view; - Valtype val = elfcpp::Swap_unaligned::readval(wv); - Valtype reloc = (psymval->value(object, addend) >> right_shift); - - val &= ~dst_mask; - reloc &= dst_mask; - - elfcpp::Swap_unaligned::writeval(wv, val | reloc); - } - - // Do a simple PC relative relocation with a Symbol_value with the - // addend in the relocation. - template - static inline void - pcrela(unsigned char* view, unsigned int right_shift, - elfcpp::Elf_Xword dst_mask, - const Sized_relobj_file* object, - const Symbol_value* psymval, - typename elfcpp::Swap::Valtype addend, - typename elfcpp::Elf_types::Elf_Addr address) - { - typedef typename elfcpp::Swap::Valtype Valtype; + big_endian>::Valtype Valtype; Valtype* wv = reinterpret_cast(view); Valtype val = elfcpp::Swap::readval(wv); - Valtype reloc = ((psymval->value(object, addend) - address) - >> right_shift); + Valtype reloc = (value + addend) >> right_shift; val &= ~dst_mask; reloc &= dst_mask; - elfcpp::Swap::writeval(wv, val | reloc); - } - - template - static inline void - pcrela_unaligned(unsigned char* view, - const Sized_relobj_file* object, - const Symbol_value* psymval, - typename elfcpp::Swap::Valtype addend, - typename elfcpp::Elf_types::Elf_Addr address) - { - typedef typename elfcpp::Swap_unaligned::Valtype Valtype; - unsigned char* wv = view; - Valtype reloc = (psymval->value(object, addend) - address); - - elfcpp::Swap_unaligned::writeval(wv, reloc); + elfcpp::Swap_unaligned::writeval(wv, val | reloc); } typedef Powerpc_relocate_functions This; @@ -590,34 +594,29 @@ public: // R_POWERPC_REL32: (Symbol + Addend - Address) static inline void rel32(unsigned char* view, - const Sized_relobj_file* object, - const Symbol_value* psymval, + typename elfcpp::Elf_types::Elf_Addr value, typename elfcpp::Elf_types::Elf_Addr addend, typename elfcpp::Elf_types::Elf_Addr address) - { This_reloc::pcrela32(view, object, psymval, addend, address); } + { This_reloc::pcrela32(view, value, addend, address); } // R_POWERPC_REL24: (Symbol + Addend - Address) & 0x3fffffc static inline void rel24(unsigned char* view, - const Sized_relobj_file* object, - const Symbol_value* psymval, + typename elfcpp::Elf_types::Elf_Addr value, typename elfcpp::Elf_types::Elf_Addr addend, typename elfcpp::Elf_types::Elf_Addr address) { - This::template pcrela<32>(view, 0, 0x03fffffc, object, - psymval, addend, address); + This::template rela<32>(view, 0, 0x03fffffc, value - address, addend); } // R_POWERPC_REL14: (Symbol + Addend - Address) & 0xfffc static inline void rel14(unsigned char* view, - const Sized_relobj_file* object, - const Symbol_value* psymval, + typename elfcpp::Elf_types::Elf_Addr value, typename elfcpp::Elf_types::Elf_Addr addend, typename elfcpp::Elf_types::Elf_Addr address) { - This::template pcrela<32>(view, 0, 0x0000fffc, object, - psymval, addend, address); + This::template rela<32>(view, 0, 0xfffc, value - address, addend); } // R_POWERPC_ADDR16: (Symbol + Addend) & 0xffff @@ -627,13 +626,6 @@ public: typename elfcpp::Elf_types::Elf_Addr addend) { This_reloc::rela16(view, value, addend); } - static inline void - addr16(unsigned char* view, - const Sized_relobj_file* object, - const Symbol_value* psymval, - typename elfcpp::Elf_types::Elf_Addr addend) - { This_reloc::rela16(view, object, psymval, addend); } - // R_POWERPC_ADDR16_DS: (Symbol + Addend) & 0xfffc static inline void addr16_ds(unsigned char* view, @@ -650,13 +642,6 @@ public: typename elfcpp::Elf_types::Elf_Addr addend) { This_reloc::rela16(view, value, addend); } - static inline void - addr16_lo(unsigned char* view, - const Sized_relobj_file* object, - const Symbol_value* psymval, - typename elfcpp::Elf_types::Elf_Addr addend) - { This_reloc::rela16(view, object, psymval, addend); } - // R_POWERPC_ADDR16_HI: ((Symbol + Addend) >> 16) & 0xffff static inline void addr16_hi(unsigned char* view, @@ -666,15 +651,6 @@ public: This::template rela<16>(view, 16, 0xffff, value, addend); } - static inline void - addr16_hi(unsigned char* view, - const Sized_relobj_file* object, - const Symbol_value* psymval, - typename elfcpp::Elf_types::Elf_Addr addend) - { - This::template rela<16>(view, 16, 0xffff, object, psymval, addend); - } - // R_POWERPC_ADDR16_HA: Same as R_POWERPC_ADDR16_HI except that if the // final value of the low 16 bits of the // relocation is negative, add one. @@ -683,62 +659,33 @@ public: typename elfcpp::Elf_types::Elf_Addr value, typename elfcpp::Elf_types::Elf_Addr addend) { - typename elfcpp::Elf_types::Elf_Addr reloc; - - reloc = value + addend; - - if (reloc & 0x8000) - reloc += 0x10000; - reloc >>= 16; - - elfcpp::Swap<16, big_endian>::writeval(view, reloc); - } - - static inline void - addr16_ha(unsigned char* view, - const Sized_relobj_file* object, - const Symbol_value* psymval, - typename elfcpp::Elf_types::Elf_Addr addend) - { - typename elfcpp::Elf_types::Elf_Addr reloc; - - reloc = psymval->value(object, addend); - - if (reloc & 0x8000) - reloc += 0x10000; - reloc >>= 16; - - elfcpp::Swap<16, big_endian>::writeval(view, reloc); + This::addr16_hi (view, value + 0x8000, addend); } // R_PPC_REL16: (Symbol + Addend - Address) & 0xffff static inline void rel16(unsigned char* view, - const Sized_relobj_file* object, - const Symbol_value* psymval, + typename elfcpp::Elf_types::Elf_Addr value, typename elfcpp::Elf_types::Elf_Addr addend, typename elfcpp::Elf_types::Elf_Addr address) - { This_reloc::pcrela16(view, object, psymval, addend, address); } + { This_reloc::pcrela16(view, value, addend, address); } // R_PPC_REL16_LO: (Symbol + Addend - Address) & 0xffff static inline void rel16_lo(unsigned char* view, - const Sized_relobj_file* object, - const Symbol_value* psymval, + typename elfcpp::Elf_types::Elf_Addr value, typename elfcpp::Elf_types::Elf_Addr addend, typename elfcpp::Elf_types::Elf_Addr address) - { This_reloc::pcrela16(view, object, psymval, addend, address); } + { This_reloc::pcrela16(view, value, addend, address); } // R_PPC_REL16_HI: ((Symbol + Addend - Address) >> 16) & 0xffff static inline void rel16_hi(unsigned char* view, - const Sized_relobj_file* object, - const Symbol_value* psymval, + typename elfcpp::Elf_types::Elf_Addr value, typename elfcpp::Elf_types::Elf_Addr addend, typename elfcpp::Elf_types::Elf_Addr address) - { - This::template pcrela<16>(view, 16, 0xffff, object, - psymval, addend, address); + { + This::template rela<16>(view, 16, 0xffff, value - address, addend); } // R_PPC_REL16_HA: Same as R_PPC_REL16_HI except that if the @@ -746,26 +693,183 @@ public: // relocation is negative, add one. static inline void rel16_ha(unsigned char* view, - const Sized_relobj_file* object, - const Symbol_value* psymval, + typename elfcpp::Elf_types::Elf_Addr value, typename elfcpp::Elf_types::Elf_Addr addend, typename elfcpp::Elf_types::Elf_Addr address) + { + This::rel16_hi(view, value + 0x8000, addend, address); + } +}; + +// Stash away the index of .got2 in a relocatable object, if such +// a section exists. + +template +bool +Powerpc_relobj::do_find_special_sections( + Read_symbols_data* sd) +{ + if (size == 32) + { + const unsigned char* const pshdrs = sd->section_headers->data(); + const unsigned char* namesu = sd->section_names->data(); + const char* names = reinterpret_cast(namesu); + section_size_type names_size = sd->section_names_size; + const unsigned char* s; + + s = this->find_shdr(pshdrs, ".got2", names, names_size, NULL); + if (s != NULL) + { + unsigned int ndx = (s - pshdrs) / elfcpp::Elf_sizes::shdr_size; + this->set_got2_shndx (ndx); + } + } + return Sized_relobj_file::do_find_special_sections(sd); +} + +// Set up PowerPC target specific relobj. + +template +Object* +Target_powerpc::do_make_elf_object( + const std::string& name, + Input_file* input_file, + off_t offset, const elfcpp::Ehdr& ehdr) +{ + int et = ehdr.get_e_type(); + if (et == elfcpp::ET_REL) + { + Powerpc_relobj* obj = + new Powerpc_relobj(name, input_file, offset, ehdr); + obj->setup(); + return obj; + } + else if (et == elfcpp::ET_DYN) + { + Sized_dynobj* obj = + new Sized_dynobj(name, input_file, offset, ehdr); + obj->setup(); + return obj; + } + else + { + gold_error(_("%s: unsupported ELF file type %d"), + name.c_str(), et); + return NULL; + } +} + +template +class Output_data_got_powerpc : public Output_data_got +{ +public: + typedef typename elfcpp::Elf_types::Elf_Addr Valtype; + typedef Output_data_reloc Rela_dyn; + + Output_data_got_powerpc(Symbol_table* symtab, Layout* layout) + : Output_data_got(), + symtab_(symtab), layout_(layout), + header_ent_cnt_(size == 32 ? 3 : 1), + header_index_(size == 32 ? 0x2000 : 0) + {} + + class Got_entry; + + // Create a new GOT entry and return its offset. + unsigned int + add_got_entry(Got_entry got_entry) { - typename elfcpp::Elf_types::Elf_Addr reloc; + this->reserve_ent(); + return Output_data_got::add_got_entry(got_entry); + } - reloc = (psymval->value(object, addend) - address); - if (reloc & 0x8000) - reloc += 0x10000; - reloc >>= 16; + // Create a pair of new GOT entries and return the offset of the first. + unsigned int + add_got_entry_pair(Got_entry got_entry_1, Got_entry got_entry_2) + { + this->reserve_ent(2); + return Output_data_got::add_got_entry_pair(got_entry_1, + got_entry_2); + } + + // Value of _GLOBAL_OFFSET_TABLE_ + unsigned int + g_o_t() const + { + return this->got_offset(this->header_index_); + } + + // Ensure our GOT has a header. + void + set_final_data_size() + { + if (this->header_ent_cnt_ != 0) + this->make_header(); + Output_data_got::set_final_data_size(); + } + + // First word of GOT header needs some values that are not + // handled by Output_data_got so poke them in here. + // For 32-bit, address of .dynamic, for 64-bit, address of TOCbase. + void + do_write(Output_file* of) + { + replace_constant(this->header_index_, + (size == 32 + ? this->layout_->dynamic_section()->address() + : this->address() + 0x8000)); - elfcpp::Swap<16, big_endian>::writeval(view, reloc); + Output_data_got::do_write(of); } + +private: + void + reserve_ent(unsigned int cnt = 1) + { + if (this->header_ent_cnt_ == 0) + return; + if (this->num_entries() + cnt > this->header_index_) + this->make_header(); + } + + void + make_header() + { + this->header_ent_cnt_ = 0; + this->header_index_ = this->num_entries(); + if (size == 32) + { + Output_data_got::add_constant(0); + Output_data_got::add_constant(0); + Output_data_got::add_constant(0); + + // Define _GLOBAL_OFFSET_TABLE_ at the header + this->symtab_->define_in_output_data("_GLOBAL_OFFSET_TABLE_", NULL, + Symbol_table::PREDEFINED, + this, this->g_o_t(), 0, + elfcpp::STT_OBJECT, + elfcpp::STB_LOCAL, + elfcpp::STV_HIDDEN, + 0, false, false); + } + else + Output_data_got::add_constant(0); + } + + // Stashed pointers. + Symbol_table* symtab_; + Layout* layout_; + + // GOT header size. + unsigned int header_ent_cnt_; + // GOT header index. + unsigned int header_index_; }; // Get the GOT section, creating it if necessary. template -Output_data_got* +Output_data_got_powerpc* Target_powerpc::got_section(Symbol_table* symtab, Layout* layout) { @@ -773,38 +877,12 @@ Target_powerpc::got_se { gold_assert(symtab != NULL && layout != NULL); - this->got_ = new Output_data_got(); + this->got_ + = new Output_data_got_powerpc(symtab, layout); layout->add_output_section_data(".got", elfcpp::SHT_PROGBITS, elfcpp::SHF_ALLOC | elfcpp::SHF_WRITE, this->got_, ORDER_DATA, false); - - // Create the GOT2 or TOC in the .got section. - if (size == 32) - { - this->got2_ = new Output_data_space(4, "** GOT2"); - layout->add_output_section_data(".got2", elfcpp::SHT_PROGBITS, - elfcpp::SHF_ALLOC - | elfcpp::SHF_WRITE, - this->got2_, ORDER_DATA, false); - } - else - { - this->toc_ = new Output_data_space(8, "** TOC"); - layout->add_output_section_data(".toc", elfcpp::SHT_PROGBITS, - elfcpp::SHF_ALLOC - | elfcpp::SHF_WRITE, - this->toc_, ORDER_DATA, false); - } - - // Define _GLOBAL_OFFSET_TABLE_ at the start of the .got section. - symtab->define_in_output_data("_GLOBAL_OFFSET_TABLE_", NULL, - Symbol_table::PREDEFINED, - this->got_, - 0, 0, elfcpp::STT_OBJECT, - elfcpp::STB_LOCAL, - elfcpp::STV_HIDDEN, 0, - false, false); } return this->got_; @@ -830,70 +908,70 @@ Target_powerpc::rela_d // A class to handle the PLT data. template -class Output_data_plt_powerpc : public Output_section_data +class Output_data_plt_powerpc : public Output_section_data_build { public: typedef Output_data_reloc Reloc_section; - Output_data_plt_powerpc(Layout*); + Output_data_plt_powerpc(Layout*, Target_powerpc*); // Add an entry to the PLT. - void add_entry(Symbol* gsym); + void + add_entry(Symbol*); // Return the .rela.plt section data. - const Reloc_section* rel_plt() const - { + const Reloc_section* + rel_plt() const + { return this->rel_; } // Return the number of PLT entries. unsigned int entry_count() const - { return this->count_; } + { return (this->current_data_size() - initial_plt_entry_size) / plt_entry_size; } // Return the offset of the first non-reserved PLT entry. static unsigned int first_plt_entry_offset() - { return 4 * base_plt_entry_size; } + { return initial_plt_entry_size; } // Return the size of a PLT entry. static unsigned int get_plt_entry_size() - { return base_plt_entry_size; } + { return plt_entry_size; } protected: - void do_adjust_output_section(Output_section* os); - - private: - // The size of an entry in the PLT. - static const int base_plt_entry_size = (size == 32 ? 16 : 24); - - // Set the final size. void - set_final_data_size() + do_adjust_output_section(Output_section* os) { - unsigned int full_count = this->count_ + 4; - - this->set_data_size(full_count * base_plt_entry_size); + os->set_entsize(0); } + private: + // The size of an entry in the PLT. + static const int plt_entry_size = size == 32 ? 4 : 24; + // The size of the first reserved entry. + static const int initial_plt_entry_size = size == 32 ? 0 : 24; + // Write out the PLT data. void do_write(Output_file*); // The reloc section. Reloc_section* rel_; - // The number of PLT entries. - unsigned int count_; + // Allows access to .glink for do_write. + Target_powerpc* targ_; }; -// Create the PLT section. The ordinary .got section is an argument, -// since we need to refer to the start. +// Create the PLT section. template -Output_data_plt_powerpc::Output_data_plt_powerpc(Layout* layout) - : Output_section_data(size == 32 ? 4 : 8), count_(0) +Output_data_plt_powerpc::Output_data_plt_powerpc(Layout* layout, + Target_powerpc* targ) + : Output_section_data_build(size == 32 ? 4 : 8), + targ_(targ) { this->rel_ = new Reloc_section(false); layout->add_output_section_data(".rela.plt", elfcpp::SHT_RELA, @@ -901,35 +979,24 @@ Output_data_plt_powerpc -void -Output_data_plt_powerpc::do_adjust_output_section(Output_section* os) -{ - os->set_entsize(0); -} - // Add an entry to the PLT. template void Output_data_plt_powerpc::add_entry(Symbol* gsym) { - gold_assert(!gsym->has_plt_offset()); - unsigned int index = this->count_+ + 4; - section_offset_type plt_offset; - - if (index < 8192) - plt_offset = index * base_plt_entry_size; - else - gold_unreachable(); - - gsym->set_plt_offset(plt_offset); - - ++this->count_; + if (!gsym->has_plt_offset()) + { + off_t off = this->current_data_size(); - gsym->set_needs_dynsym_entry(); - this->rel_->add_global(gsym, elfcpp::R_POWERPC_JMP_SLOT, this, - plt_offset, 0); + if (off == 0) + off += initial_plt_entry_size; + gsym->set_plt_offset(off); + gsym->set_needs_dynsym_entry(); + this->rel_->add_global(gsym, elfcpp::R_POWERPC_JMP_SLOT, this, off, 0); + off += plt_entry_size; + this->set_current_data_size(off); + } } static const unsigned int addis_11_11 = 0x3d6b0000; @@ -941,6 +1008,7 @@ static const unsigned int add_11_0_11 static const unsigned int b = 0x48000000; static const unsigned int bcl_20_31 = 0x429f0005; static const unsigned int bctr = 0x4e800420; +static const unsigned int blrl = 0x4e800021; static const unsigned int lis_11 = 0x3d600000; static const unsigned int lis_12 = 0x3d800000; static const unsigned int lwzu_0_12 = 0x840c0000; @@ -955,13 +1023,21 @@ static const unsigned int mtctr_11 static const unsigned int mtlr_0 = 0x7c0803a6; static const unsigned int nop = 0x60000000; static const unsigned int sub_11_11_12 = 0x7d6c5850; - -static const unsigned int addis_r12_r2 = 0x3d820000; /* addis %r12,%r2,xxx@ha */ -static const unsigned int std_r2_40r1 = 0xf8410028; /* std %r2,40(%r1) */ -static const unsigned int ld_r11_0r12 = 0xe96c0000; /* ld %r11,xxx+0@l(%r12) */ -static const unsigned int ld_r2_0r12 = 0xe84c0000; /* ld %r2,xxx+8@l(%r12) */ - /* ld %r11,xxx+16@l(%r12) */ - +static const unsigned int addis_12_2 = 0x3d820000; +static const unsigned int std_2_1 = 0xf8410000; +static const unsigned int ld_11_12 = 0xe96c0000; +static const unsigned int ld_2_12 = 0xe84c0000; +static const unsigned int addi_12_12 = 0x398c0000; +static const unsigned int ld_11_2 = 0xe9620000; +static const unsigned int addi_2_2 = 0x38420000; +static const unsigned int ld_2_2 = 0xe8420000; +static const unsigned int mflr_11 = 0x7d6802a6; +static const unsigned int ld_2_11 = 0xe84b0000; +static const unsigned int mtlr_12 = 0x7d8803a6; +static const unsigned int add_12_2_11 = 0x7d825a14; +static const unsigned int li_0_0 = 0x38000000; +static const unsigned int lis_0_0 = 0x3c000000; +static const unsigned int ori_0_0_0 = 0x60000000; // Write out the PLT. @@ -969,82 +1045,533 @@ template void Output_data_plt_powerpc::do_write(Output_file* of) { - const off_t offset = this->offset(); + if (size == 32) + { + const off_t offset = this->offset(); + const section_size_type oview_size + = convert_to_section_size_type(this->data_size()); + unsigned char* const oview = of->get_output_view(offset, oview_size); + unsigned char* pov = oview; + unsigned char* endpov = oview + oview_size; + + // The address the .glink branch table + const Output_data_glink* glink + = this->targ_->glink_section(); + elfcpp::Elf_types<32>::Elf_Addr branch_tab + = glink->address() + glink->pltresolve(); + + while (pov < endpov) + { + elfcpp::Swap<32, big_endian>::writeval(pov, branch_tab); + pov += 4; + branch_tab += 4; + } + + of->write_output_view(offset, oview_size, oview); + } +} + +// Create the PLT section. + +template +void +Target_powerpc::make_plt_section(Layout* layout) +{ + if (this->plt_ == NULL) + { + if (this->glink_ == NULL) + make_glink_section(layout); + + // Ensure that .rela.dyn always appears before .rela.plt This is + // necessary due to how, on PowerPC and some other targets, .rela.dyn + // needs to include .rela.plt in it's range. + this->rela_dyn_section(layout); + + this->plt_ = new Output_data_plt_powerpc(layout, this); + layout->add_output_section_data(".plt", + (size == 32 + ? elfcpp::SHT_PROGBITS + : elfcpp::SHT_NOBITS), + elfcpp::SHF_ALLOC | elfcpp::SHF_WRITE, + this->plt_, + (size == 32 + ? ORDER_SMALL_DATA + : ORDER_SMALL_BSS), + false); + } +} + +// A class to handle .glink. + +template +class Output_data_glink : public Output_section_data +{ + public: + Output_data_glink(Target_powerpc*); + + // Add an entry + void + add_entry(const Symbol*, const elfcpp::Rela&, + const Sized_relobj*, unsigned int); + + unsigned int + find_entry(const Symbol*, const elfcpp::Rela&, + const Sized_relobj*, unsigned int) const; + + unsigned int + glink_entry_size() const + { + if (size == 32) + return 4 * 4; + else + // FIXME: We should be using multiple glink sections for + // stubs to support > 33M applications. + return 8 * 4; + } + + off_t + pltresolve() const + { + return this->pltresolve_; + } + + private: + static const int pltresolve_size = 16*4; + + void + set_final_data_size(); + + // Write out .glink + void + do_write(Output_file*); + + struct Glink_sym_ent + { + Glink_sym_ent(const Symbol *sym, + const elfcpp::Rela& reloc, + const Sized_relobj* object, + unsigned int shndx) + : sym_(sym), object_(0), shndx_(0), addend_(0) + { + if (size != 32) + this->addend_ = reloc.get_r_addend(); + else if (parameters->options().output_is_position_independent()) + { + if (object != NULL && shndx != 0) + this->addend_ = reloc.get_r_addend(); + if (this->addend_ != 0) + { + this->object_ = object; + this->shndx_ = shndx; + } + } + } + + const Symbol *sym_; + const Sized_relobj* object_; + unsigned int shndx_; + unsigned int addend_; + + bool operator==(const Glink_sym_ent& that) const + { + return (this->sym_ == that.sym_ + && this->object_ == that.object_ + && this->shndx_ == that.shndx_ + && this->addend_ == that.addend_); + } + }; + + struct Glink_sym_ent_hash + { + size_t operator()(const Glink_sym_ent& ent) const + { + return (reinterpret_cast(ent.sym_) + ^ reinterpret_cast(ent.object_) + ^ ent.shndx_ + ^ ent.addend_); + } + }; + + // Set of sym/shndx/addend entries. + typedef Unordered_map Glink_entries; + Glink_entries glink_entries_; + + // Offset of pltresolve stub (actually, branch table for 32-bit) + off_t pltresolve_; + + // Allows access to .got and .plt for do_write. + Target_powerpc* targ_; +}; + +// Create the glink section. + +template +Output_data_glink::Output_data_glink(Target_powerpc* targ) + : Output_section_data(16), + pltresolve_(0), targ_(targ) +{ +} + +// Add an entry to glink, if we do not already have one for this +// sym/addend/shndx combo. + +template +void +Output_data_glink +::add_entry(const Symbol* gsym, + const elfcpp::Rela& reloc, + const Sized_relobj* object, + unsigned int shndx) +{ + Glink_sym_ent ent(gsym, reloc, object, shndx); + unsigned int indx = this->glink_entries_.size(); + this->glink_entries_[ent] = indx; +} + +template +unsigned int +Output_data_glink +::find_entry(const Symbol* gsym, + const elfcpp::Rela& reloc, + const Sized_relobj* object, + unsigned int shndx) const +{ + Glink_sym_ent ent(gsym, reloc, object, shndx); + typename Glink_entries::const_iterator p = this->glink_entries_.find(ent); + gold_assert(p != this->glink_entries_.end()); + return p->second; +} + +template +void +Output_data_glink::set_final_data_size() +{ + unsigned int count = this->glink_entries_.size(); + off_t total = count; + + if (count != 0) + { + if (size == 32) + { + total *= 16; + this->pltresolve_ = total; + + // space for branch table + total += 4 * (count - 1); + + total += -total & 15; + total += this->pltresolve_size; + } + else + { + total *= 32; + this->pltresolve_ = total; + total += this->pltresolve_size; + + // space for branch table + total += 8 * count; + if (count > 0x8000) + total += 4 * (count - 0x8000); + } + } + + this->set_data_size(total); +} + +static inline uint32_t +l(uint32_t a) +{ + return a & 0xffff; +} + +static inline uint32_t +hi(uint32_t a) +{ + return l(a >> 16); +} + +static inline uint32_t +ha(uint32_t a) +{ + return hi(a + 0x8000); +} + +template +static inline void +write_insn(unsigned char *p, uint32_t v) +{ + elfcpp::Swap<32, big_endian>::writeval(p, v); +} + +// Write out .glink. + +template +void +Output_data_glink::do_write(Output_file* of) +{ + const off_t off = this->offset(); const section_size_type oview_size = convert_to_section_size_type(this->data_size()); - unsigned char* const oview = of->get_output_view(offset, oview_size); - unsigned char* pov = oview; + unsigned char* const oview = of->get_output_view(off, oview_size); + unsigned char *p; - memset(pov, 0, base_plt_entry_size * 4); - pov += base_plt_entry_size * 4; + // The base address of the .plt section. + uint32_t plt_base = this->targ_->plt_section()->address(); + + // The address of _GLOBAL_OFFSET_TABLE_. + const Output_data_got_powerpc *got; + typename elfcpp::Elf_types::Elf_Addr g_o_t; + got = this->targ_->got_section(); + g_o_t = got->address() + got->g_o_t(); + + if (size == 64) + { + // Write out call stubs. + typename Glink_entries::const_iterator g; + for (g = this->glink_entries_.begin(); + g != this->glink_entries_.end(); + ++g) + { + uint64_t plt_addr = plt_base + g->first.sym_->plt_offset(); + uint64_t got_addr = g_o_t; + uint64_t pltoff = plt_addr - got_addr; + + if (pltoff + 0x80008000 > 0xffffffff || (pltoff & 7) != 0) + gold_error(_("%s: linkage table error against `%s'"), + g->first.object_->name().c_str(), + g->first.sym_->demangled_name().c_str()); + + p = oview + g->second * this->glink_entry_size(); + if (ha(pltoff) != 0) + { + write_insn(p, addis_12_2 + ha(pltoff)), p += 4; + write_insn(p, std_2_1 + 40), p += 4; + write_insn(p, ld_11_12 + l(pltoff)), p += 4; + if (ha(pltoff + 16) != ha(pltoff)) + { + write_insn(p, addi_12_12 + l(pltoff)), p += 4; + pltoff = 0; + } + write_insn(p, mtctr_11), p += 4; + write_insn(p, ld_2_12 + l(pltoff + 8)), p += 4; + write_insn(p, ld_11_12 + l(pltoff + 16)), p += 4; + write_insn(p, bctr), p += 4; + } + else + { + write_insn(p, std_2_1 + 40), p += 4; + write_insn(p, ld_11_2 + l(pltoff)), p += 4; + if (ha(pltoff + 16) != ha(pltoff)) + { + write_insn(p, addi_2_2 + l(pltoff)), p += 4; + pltoff = 0; + } + write_insn(p, mtctr_11), p += 4; + write_insn(p, ld_11_2 + l(pltoff + 16)), p += 4; + write_insn(p, ld_2_2 + l(pltoff + 8)), p += 4; + write_insn(p, bctr), p += 4; + } + } + + // Write pltresolve stub. + p = oview + this->pltresolve_; + uint64_t after_bcl = this->address() + this->pltresolve_ + 16; + uint64_t pltoff = plt_base - after_bcl; + + elfcpp::Swap<64, big_endian>::writeval(p, pltoff), p += 8; + + write_insn(p, mflr_12), p += 4; + write_insn(p, bcl_20_31), p += 4; + write_insn(p, mflr_11), p += 4; + write_insn(p, ld_2_11 + l(-16)), p += 4; + write_insn(p, mtlr_12), p += 4; + write_insn(p, add_12_2_11), p += 4; + write_insn(p, ld_11_12 + 0), p += 4; + write_insn(p, ld_2_12 + 8), p += 4; + write_insn(p, mtctr_11), p += 4; + write_insn(p, ld_11_12 + 16), p += 4; + write_insn(p, bctr), p += 4; + while (p < oview + this->pltresolve_ + this->pltresolve_size) + write_insn(p, nop), p += 4; + + // Write lazy link call stubs. + uint32_t indx = 0; + while (p < oview + oview_size) + { + if (indx < 0x8000) + { + write_insn(p, li_0_0 + indx), p += 4; + } + else + { + write_insn(p, lis_0_0 + hi(indx)), p += 4; + write_insn(p, ori_0_0_0 + l(indx)), p += 4; + } + uint16_t branch_off = this->pltresolve_ + 8 - (p - oview); + write_insn(p, b + (branch_off & 0x3fffffc)), p += 4; + indx++; + } + } + else + { + // Write out call stubs. + typename Glink_entries::const_iterator g; + for (g = this->glink_entries_.begin(); + g != this->glink_entries_.end(); + ++g) + { + uint32_t plt_addr = plt_base + g->first.sym_->plt_offset(); + uint32_t got_addr; + + p = oview + g->second * this->glink_entry_size(); + if (parameters->options().output_is_position_independent()) + { + if (g->first.shndx_) + got_addr = (g->first.object_->output_section(g->first.shndx_)->address() + + g->first.object_->output_section_offset(g->first.shndx_) + + g->first.addend_); + else + got_addr = g_o_t; + + uint32_t pltoff = plt_addr - got_addr; + if (ha(pltoff) == 0) + { + write_insn(p + 0, lwz_11_30 + l(pltoff)); + write_insn(p + 4, mtctr_11); + write_insn(p + 8, bctr); + } + else + { + write_insn(p + 0, addis_11_30 + ha(pltoff)); + write_insn(p + 4, lwz_11_11 + l(pltoff)); + write_insn(p + 8, mtctr_11); + write_insn(p + 12, bctr); + } + } + else + { + write_insn(p + 0, lis_11 + ha(plt_addr)); + write_insn(p + 4, lwz_11_11 + l(plt_addr)); + write_insn(p + 8, mtctr_11); + write_insn(p + 12, bctr); + } + } - unsigned int plt_offset = base_plt_entry_size * 4; - const unsigned int count = this->count_; + // Write out pltresolve branch table. + p = oview + this->pltresolve_; + unsigned int the_end = oview_size - this->pltresolve_size; + unsigned char *end_p = oview + the_end; + while (p < end_p - 8 * 4) + write_insn(p, b + end_p - p), p += 4; + while (p < end_p) + write_insn(p, nop), p += 4; - if (size == 64) - { - for (unsigned int i = 0; i < count; i++) + // Write out pltresolve call stub. + if (parameters->options().output_is_position_independent()) { + uint32_t res0_off = this->pltresolve_; + uint32_t after_bcl_off = the_end + 12; + uint32_t bcl_res0 = after_bcl_off - res0_off; + + write_insn(p + 0, addis_11_11 + ha(bcl_res0)); + write_insn(p + 4, mflr_0); + write_insn(p + 8, bcl_20_31); + write_insn(p + 12, addi_11_11 + l(bcl_res0)); + write_insn(p + 16, mflr_12); + write_insn(p + 20, mtlr_0); + write_insn(p + 24, sub_11_11_12); + + uint32_t got_bcl = g_o_t + 4 - (after_bcl_off + this->address()); + + write_insn(p + 28, addis_12_12 + ha(got_bcl)); + if (ha(got_bcl) == ha(got_bcl + 4)) + { + write_insn(p + 32, lwz_0_12 + l(got_bcl)); + write_insn(p + 36, lwz_12_12 + l(got_bcl + 4)); + } + else + { + write_insn(p + 32, lwzu_0_12 + l(got_bcl)); + write_insn(p + 36, lwz_12_12 + 4); + } + write_insn(p + 40, mtctr_0); + write_insn(p + 44, add_0_11_11); + write_insn(p + 48, add_11_0_11); + write_insn(p + 52, bctr); + write_insn(p + 56, nop); + write_insn(p + 60, nop); } - } - else - { - for (unsigned int i = 0; i < count; i++) + else { - elfcpp::Swap<32, true>::writeval(pov + 0x00, - lwz_11_30 + plt_offset); - elfcpp::Swap<32, true>::writeval(pov + 0x04, mtctr_11); - elfcpp::Swap<32, true>::writeval(pov + 0x08, bctr); - elfcpp::Swap<32, true>::writeval(pov + 0x0c, nop); - pov += base_plt_entry_size; - plt_offset += base_plt_entry_size; + uint32_t res0 = this->pltresolve_ + this->address(); + + write_insn(p + 0, lis_12 + ha(g_o_t + 4)); + write_insn(p + 4, addis_11_11 + ha(-res0)); + if (ha(g_o_t + 4) == ha(g_o_t + 8)) + write_insn(p + 8, lwz_0_12 + l(g_o_t + 4)); + else + write_insn(p + 8, lwzu_0_12 + l(g_o_t + 4)); + write_insn(p + 12, addi_11_11 + l(-res0)); + write_insn(p + 16, mtctr_0); + write_insn(p + 20, add_0_11_11); + if (ha(g_o_t + 4) == ha(g_o_t + 8)) + write_insn(p + 24, lwz_12_12 + l(g_o_t + 8)); + else + write_insn(p + 24, lwz_12_12 + 4); + write_insn(p + 28, add_11_0_11); + write_insn(p + 32, bctr); + write_insn(p + 36, nop); + write_insn(p + 40, nop); + write_insn(p + 44, nop); + write_insn(p + 48, nop); + write_insn(p + 52, nop); + write_insn(p + 56, nop); + write_insn(p + 60, nop); } + p += 64; } - gold_assert(static_cast(pov - oview) == oview_size); + of->write_output_view(off, oview_size, oview); +} + +// Create the glink section. - of->write_output_view(offset, oview_size, oview); +template +void +Target_powerpc::make_glink_section(Layout* layout) +{ + if (this->glink_ == NULL) + { + this->glink_ = new Output_data_glink(this); + layout->add_output_section_data(".text", elfcpp::SHT_PROGBITS, + elfcpp::SHF_ALLOC | elfcpp::SHF_EXECINSTR, + this->glink_, ORDER_TEXT, false); + } } // Create a PLT entry for a global symbol. template void -Target_powerpc::make_plt_entry(Symbol_table* symtab, - Layout* layout, - Symbol* gsym) +Target_powerpc::make_plt_entry(Layout* layout, + Symbol* gsym, + const elfcpp::Rela& reloc, + const Sized_relobj* object) { - if (gsym->has_plt_offset()) - return; - if (this->plt_ == NULL) - { - // Create the GOT section first. - this->got_section(symtab, layout); + this->make_plt_section(layout); - // Ensure that .rela.dyn always appears before .rela.plt This is - // necessary due to how, on PowerPC and some other targets, .rela.dyn - // needs to include .rela.plt in it's range. - this->rela_dyn_section(layout); + this->plt_->add_entry(gsym); - this->plt_ = new Output_data_plt_powerpc(layout); - layout->add_output_section_data(".plt", elfcpp::SHT_PROGBITS, - (elfcpp::SHF_ALLOC - | elfcpp::SHF_EXECINSTR - | elfcpp::SHF_WRITE), - this->plt_, ORDER_PLT, false); - - // Define _PROCEDURE_LINKAGE_TABLE_ at the start of the .plt section. - symtab->define_in_output_data("_PROCEDURE_LINKAGE_TABLE_", NULL, - Symbol_table::PREDEFINED, - this->plt_, - 0, 0, elfcpp::STT_OBJECT, - elfcpp::STB_LOCAL, - elfcpp::STV_HIDDEN, 0, - false, false); + unsigned int got2_shndx = 0; + if (size == 32 && object != NULL) + { + const Powerpc_relobj* ppc_obj + = static_cast*>(object); + got2_shndx = ppc_obj->got2_shndx(); } - - this->plt_->add_entry(gsym); + this->glink_->add_entry(gsym, reloc, object, got2_shndx); } // Return the number of entries in the PLT. @@ -1089,10 +1616,11 @@ Target_powerpc::got_mo { gold_assert(symtab != NULL && layout != NULL && object != NULL); Reloc_section* rela_dyn = this->rela_dyn_section(layout); - Output_data_got* got; + Output_data_got_powerpc* got; unsigned int got_offset; got = this->got_section(symtab, layout); + got->reserve_ent(2); got_offset = got->add_constant(0); rela_dyn->add_local(object, 0, elfcpp::R_POWERPC_DTPMOD, got, got_offset, 0); @@ -1106,19 +1634,16 @@ Target_powerpc::got_mo // symbol. IS_FINAL is true if the final address of this symbol is // known at link time. -static tls::Tls_optimization -optimize_tls_reloc(bool /* is_final */, int r_type) +template +tls::Tls_optimization +Target_powerpc::optimize_tls_reloc(bool, int) { // If we are generating a shared library, then we can't do anything // in the linker. if (parameters->options().shared()) return tls::TLSOPT_NONE; - switch (r_type) - { - // XXX - default: - gold_unreachable(); - } + // FIXME + return tls::TLSOPT_NONE; } // Get the Reference_flags for a particular relocation. @@ -1353,15 +1878,9 @@ Target_powerpc::Scan:: case elfcpp::R_POWERPC_GOT16_LO: case elfcpp::R_POWERPC_GOT16_HI: case elfcpp::R_POWERPC_GOT16_HA: - case elfcpp::R_PPC64_TOC16: - case elfcpp::R_PPC64_TOC16_LO: - case elfcpp::R_PPC64_TOC16_HI: - case elfcpp::R_PPC64_TOC16_HA: - case elfcpp::R_PPC64_TOC16_DS: - case elfcpp::R_PPC64_TOC16_LO_DS: { - // The symbol requires a GOT entry. - Output_data_got* got; + // The symbol requires a GOT entry. + Output_data_got_powerpc* got; unsigned int r_sym; got = target->got_section(symtab, layout); @@ -1388,6 +1907,12 @@ Target_powerpc::Scan:: } break; + case elfcpp::R_PPC64_TOC16: + case elfcpp::R_PPC64_TOC16_LO: + case elfcpp::R_PPC64_TOC16_HI: + case elfcpp::R_PPC64_TOC16_HA: + case elfcpp::R_PPC64_TOC16_DS: + case elfcpp::R_PPC64_TOC16_LO_DS: case elfcpp::R_PPC64_TOC: // We need a GOT section. target->got_section(symtab, layout); @@ -1443,21 +1968,7 @@ Target_powerpc::Scan:: case elfcpp::R_POWERPC_NONE: case elfcpp::R_POWERPC_GNU_VTINHERIT: case elfcpp::R_POWERPC_GNU_VTENTRY: - break; - - case elfcpp::R_PPC_PLTREL24: - // If the symbol is fully resolved, this is just a PC32 reloc. - // Otherwise we need a PLT entry. - if (gsym->final_value_is_known()) - break; - // If building a shared library, we can also skip the PLT entry - // if the symbol is defined in the output file and is protected - // or hidden. - if (gsym->is_defined() - && !gsym->is_from_dynobj() - && !gsym->is_preemptible()) - break; - target->make_plt_entry(symtab, layout, gsym); + case elfcpp::R_PPC_LOCAL24PC: break; case elfcpp::R_POWERPC_ADDR16: @@ -1467,26 +1978,27 @@ Target_powerpc::Scan:: case elfcpp::R_POWERPC_ADDR32: case elfcpp::R_PPC64_ADDR64: { - // Make a PLT entry if necessary. - if (gsym->needs_plt_entry()) - { - target->make_plt_entry(symtab, layout, gsym); + // Make a PLT entry if necessary. + if (gsym->needs_plt_entry()) + { + target->make_plt_entry(layout, gsym, reloc, 0); // Since this is not a PC-relative relocation, we may be // taking the address of a function. In that case we need to // set the entry in the dynamic symbol table to the address of // the PLT entry. - if (gsym->is_from_dynobj() && !parameters->options().shared()) + if (size == 32 + && gsym->is_from_dynobj() && !parameters->options().shared()) gsym->set_needs_dynsym_value(); - } - // Make a dynamic relocation if necessary. - if (gsym->needs_dynamic_reloc(Scan::get_reference_flags(r_type))) - { - if (gsym->may_need_copy_reloc()) - { - target->copy_reloc(symtab, layout, object, - data_shndx, output_section, gsym, reloc); - } - else if ((r_type == elfcpp::R_POWERPC_ADDR32 + } + // Make a dynamic relocation if necessary. + if (gsym->needs_dynamic_reloc(Scan::get_reference_flags(r_type))) + { + if (gsym->may_need_copy_reloc()) + { + target->copy_reloc(symtab, layout, object, + data_shndx, output_section, gsym, reloc); + } + else if ((r_type == elfcpp::R_POWERPC_ADDR32 || r_type == elfcpp::R_PPC64_ADDR64) && gsym->can_use_relative_reloc(false)) { @@ -1519,15 +2031,20 @@ Target_powerpc::Scan:: } break; + case elfcpp::R_PPC_PLTREL24: case elfcpp::R_POWERPC_REL24: - case elfcpp::R_PPC_LOCAL24PC: - case elfcpp::R_PPC_REL16: - case elfcpp::R_PPC_REL16_LO: - case elfcpp::R_PPC_REL16_HI: - case elfcpp::R_PPC_REL16_HA: { - if (gsym->needs_plt_entry()) - target->make_plt_entry(symtab, layout, gsym); + if (gsym->needs_plt_entry() + || (!gsym->final_value_is_known() + && !(gsym->is_defined() + && !gsym->is_from_dynobj() + && !gsym->is_preemptible()))) + { + if (r_type == elfcpp::R_PPC_PLTREL24) + target->make_plt_entry(layout, gsym, reloc, object); + else + target->make_plt_entry(layout, gsym, reloc, 0); + } // Make a dynamic relocation if necessary. if (gsym->needs_dynamic_reloc(Scan::get_reference_flags(r_type))) { @@ -1549,19 +2066,19 @@ Target_powerpc::Scan:: } break; + case elfcpp::R_PPC_REL16: + case elfcpp::R_PPC_REL16_LO: + case elfcpp::R_PPC_REL16_HI: + case elfcpp::R_PPC_REL16_HA: + break; + case elfcpp::R_POWERPC_GOT16: case elfcpp::R_POWERPC_GOT16_LO: case elfcpp::R_POWERPC_GOT16_HI: case elfcpp::R_POWERPC_GOT16_HA: - case elfcpp::R_PPC64_TOC16: - case elfcpp::R_PPC64_TOC16_LO: - case elfcpp::R_PPC64_TOC16_HI: - case elfcpp::R_PPC64_TOC16_HA: - case elfcpp::R_PPC64_TOC16_DS: - case elfcpp::R_PPC64_TOC16_LO_DS: { - // The symbol requires a GOT entry. - Output_data_got* got; + // The symbol requires a GOT entry. + Output_data_got_powerpc* got; got = target->got_section(symtab, layout); if (gsym->final_value_is_known()) @@ -1589,6 +2106,12 @@ Target_powerpc::Scan:: break; case elfcpp::R_PPC64_TOC: + case elfcpp::R_PPC64_TOC16: + case elfcpp::R_PPC64_TOC16_LO: + case elfcpp::R_PPC64_TOC16_HI: + case elfcpp::R_PPC64_TOC16_HA: + case elfcpp::R_PPC64_TOC16_DS: + case elfcpp::R_PPC64_TOC16_LO_DS: // We need a GOT section. target->got_section(symtab, layout); break; @@ -1669,7 +2192,6 @@ Target_powerpc::scan_r { typedef Target_powerpc Powerpc; typedef typename Target_powerpc::Scan Scan; - static Output_data_space* sdata; if (sh_type == elfcpp::SHT_REL) { @@ -1678,26 +2200,27 @@ Target_powerpc::scan_r return; } - // Define _SDA_BASE_ at the start of the .sdata section. - if (sdata == NULL) - { - // layout->find_output_section(".sdata") == NULL - sdata = new Output_data_space(4, "** sdata"); - Output_section* os = layout->add_output_section_data(".sdata", 0, - elfcpp::SHF_ALLOC - | elfcpp::SHF_WRITE, - sdata, - ORDER_SMALL_DATA, - false); - symtab->define_in_output_data("_SDA_BASE_", NULL, - Symbol_table::PREDEFINED, - os, - 32768, 0, - elfcpp::STT_OBJECT, - elfcpp::STB_LOCAL, - elfcpp::STV_HIDDEN, 0, - false, false); - } + if (size == 32) + { + static Output_data_space* sdata; + + // Define _SDA_BASE_ at the start of the .sdata section. + if (sdata == NULL) + { + // layout->find_output_section(".sdata") == NULL + sdata = new Output_data_space(4, "** sdata"); + Output_section* os + = layout->add_output_section_data(".sdata", 0, + elfcpp::SHF_ALLOC + | elfcpp::SHF_WRITE, + sdata, ORDER_SMALL_DATA, false); + symtab->define_in_output_data("_SDA_BASE_", NULL, + Symbol_table::PREDEFINED, + os, 32768, 0, elfcpp::STT_OBJECT, + elfcpp::STB_LOCAL, elfcpp::STV_HIDDEN, + 0, false, false); + } + } gold::scan_relocs( symtab, @@ -1729,6 +2252,14 @@ Target_powerpc::do_fin layout->add_target_dynamic_tags(false, this->plt_, rel_plt, this->rela_dyn_, true, size == 32); + if (size == 32) + { + this->got_->finalize_data_size(); + Output_data_dynamic* odyn = layout->dynamic_data(); + odyn->add_section_plus_offset(elfcpp::DT_PPC_GOT, + this->got_, this->got_->g_o_t()); + } + // Emit any relocs we saved in an attempt to avoid generating COPY // relocs. if (this->copy_relocs_.any_saved_relocs()) @@ -1742,7 +2273,7 @@ inline bool Target_powerpc::Relocate::relocate( const Relocate_info* relinfo, Target_powerpc* target, - Output_section*, + Output_section* os, size_t relnum, const elfcpp::Rela& rela, unsigned int r_type, @@ -1754,29 +2285,56 @@ Target_powerpc::Reloca { const unsigned int toc_base_offset = 0x8000; typedef Powerpc_relocate_functions Reloc; - - // Pick the value to use for symbols defined in shared objects. - Symbol_value symval; - if (gsym != NULL - && gsym->use_plt_offset(Scan::get_reference_flags(r_type))) + const Powerpc_relobj* const object + = static_cast*>(relinfo->object); + elfcpp::Elf_Xword value; + + if (r_type == elfcpp::R_POWERPC_GOT16 + || r_type == elfcpp::R_POWERPC_GOT16_LO + || r_type == elfcpp::R_POWERPC_GOT16_HI + || r_type == elfcpp::R_POWERPC_GOT16_HA + || r_type == elfcpp::R_PPC64_GOT16_DS + || r_type == elfcpp::R_PPC64_GOT16_LO_DS) { - elfcpp::Elf_Xword value; - - value = target->plt_section()->address() + gsym->plt_offset(); - - symval.set_output_value(value); - - psymval = &symval; + if (gsym != NULL) + { + gold_assert(gsym->has_got_offset(GOT_TYPE_STANDARD)); + value = gsym->got_offset(GOT_TYPE_STANDARD); + } + else + { + unsigned int r_sym = elfcpp::elf_r_sym(rela.get_r_info()); + gold_assert(object->local_has_got_offset(r_sym, GOT_TYPE_STANDARD)); + value = object->local_got_offset(r_sym, GOT_TYPE_STANDARD); + } + value -= target->got_section()->g_o_t(); + } + else if (r_type == elfcpp::R_PPC64_TOC) + { + value = target->got_section()->address() + toc_base_offset; } + else if (gsym != NULL + && (r_type == elfcpp::R_POWERPC_REL24 + || r_type == elfcpp::R_PPC_PLTREL24) + && gsym->use_plt_offset(Scan::get_reference_flags(r_type))) + { + const Output_data_glink* glink; - const Sized_relobj_file* object = relinfo->object; - elfcpp::Elf_Xword addend = rela.get_r_addend(); + glink = target->glink_section(); + unsigned int shndx = 0; + if (size == 32 && r_type == elfcpp::R_PPC_PLTREL24) + shndx = object->got2_shndx(); + unsigned int glink_index = glink->find_entry(gsym, rela, object, shndx); + value = glink->address() + glink_index * glink->glink_entry_size(); + } + else + { + elfcpp::Elf_Xword addend = 0; + if (r_type != elfcpp::R_PPC_PLTREL24) + addend = rela.get_r_addend(); + value = psymval->value(object, addend); + } - // Get the GOT offset if needed. Unlike i386 and x86_64, our GOT - // pointer points to the beginning, not the end, of the table. - // So we just use the plain offset. - unsigned int got_offset = 0; - unsigned int got2_offset = 0; switch (r_type) { case elfcpp::R_PPC64_TOC16: @@ -1785,39 +2343,18 @@ Target_powerpc::Reloca case elfcpp::R_PPC64_TOC16_HA: case elfcpp::R_PPC64_TOC16_DS: case elfcpp::R_PPC64_TOC16_LO_DS: - // Subtract the TOC base address. - addend -= target->toc_section()->address() + toc_base_offset; - /* FALLTHRU */ - - case elfcpp::R_POWERPC_GOT16: - case elfcpp::R_POWERPC_GOT16_LO: - case elfcpp::R_POWERPC_GOT16_HI: - case elfcpp::R_POWERPC_GOT16_HA: - case elfcpp::R_PPC64_GOT16_DS: - case elfcpp::R_PPC64_GOT16_LO_DS: - if (gsym != NULL) - { - gold_assert(gsym->has_got_offset(GOT_TYPE_STANDARD)); - got_offset = gsym->got_offset(GOT_TYPE_STANDARD); - } - else - { - unsigned int r_sym = elfcpp::elf_r_sym(rela.get_r_info()); - gold_assert(object->local_has_got_offset(r_sym, GOT_TYPE_STANDARD)); - got_offset = object->local_got_offset(r_sym, GOT_TYPE_STANDARD); - } + // Subtract the TOC base address. + value -= target->got_section()->address() + toc_base_offset; break; - // R_PPC_PLTREL24 is rather special. If non-zero, - // the addend specifies the GOT pointer offset within .got2. - case elfcpp::R_PPC_PLTREL24: - if (addend >= 32768) - { - Output_data_space* got2; - got2 = target->got2_section(); - got2_offset = got2->offset(); - addend += got2_offset; - } + case elfcpp::R_POWERPC_SECTOFF: + case elfcpp::R_POWERPC_SECTOFF_LO: + case elfcpp::R_POWERPC_SECTOFF_HI: + case elfcpp::R_POWERPC_SECTOFF_HA: + case elfcpp::R_PPC64_SECTOFF_DS: + case elfcpp::R_PPC64_SECTOFF_LO_DS: + if (os != NULL) + value -= os->address(); break; default: @@ -1832,104 +2369,77 @@ Target_powerpc::Reloca break; case elfcpp::R_POWERPC_REL32: - Reloc::rel32(view, object, psymval, addend, address); + Reloc::rel32(view, value, 0, address); break; case elfcpp::R_POWERPC_REL24: - Reloc::rel24(view, object, psymval, addend, address); - break; - - case elfcpp::R_POWERPC_REL14: - Reloc::rel14(view, object, psymval, addend, address); - break; - case elfcpp::R_PPC_PLTREL24: - Reloc::rel24(view, object, psymval, addend, address); + case elfcpp::R_PPC_LOCAL24PC: + Reloc::rel24(view, value, 0, address); break; - case elfcpp::R_PPC_LOCAL24PC: - Reloc::rel24(view, object, psymval, addend, address); + case elfcpp::R_POWERPC_REL14: + Reloc::rel14(view, value, 0, address); break; case elfcpp::R_PPC64_ADDR64: - if (!parameters->options().output_is_position_independent()) - Relocate_functions::rela64(view, object, - psymval, addend); + case elfcpp::R_PPC64_TOC: + Relocate_functions::rela64(view, value, 0); break; case elfcpp::R_POWERPC_ADDR32: - if (!parameters->options().output_is_position_independent()) - Relocate_functions::rela32(view, object, - psymval, addend); - break; - - case elfcpp::R_POWERPC_ADDR16_LO: - Reloc::addr16_lo(view, object, psymval, addend); - break; - - case elfcpp::R_POWERPC_ADDR16_HI: - Reloc::addr16_hi(view, object, psymval, addend); - break; - - case elfcpp::R_POWERPC_ADDR16_HA: - Reloc::addr16_ha(view, object, psymval, addend); - break; - - case elfcpp::R_PPC_REL16_LO: - Reloc::rel16_lo(view, object, psymval, addend, address); - break; - - case elfcpp::R_PPC_REL16_HI: - Reloc::rel16_lo(view, object, psymval, addend, address); - break; - - case elfcpp::R_PPC_REL16_HA: - Reloc::rel16_ha(view, object, psymval, addend, address); + Relocate_functions::rela32(view, value, 0); break; + case elfcpp::R_POWERPC_ADDR16: + case elfcpp::R_PPC64_TOC16: case elfcpp::R_POWERPC_GOT16: - Reloc::addr16(view, got_offset, addend); + case elfcpp::R_POWERPC_SECTOFF: + Reloc::addr16(view, value, 0); break; + case elfcpp::R_POWERPC_ADDR16_LO: + case elfcpp::R_PPC64_TOC16_LO: case elfcpp::R_POWERPC_GOT16_LO: - Reloc::addr16_lo(view, got_offset, addend); + case elfcpp::R_POWERPC_SECTOFF_LO: + Reloc::addr16_lo(view, value, 0); break; + case elfcpp::R_POWERPC_ADDR16_HI: + case elfcpp::R_PPC64_TOC16_HI: case elfcpp::R_POWERPC_GOT16_HI: - Reloc::addr16_hi(view, got_offset, addend); + case elfcpp::R_POWERPC_SECTOFF_HI: + Reloc::addr16_hi(view, value, 0); break; + case elfcpp::R_POWERPC_ADDR16_HA: + case elfcpp::R_PPC64_TOC16_HA: case elfcpp::R_POWERPC_GOT16_HA: - Reloc::addr16_ha(view, got_offset, addend); - break; - - case elfcpp::R_PPC64_TOC16: - Reloc::addr16(view, got_offset, addend); + case elfcpp::R_POWERPC_SECTOFF_HA: + Reloc::addr16_ha(view, value, 0); break; - case elfcpp::R_PPC64_TOC16_LO: - Reloc::addr16_lo(view, got_offset, addend); + case elfcpp::R_PPC_REL16_LO: + Reloc::rel16_lo(view, value, 0, address); break; - case elfcpp::R_PPC64_TOC16_HI: - Reloc::addr16_hi(view, got_offset, addend); + case elfcpp::R_PPC_REL16_HI: + Reloc::rel16_hi(view, value, 0, address); break; - case elfcpp::R_PPC64_TOC16_HA: - Reloc::addr16_ha(view, got_offset, addend); + case elfcpp::R_PPC_REL16_HA: + Reloc::rel16_ha(view, value, 0, address); break; + case elfcpp::R_PPC64_ADDR16_DS: + case elfcpp::R_PPC64_ADDR16_LO_DS: case elfcpp::R_PPC64_TOC16_DS: case elfcpp::R_PPC64_TOC16_LO_DS: - Reloc::addr16_ds(view, got_offset, addend); - break; - - case elfcpp::R_PPC64_TOC: - { - elfcpp::Elf_types<64>::Elf_Addr value; - value = target->toc_section()->address() + toc_base_offset; - Relocate_functions<64, false>::rela64(view, value, addend); - } + case elfcpp::R_PPC64_GOT16_DS: + case elfcpp::R_PPC64_GOT16_LO_DS: + case elfcpp::R_PPC64_SECTOFF_DS: + case elfcpp::R_PPC64_SECTOFF_LO_DS: + Reloc::addr16_ds(view, value, 0); break; case elfcpp::R_POWERPC_COPY: @@ -1980,8 +2490,6 @@ Target_powerpc::Reloca (gsym == NULL ? !parameters->options().output_is_position_independent() : gsym->final_value_is_known()); - const tls::Tls_optimization optimized_type - = optimize_tls_reloc(is_final, r_type); switch (r_type) { @@ -2024,19 +2532,39 @@ Target_powerpc::reloca reloc_symbol_changes); } -// Return the size of a relocation while scanning during a relocatable -// link. - -template -unsigned int -Target_powerpc::Relocatable_size_for_reloc::get_size_for_reloc( - unsigned int, - Relobj*) -{ - // We are always SHT_RELA, so we should never get here. - gold_unreachable(); - return 0; -} +class Powerpc_scan_relocatable_reloc +{ +public: + // Return the strategy to use for a local symbol which is not a + // section symbol, given the relocation type. + inline Relocatable_relocs::Reloc_strategy + local_non_section_strategy(unsigned int r_type, Relobj*, unsigned int r_sym) + { + // We assume that relocation type 0 is NONE. Targets which are + // different must override. + if (r_type == 0 && r_sym == 0) + return Relocatable_relocs::RELOC_DISCARD; + return Relocatable_relocs::RELOC_COPY; + } + + // Return the strategy to use for a local symbol which is a section + // symbol, given the relocation type. + inline Relocatable_relocs::Reloc_strategy + local_section_strategy(unsigned int, Relobj*) + { + return Relocatable_relocs::RELOC_ADJUST_FOR_SECTION_RELA; + } + + // Return the strategy to use for a global symbol, given the + // relocation type, the object, and the symbol index. + inline Relocatable_relocs::Reloc_strategy + global_strategy(unsigned int r_type, Relobj*, unsigned int) + { + if (r_type == elfcpp::R_PPC_PLTREL24) + return Relocatable_relocs::RELOC_SPECIAL; + return Relocatable_relocs::RELOC_COPY; + } +}; // Scan the relocs during a relocatable link. @@ -2058,11 +2586,8 @@ Target_powerpc::scan_r { gold_assert(sh_type == elfcpp::SHT_RELA); - typedef gold::Default_scan_relocatable_relocs Scan_relocatable_relocs; - gold::scan_relocatable_relocs( + Powerpc_scan_relocatable_reloc>( symtab, layout, object, @@ -2088,26 +2613,142 @@ Target_powerpc::reloca Output_section* output_section, off_t offset_in_output_section, const Relocatable_relocs* rr, - unsigned char* view, - typename elfcpp::Elf_types::Elf_Addr view_address, - section_size_type view_size, + unsigned char*, + typename elfcpp::Elf_types::Elf_Addr, + section_size_type, unsigned char* reloc_view, section_size_type reloc_view_size) { gold_assert(sh_type == elfcpp::SHT_RELA); - gold::relocate_for_relocatable( - relinfo, - prelocs, - reloc_count, - output_section, - offset_in_output_section, - rr, - view, - view_address, - view_size, - reloc_view, - reloc_view_size); + typedef typename elfcpp::Elf_types::Elf_Addr Address; + typedef typename Reloc_types::Reloc + Reltype; + typedef typename Reloc_types::Reloc_write + Reltype_write; + const int reloc_size + = Reloc_types::reloc_size; + const Address invalid_address = static_cast
(0) - 1; + + Powerpc_relobj* const object + = static_cast*>(relinfo->object); + const unsigned int local_count = object->local_symbol_count(); + unsigned int got2_shndx = object->got2_shndx(); + typename elfcpp::Elf_types::Elf_Swxword got2_addend = 0; + if (got2_shndx != 0) + got2_addend = object->get_output_section_offset(got2_shndx); + + unsigned char* pwrite = reloc_view; + + for (size_t i = 0; i < reloc_count; ++i, prelocs += reloc_size) + { + Relocatable_relocs::Reloc_strategy strategy = rr->strategy(i); + if (strategy == Relocatable_relocs::RELOC_DISCARD) + continue; + + Reltype reloc(prelocs); + Reltype_write reloc_write(pwrite); + + typename elfcpp::Elf_types::Elf_WXword r_info = reloc.get_r_info(); + const unsigned int r_sym = elfcpp::elf_r_sym(r_info); + const unsigned int r_type = elfcpp::elf_r_type(r_info); + + // Get the new symbol index. + + unsigned int new_symndx; + if (r_sym < local_count) + { + switch (strategy) + { + case Relocatable_relocs::RELOC_COPY: + case Relocatable_relocs::RELOC_SPECIAL: + new_symndx = object->symtab_index(r_sym); + gold_assert(new_symndx != -1U); + break; + + case Relocatable_relocs::RELOC_ADJUST_FOR_SECTION_RELA: + { + // We are adjusting a section symbol. We need to find + // the symbol table index of the section symbol for + // the output section corresponding to input section + // in which this symbol is defined. + gold_assert(r_sym < local_count); + bool is_ordinary; + unsigned int shndx = + object->local_symbol_input_shndx(r_sym, &is_ordinary); + gold_assert(is_ordinary); + Output_section* os = object->output_section(shndx); + gold_assert(os != NULL); + gold_assert(os->needs_symtab_index()); + new_symndx = os->symtab_index(); + } + break; + + default: + gold_unreachable(); + } + } + else + { + const Symbol* gsym = object->global_symbol(r_sym); + gold_assert(gsym != NULL); + if (gsym->is_forwarder()) + gsym = relinfo->symtab->resolve_forwards(gsym); + + gold_assert(gsym->has_symtab_index()); + new_symndx = gsym->symtab_index(); + } + + // Get the new offset--the location in the output section where + // this relocation should be applied. + + Address offset = reloc.get_r_offset(); + Address new_offset; + if (static_cast
(offset_in_output_section) != invalid_address) + new_offset = offset + offset_in_output_section; + else + { + section_offset_type sot_offset = + convert_types(offset); + section_offset_type new_sot_offset = + output_section->output_offset(object, relinfo->data_shndx, + sot_offset); + gold_assert(new_sot_offset != -1); + new_offset = new_sot_offset; + } + + reloc_write.put_r_offset(new_offset); + reloc_write.put_r_info(elfcpp::elf_r_info(new_symndx, r_type)); + + // Handle the reloc addend based on the strategy. + typename elfcpp::Elf_types::Elf_Swxword addend; + addend = Reloc_types:: + get_reloc_addend(&reloc); + + if (strategy == Relocatable_relocs::RELOC_COPY) + ; + else if (strategy == Relocatable_relocs::RELOC_ADJUST_FOR_SECTION_RELA) + { + const Symbol_value* psymval = object->local_symbol(r_sym); + + addend = psymval->value(object, addend); + } + else if (strategy == Relocatable_relocs::RELOC_SPECIAL) + { + if (addend >= 32768) + addend += got2_addend; + } + else + gold_unreachable(); + + Reloc_types:: + set_reloc_addend(&reloc_write, addend); + + pwrite += reloc_size; + } + + gold_assert(static_cast(pwrite - reloc_view) + == reloc_view_size); } // Return the value to use for a dynamic which requires special @@ -2119,8 +2760,13 @@ template uint64_t Target_powerpc::do_dynsym_value(const Symbol* gsym) const { - gold_assert(gsym->is_from_dynobj() && gsym->has_plt_offset()); - return this->plt_section()->address() + gsym->plt_offset(); + if (size == 32) + { + gold_assert(gsym->is_from_dynobj() && gsym->has_plt_offset()); + return this->plt_section()->address() + gsym->plt_offset(); + } + else + gold_unreachable(); } // The selector for powerpc object files. -- Alan Modra Australia Development Lab, IBM