From: Alan Modra <amodra@gmail.com>
To: Ian Lance Taylor <iant@google.com>
Cc: binutils@sourceware.org
Subject: Re: [GOLD] mapping input to output sections
Date: Tue, 14 Aug 2012 04:40:00 -0000 [thread overview]
Message-ID: <20120814033934.GH3947@bubble.grove.modra.org> (raw)
In-Reply-To: <CAKOQZ8z8WvvghUdJOmotR6qhvUdLUtK5Ac5kQC1F1OYezp6EQQ@mail.gmail.com>
On Mon, Aug 13, 2012 at 07:54:05PM -0700, Ian Lance Taylor wrote:
> On Mon, Aug 13, 2012 at 5:54 PM, Alan Modra <amodra@gmail.com> wrote:
> >
> > * target.h (Target::output_section_name): New function.
> > (Target::do_output_section_name): New function.
> > * layout.cc (Layout::choose_output_section): Call the above.
> > * powerpc.cc (Target_powerpc::do_output_section_name): New function.
>
> > + do_output_section_name(const Relobj*, const char* name, size_t* plen) const
> > + {
> > + if (size == 64 && strcmp (name, ".toc") == 0)
>
> Remove space after "strcmp".
The funny thing about this is that of all the GNU C coding
conventions, this is the one I still dislike after many years of
writing GNU C. Habit dies hard. Fixed and committed.
--
Alan Modra
Australia Development Lab, IBM
prev parent reply other threads:[~2012-08-14 3:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-13 14:43 Alan Modra
2012-08-13 18:11 ` Ian Lance Taylor
2012-08-14 2:20 ` Alan Modra
2012-08-14 3:30 ` Ian Lance Taylor
2012-08-14 4:40 ` Alan Modra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120814033934.GH3947@bubble.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=iant@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).