From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14820 invoked by alias); 14 Aug 2012 03:39:58 -0000 Received: (qmail 14812 invoked by uid 22791); 14 Aug 2012 03:39:58 -0000 X-SWARE-Spam-Status: No, hits=-4.0 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-gh0-f169.google.com (HELO mail-gh0-f169.google.com) (209.85.160.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 14 Aug 2012 03:39:40 +0000 Received: by ghrr18 with SMTP id r18so4213431ghr.0 for ; Mon, 13 Aug 2012 20:39:40 -0700 (PDT) Received: by 10.50.186.130 with SMTP id fk2mr9027036igc.60.1344915579920; Mon, 13 Aug 2012 20:39:39 -0700 (PDT) Received: from bubble.grove.modra.org ([101.166.26.37]) by mx.google.com with ESMTPS id l19sm9476696iga.10.2012.08.13.20.39.38 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 13 Aug 2012 20:39:39 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id D07A2EA0382; Tue, 14 Aug 2012 13:09:34 +0930 (CST) Date: Tue, 14 Aug 2012 04:40:00 -0000 From: Alan Modra To: Ian Lance Taylor Cc: binutils@sourceware.org Subject: Re: [GOLD] mapping input to output sections Message-ID: <20120814033934.GH3947@bubble.grove.modra.org> Mail-Followup-To: Ian Lance Taylor , binutils@sourceware.org References: <20120813142344.GC3947@bubble.grove.modra.org> <20120814005431.GD3947@bubble.grove.modra.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00247.txt.bz2 On Mon, Aug 13, 2012 at 07:54:05PM -0700, Ian Lance Taylor wrote: > On Mon, Aug 13, 2012 at 5:54 PM, Alan Modra wrote: > > > > * target.h (Target::output_section_name): New function. > > (Target::do_output_section_name): New function. > > * layout.cc (Layout::choose_output_section): Call the above. > > * powerpc.cc (Target_powerpc::do_output_section_name): New function. > > > + do_output_section_name(const Relobj*, const char* name, size_t* plen) const > > + { > > + if (size == 64 && strcmp (name, ".toc") == 0) > > Remove space after "strcmp". The funny thing about this is that of all the GNU C coding conventions, this is the one I still dislike after many years of writing GNU C. Habit dies hard. Fixed and committed. -- Alan Modra Australia Development Lab, IBM