From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11792 invoked by alias); 17 Aug 2012 03:54:05 -0000 Received: (qmail 11779 invoked by uid 22791); 17 Aug 2012 03:54:04 -0000 X-SWARE-Spam-Status: No, hits=-2.8 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_NO,RP_MATCHES_RCVD,TW_FN,TW_FX X-Spam-Check-By: sourceware.org Received: from ra.se.axis.com (HELO ra.se.axis.com) (195.60.68.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 17 Aug 2012 03:53:51 +0000 Received: from localhost (localhost [127.0.0.1]) by ra.se.axis.com (Postfix) with ESMTP id 694D511E26; Fri, 17 Aug 2012 05:53:49 +0200 (CEST) Received: from ra.se.axis.com ([127.0.0.1]) by localhost (ra.se.axis.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id IppM9GpbypOP; Fri, 17 Aug 2012 05:53:47 +0200 (CEST) Received: from thoth.se.axis.com (thoth.se.axis.com [10.0.2.173]) by ra.se.axis.com (Postfix) with ESMTP id 6142A11E23; Fri, 17 Aug 2012 05:53:47 +0200 (CEST) Received: from ignucius.se.axis.com (ignucius.se.axis.com [10.88.21.50]) by thoth.se.axis.com (Postfix) with ESMTP id 55BCF34147; Fri, 17 Aug 2012 05:53:47 +0200 (CEST) Received: from ignucius.se.axis.com (localhost [127.0.0.1]) by ignucius.se.axis.com (8.12.8p1/8.12.8/Debian-2woody1) with ESMTP id q7H3rld0000459; Fri, 17 Aug 2012 05:53:47 +0200 Received: (from hp@localhost) by ignucius.se.axis.com (8.12.8p1/8.12.8/Debian-2woody1) id q7H3rkkQ000455; Fri, 17 Aug 2012 05:53:46 +0200 Date: Fri, 17 Aug 2012 04:56:00 -0000 Message-Id: <201208170353.q7H3rkkQ000455@ignucius.se.axis.com> From: Hans-Peter Nilsson To: amodra@gmail.com CC: hjl.tools@gmail.com, tromey@redhat.com, binutils@sourceware.org In-reply-to: <20120817011722.GR3947@bubble.grove.modra.org> (message from Alan Modra on Fri, 17 Aug 2012 03:17:23 +0200) Subject: Re: [PATCH 3/5] remove deleted BFDs from the archive cache MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00315.txt.bz2 (Just replying to the last message in the thread) > xcalloc shouldn't be called from within bfd. I've already committed a > kneejerk patch to revert Tom's last change, instead using bfd_zmalloc > here. Tom said he'd look into fixing the leak this causes, so I'm > happy to leave that to him. :) The last I see is (2012-08-17-02:39:34 UTC) bfd: 2012-08-17 Yuri Chornoivan * elf-bfd.h, * elf32-ppc.c, * elf64-ia64-vms.c, * elfnn-ia64.c, * elfxx-mips.c, * vms-alpha.c: Typo fixes. 2012-08-17 Alan Modra PR binutils/14475: * archive.c (bfd_ar_hdr_from_filesystem): Revert last change. Instead malloc areltdata. binutils: 2012-08-17 Yuri Chornoivan * doc/binutils.texi, * objdump.c, * od-xcoff.c: Typo fixes. 2012-08-16 H.J. Lu PR binutils/14481 * Makefile.am (BFDTEST1_PROG): New. (TEST_PROGS): Likewise. (bfdtest1_DEPENDENCIES): Likewise. (noinst_PROGRAMS): Add $(TEST_PROGS). * Makefile.in: Regenerated. * bfdtest1.c: New file. With this I still see FAILS for cris-elf and cris-linux-gnu (but not for arm-unknown-eabi, mipsisa32r2el-unknown-linux-gnu, mmix-knuth-mmixware): Running /tmp/hpautotest-binutils/bsrc/src/binutils/testsuite/binutils-all/ar.exp ... FAIL: ar long file names (bfdtest1) FAIL: ar thin archive (bfdtest1) and in binutils.log: Executing on host: /tmp/hpautotest-binutils/cris-axis-elf/binutils/bfdtest1 tmpdir/artest.a (timeout = 300) /tmp/hpautotest-binutils/cris-axis-elf/binutils/bfdtest1 exited with status 1 /tmp/hpautotest-binutils/cris-axis-elf/binutils/bfdtest1 exited with status 1 FAIL: ar long file names (bfdtest1) ... Executing on host: /tmp/hpautotest-binutils/cris-axis-elf/binutils/bfdtest1 tmpdir/artest.a (timeout = 300) /tmp/hpautotest-binutils/cris-axis-elf/binutils/bfdtest1 exited with status 1 /tmp/hpautotest-binutils/cris-axis-elf/binutils/bfdtest1 exited with status 1 FAIL: ar thin archive (bfdtest1) Looking closer, it seems bfdtest1 is a new test, and a host program, which might explain the test-result differences. Shouldn't bfdtest1 be present and tested for native builds only? brgds, H-P