From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3945 invoked by alias); 30 Aug 2012 14:53:19 -0000 Received: (qmail 3937 invoked by uid 22791); 30 Aug 2012 14:53:18 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from cheddar.halon.org.uk (HELO cheddar.halon.org.uk) (217.10.144.130) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 30 Aug 2012 14:53:04 +0000 Received: from bsmtp by cheddar.halon.org.uk with local-bsmtp (Exim 4.72) (envelope-from ) id 1T767C-0003Hj-5a; Thu, 30 Aug 2012 15:53:02 +0100 Received: from stemci01 by e102122-lin with local (Exim 4.76) (envelope-from ) id 1T766O-0006OX-Eo; Thu, 30 Aug 2012 15:52:12 +0100 Date: Fri, 31 Aug 2012 01:03:00 -0000 From: Steve McIntyre To: "Joseph S. Myers" Cc: binutils@sourceware.org Subject: Re: [PATCH] Add support for new ABI choice e_flags values on ARM Message-ID: <20120830145200.GD8449@linaro.org> References: <20120830124156.GC8449@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-attached: none User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00494.txt.bz2 On Thu, Aug 30, 2012 at 01:21:42PM +0000, Joseph S. Myers wrote: >On Thu, 30 Aug 2012, Steve McIntyre wrote: > >> gas: >> * config/tc-arm.c (md_begin): Use the new ARM >> hard-float/soft-float ABI flags for EABI_VER5 > >This seems wrong; the ABI is that these flags are only set in ET_EXEC and >ET_DYN objects. This means the assembler should have nothing to do with >them; rather, the linker should set them based on the build attributes in >its input files, if producing ET_EXEC or ET_DYN output. (And there should >be testcases added to the linker testsuite for this: that they are set >for such output, but not for ld -r links.) ACK, I'll try that. Thanks for the quick review. Cheers, -- Steve McIntyre steve.mcintyre@linaro.org Linaro.org | Open source software for ARM SoCs