From: Alan Modra <amodra@gmail.com>
To: Ian Lance Taylor <iant@google.com>
Cc: binutils@sourceware.org
Subject: Re: [GOLD] Adjusting --emit-relocs output
Date: Wed, 05 Sep 2012 00:36:00 -0000 [thread overview]
Message-ID: <20120905003611.GQ3159@bubble.grove.modra.org> (raw)
In-Reply-To: <CAKOQZ8wpGSy6Pb8JqUHtoTS=ESPV2SvbnGKLEqqoTmPJrGN3nQ@mail.gmail.com>
On Tue, Sep 04, 2012 at 12:55:22PM -0700, Ian Lance Taylor wrote:
> > @@ -4626,9 +4626,7 @@ Output_segment::first_section_load_addre
> > ++p)
> > {
> > if ((*p)->is_section())
> > - return ((*p)->has_load_address()
> > - ? (*p)->load_address()
> > - : (*p)->address());
> > + return static_cast<Output_section*>(*p);
>
> Don't use a static_cast here. Instead, return (*p)->output_section().
> That may require you to change the return type to be a const pointer.
> And that will give you trouble elsewhere. You may need two versions
> of this function: one a const member function and one not.
>
> OK with that change.
It turned out OK to return a non-const pointer, so I went with that.
--
Alan Modra
Australia Development Lab, IBM
prev parent reply other threads:[~2012-09-05 0:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-01 4:26 Alan Modra
2012-09-04 19:55 ` Ian Lance Taylor
2012-09-05 0:36 ` Alan Modra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120905003611.GQ3159@bubble.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=iant@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).