From: Steve McIntyre <steve.mcintyre@linaro.org>
To: "Joseph S. Myers" <joseph@codesourcery.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] Add support for new ABI choice e_flags values on ARM
Date: Mon, 17 Sep 2012 13:45:00 -0000 [thread overview]
Message-ID: <20120917134447.GK8449@linaro.org> (raw)
In-Reply-To: <20120904172555.GG8449@linaro.org>
On Tue, Sep 04, 2012 at 06:25:55PM +0100, Steve McIntyre wrote:
>On Thu, Aug 30, 2012 at 01:21:42PM +0000, Joseph S. Myers wrote:
>>On Thu, 30 Aug 2012, Steve McIntyre wrote:
>>
>>> gas:
>>> * config/tc-arm.c (md_begin): Use the new ARM
>>> hard-float/soft-float ABI flags for EABI_VER5
>>
>>This seems wrong; the ABI is that these flags are only set in ET_EXEC and
>>ET_DYN objects. This means the assembler should have nothing to do with
>>them; rather, the linker should set them based on the build attributes in
>>its input files, if producing ET_EXEC or ET_DYN output. (And there should
>>be testcases added to the linker testsuite for this: that they are set
>>for such output, but not for ld -r links.)
>
>Hi,
>
>Updated patch attached including test cases for ld. They work for me
>OK (explicitly testing both positive and negative cases for the ELF
>type and the ABI version), but it's the first time I've worked on
>input for dejagnu so review here would be great! My test cases work
>ok, but I'm seeing a lot of other failures unrelated to my changes; I
>assume that's expected.
>
>I've also tried to get gold to do the right thing here, hooking into
>Target_arm<big_endian>::do_adjust_elf_header(). But I don't see how
>that's ever called; my testing shows it's clearly not. I'm also a
>little baffled as to why gold's testsuite is so utterly different from
>the one for ld - can anyone explain that please?
Ping?
Cheers,
--
Steve McIntyre steve.mcintyre@linaro.org
<http://www.linaro.org/> Linaro.org | Open source software for ARM SoCs
next prev parent reply other threads:[~2012-09-17 13:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-30 13:22 Steve McIntyre
2012-08-30 14:53 ` Joseph S. Myers
2012-08-31 1:03 ` Steve McIntyre
2012-09-04 17:26 ` Steve McIntyre
2012-09-17 13:45 ` Steve McIntyre [this message]
2012-10-26 14:57 ` nick clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120917134447.GK8449@linaro.org \
--to=steve.mcintyre@linaro.org \
--cc=binutils@sourceware.org \
--cc=joseph@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).