From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: Binutils Development <binutils@sourceware.org>,
GDB Patches <gdb-patches@sourceware.org>,
Pedro Alves <palves@redhat.com>,
"H.J. Lu" <hjl.tools@gmail.com>
Subject: Re: [PATCH/RFC 01/02 v2] Refactor PRPSINFO handling on Binutils
Date: Tue, 18 Dec 2012 19:43:00 -0000 [thread overview]
Message-ID: <20121218193104.GA29194@host2.jankratochvil.net> (raw)
In-Reply-To: <m3y5gvqic5.fsf@redhat.com>
On Tue, 18 Dec 2012 20:19:06 +0100, Sergio Durigan Junior wrote:
> On Tuesday, December 18 2012, Jan Kratochvil wrote:
> The patch covers the existing targets that already implemented the
> *_write_core_note function, with the exception of i386 which is a new
> implementation.
OK.
> I disagree. As I said above, the patch covers all targets that were
> already implementing *_write_core_note. If some new target decides to
> implement it, it is just a matter of including "elf-psinfo.h" and using
> the right structures.
OK.
> As I said above, I disagree. The header file is useful for having a
> single place which defines those structures (i.e., i386, x32 and ARM use
> the same elf_external_prpsinfo32 strucutre).
That is a matter of opinion -> bfd maintainers, whether to copy the definition
into each arch file or have some common header file for it despite it is
compatible only with some of the archs.
> Also, the header is useful
> for including in the BFD clients (I'm thiking "GDB" here) which can use
> the elf_internal_prpsinfo strucuture to pass information to BFD.
I forgot about elf_internal_prpsinfo, that one needs to be included in BFD
applications (like GDB). But elf_internal_prpsinfo should be then in
a different file, maybe bfd.h? (I do not know much.) GDB does not need to
know the elf_external_* layouts so those should not be defined in header
file(s) available to GDB.
Thanks,
Jan
next prev parent reply other threads:[~2012-12-18 19:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-17 3:10 Sergio Durigan Junior
2012-12-17 15:43 ` H.J. Lu
2012-12-17 17:41 ` Sergio Durigan Junior
2012-12-17 17:44 ` H.J. Lu
2012-12-17 17:51 ` Sergio Durigan Junior
2012-12-17 22:01 ` H.J. Lu
2012-12-18 5:47 ` Sergio Durigan Junior
2012-12-18 15:43 ` H.J. Lu
2012-12-18 17:38 ` Jan Kratochvil
2012-12-18 19:19 ` Sergio Durigan Junior
2012-12-18 19:43 ` Jan Kratochvil [this message]
2012-12-30 1:50 ` Sergio Durigan Junior
2013-01-01 14:30 ` Jan Kratochvil
2013-01-02 23:32 ` Sergio Durigan Junior
2013-01-03 13:44 ` Jan Kratochvil
2013-01-03 15:46 ` Sergio Durigan Junior
2013-01-04 4:40 ` Sergio Durigan Junior
2013-01-09 20:49 ` Sergio Durigan Junior
2013-01-10 18:26 ` Pedro Alves
2013-01-10 19:47 ` Sergio Durigan Junior
2013-01-11 15:45 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121218193104.GA29194@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=hjl.tools@gmail.com \
--cc=palves@redhat.com \
--cc=sergiodj@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).