From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17601 invoked by alias); 17 Jun 2013 11:51:49 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 17592 invoked by uid 89); 17 Jun 2013 11:51:49 -0000 X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,SPF_PASS autolearn=ham version=3.3.1 Received: from mail-pb0-f54.google.com (HELO mail-pb0-f54.google.com) (209.85.160.54) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 17 Jun 2013 11:51:48 +0000 Received: by mail-pb0-f54.google.com with SMTP id ro2so2693030pbb.27 for ; Mon, 17 Jun 2013 04:51:46 -0700 (PDT) X-Received: by 10.66.197.201 with SMTP id iw9mr12260738pac.198.1371469906878; Mon, 17 Jun 2013 04:51:46 -0700 (PDT) Received: from bubble.grove.modra.org ([101.166.26.37]) by mx.google.com with ESMTPSA id ib9sm13569688pbc.43.2013.06.17.04.51.44 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 17 Jun 2013 04:51:45 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id C0863EA009D; Mon, 17 Jun 2013 21:21:41 +0930 (CST) Date: Mon, 17 Jun 2013 11:51:00 -0000 From: Alan Modra To: "Maciej W. Rozycki" Cc: binutils@sourceware.org Subject: Re: [PATCH] MIPS: Opcode membership proposal Message-ID: <20130617115141.GU21523@bubble.grove.modra.org> Mail-Followup-To: "Maciej W. Rozycki" , binutils@sourceware.org References: <87obway4f5.fsf@firetop.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-06/txt/msg00143.txt.bz2 On Fri, Aug 10, 2012 at 12:07:11PM +0100, Maciej W. Rozycki wrote: > +micromips-opc.lo: micromips-opc.c > + $(LTCOMPILE) $(NO_WMISSING_FIELD_INITIALIZERS) -c -o $@ $< > + > +mips-opc.lo: mips-opc.c > + $(LTCOMPILE) $(NO_WMISSING_FIELD_INITIALIZERS) -c -o $@ $< > + > +mips16-opc.lo: mips16-opc.c > + $(LTCOMPILE) $(NO_WMISSING_FIELD_INITIALIZERS) -c -o $@ $< > + This patch resulted in no dependencies being generated for the mips opcode files, causing my regression tests to fail spectacularly from time to time. I finally got around to looking into the problem. * Makefile.am (mips-opc.lo): Add rules to create automatic dependency files. Pass archdefs. (micromips-opc.lo, mips16-opc.lo): Likewise. * Makefile.in: Regenerate. Index: opcodes/Makefile.am =================================================================== RCS file: /cvs/src/src/opcodes/Makefile.am,v retrieving revision 1.172 diff -u -p -r1.172 Makefile.am --- opcodes/Makefile.am 6 Feb 2013 23:22:25 -0000 1.172 +++ opcodes/Makefile.am 17 Jun 2013 11:06:21 -0000 @@ -573,13 +573,43 @@ $(srcdir)/rl78-decode.c: @MAINT@ $(srcdi ./opc2c$(EXEEXT_FOR_BUILD) $(srcdir)/rl78-decode.opc > $(srcdir)/rl78-decode.c micromips-opc.lo: micromips-opc.c - $(LTCOMPILE) $(NO_WMISSING_FIELD_INITIALIZERS) -c -o $@ $< +if am__fastdepCC + $(LTCOMPILE) $(NO_WMISSING_FIELD_INITIALIZERS) \ + -MT $@ -MD -MP -MF $(DEPDIR)/$*.Tpo -c -o $@ @archdefs@ $< + mv -f $(DEPDIR)/$*.Tpo $(DEPDIR)/$*.Plo +else +if AMDEP + source='$<' object='$@' libtool=yes @AMDEPBACKSLASH@ + DEPDIR=$(DEPDIR) $(CCDEPMODE) $(depcomp) @AMDEPBACKSLASH@ +endif + $(LTCOMPILE) $(NO_WMISSING_FIELD_INITIALIZERS) -c -o $@ @archdefs@ $< +endif mips-opc.lo: mips-opc.c - $(LTCOMPILE) $(NO_WMISSING_FIELD_INITIALIZERS) -c -o $@ $< +if am__fastdepCC + $(LTCOMPILE) $(NO_WMISSING_FIELD_INITIALIZERS) \ + -MT $@ -MD -MP -MF $(DEPDIR)/$*.Tpo -c -o $@ @archdefs@ $< + mv -f $(DEPDIR)/$*.Tpo $(DEPDIR)/$*.Plo +else +if AMDEP + source='$<' object='$@' libtool=yes @AMDEPBACKSLASH@ + DEPDIR=$(DEPDIR) $(CCDEPMODE) $(depcomp) @AMDEPBACKSLASH@ +endif + $(LTCOMPILE) $(NO_WMISSING_FIELD_INITIALIZERS) -c -o $@ @archdefs@ $< +endif mips16-opc.lo: mips16-opc.c - $(LTCOMPILE) $(NO_WMISSING_FIELD_INITIALIZERS) -c -o $@ $< +if am__fastdepCC + $(LTCOMPILE) $(NO_WMISSING_FIELD_INITIALIZERS) \ + -MT $@ -MD -MP -MF $(DEPDIR)/$*.Tpo -c -o $@ @archdefs@ $< + mv -f $(DEPDIR)/$*.Tpo $(DEPDIR)/$*.Plo +else +if AMDEP + source='$<' object='$@' libtool=yes @AMDEPBACKSLASH@ + DEPDIR=$(DEPDIR) $(CCDEPMODE) $(depcomp) @AMDEPBACKSLASH@ +endif + $(LTCOMPILE) $(NO_WMISSING_FIELD_INITIALIZERS) -c -o $@ @archdefs@ $< +endif $(srcdir)/rx-decode.c: @MAINT@ $(srcdir)/rx-decode.opc opc2c$(EXEEXT_FOR_BUILD) ./opc2c$(EXEEXT_FOR_BUILD) $(srcdir)/rx-decode.opc > $(srcdir)/rx-decode.c -- Alan Modra Australia Development Lab, IBM