From: Alan Modra <amodra@gmail.com>
To: Roland McGrath <mcgrathr@google.com>
Cc: "binutils@sourceware.org" <binutils@sourceware.org>
Subject: Re: [PATCH] avoid strange arithmetic with strings in i386-dis.c
Date: Fri, 11 Oct 2013 00:47:00 -0000 [thread overview]
Message-ID: <20131011004651.GI6368@bubble.grove.modra.org> (raw)
In-Reply-To: <CAB=4xhoJe2Z_Uex9_mXmG2ea1ZdDwoBXUYMi8J3yM+=Yu3SV1Q@mail.gmail.com>
On Thu, Oct 10, 2013 at 04:15:00PM -0700, Roland McGrath wrote:
> This makes the code a bit less baroque, and also avoids warnings from some
> compilers. After the various changes I've committed in the last couple of
> days, this is enough to get binutils (excluding gold) to build warning-free
> with a recent Clang.
Baroque? I think you meant to say "Inexperienced programmers, minds
corrupted by the bizarre and perverse nature of C++, ignorant of the
fact that a C string is an array, find a time-honoured C trick from
days when life was simple and compilers non-optimising, confusing.
Clang, catering to these users and written by mad C++ programmers,
warns about perfectly good code."
> * i386-dis.c (oappend_maybe_intel): New function.
> (OP_ST, OP_STi, append_seg, OP_I, OP_I64, OP_sI, OP_ESreg): Use it.
> (OP_C, OP_T, CMP_Fixup, OP_EX_VexImmW): Likewise.
> (VCMP_Fixup, VPCMP_Fixup, PCLMUL_Fixup): Likewise.
OK.
--
Alan Modra
Australia Development Lab, IBM
next prev parent reply other threads:[~2013-10-11 0:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-10 23:15 Roland McGrath
2013-10-11 0:12 ` H.J. Lu
2013-10-11 1:01 ` Roland McGrath
2013-10-11 0:47 ` Alan Modra [this message]
2013-10-11 6:30 ` Jan Beulich
2013-10-11 22:49 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131011004651.GI6368@bubble.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=mcgrathr@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).