From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26359 invoked by alias); 14 Oct 2013 11:19:49 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 26347 invoked by uid 89); 14 Oct 2013 11:19:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: lug-owl.de Received: from lug-owl.de (HELO lug-owl.de) (195.71.106.12) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 14 Oct 2013 11:19:47 +0000 Received: by lug-owl.de (Postfix, from userid 1001) id 942DEF034F; Mon, 14 Oct 2013 13:19:43 +0200 (CEST) Date: Mon, 14 Oct 2013 11:19:00 -0000 From: Jan-Benedict Glaw To: Nick Clifton Cc: Binutils Subject: [buildrobot] readelf.c (decode_arm_unwind): Initialise addr structure Message-ID: <20131014111943.GB27569@lug-owl.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="dTy3Mrz/UPE2dbVg" Content-Disposition: inline X-gpg-fingerprint: 250D 3BCF 7127 0D8C A444 A961 1DBD 5E75 8399 E1BB X-gpg-key: wwwkeys.de.pgp.net X-Echelon-Enable: howto poison arsenous mail psychological biological nuclear warfare test the bombastical terror of flooding the spy listeners explosion sex drugs and rock'n'roll X-TKUeV: howto poison arsenous mail psychological biological nuclear warfare test the bombastical terror of flooding the spy listeners explosion sex drugs and rock'n'roll User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2013-10/txt/msg00215.txt.bz2 --dTy3Mrz/UPE2dbVg Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 2831 Hi Nick! Buildrobot found this: libtool: link: gcc -W -Wall -Wstrict-prototypes -Wmissing-prototypes -Wshad= ow -Werror -g -O2 -o addr2line addr2line.o bucomm.o version.o filemode.o .= ./bfd/.libs/libbfd.a ../libiberty/libiberty.a -lz gcc -DHAVE_CONFIG_H -I. -I/home/jbglaw/repos/binutils/binutils -I. -I/home= /jbglaw/repos/binutils/binutils -I../bfd -I/home/jbglaw/repos/binutils/binu= tils/../bfd -I/home/jbglaw/repos/binutils/binutils/../include -DLOCALEDIR= =3D"\"/home/jbglaw/build/mipsel-linux/_install_/share/locale\"" -Dbin_dummy= _emulation=3Dbin_vanilla_emulation -W -Wall -Wstrict-prototypes -Wmissing-= prototypes -Wshadow -Werror -g -O2 -MT readelf.o -MD -MP -MF .deps/readelf.= Tpo -c -o readelf.o /home/jbglaw/repos/binutils/binutils/readelf.c cc1: warnings being treated as errors /home/jbglaw/repos/binutils/binutils/readelf.c: In function =E2=80=98decode= _arm_unwind=E2=80=99: /home/jbglaw/repos/binutils/binutils/readelf.c:7173: error: missing initial= izer /home/jbglaw/repos/binutils/binutils/readelf.c:7173: error: (near initializ= ation for =E2=80=98addr.offset=E2=80=99) make[3]: *** [readelf.o] Error 1 5803 struct absaddr 5804 { 5805 unsigned short section; 5806 bfd_vma offset; 5807 }; [...] 7173 struct absaddr addr =3D { 0 }; I don't really see why GCC complains about it (and not init's `offset' with= 0, although you probably wanted to init offset instead of section.) And it's only GCCs on some of the builders, not on all. See http://toolchain.lug-owl.de/buildbot/timeline.php : gcc110: no complains:gcc (GCC) 4.7.2 20121109 (Red Hat 4.7.2-8) pluto: no complains:gcc (Debian 4.8.1-7) 4.8.1 gccbuild:no complains:gcc (Debian 4.8.1-7) 4.8.1 darkeye: no complains:gcc (Debian 4.8.1-7) 4.8.1 gcc15: complains: gcc (Debian 4.4.5-8) 4.4.5 gcc76: complains: gcc (Debian 4.4.5-8) 4.4.5 Looks like a compiler bug to me, uncovered by the recent partial initialization of `addr'. Is it actually needed? `addr' is fully initialized in get_unwind_section_word(). So I guess removing the (incomplete) initializer isn't wrong and would remove the build failure? Untested: 2013-10-14 Jan-Benedict Glaw binutils/ * readelf.c (decode_arm_unwind): Don't initialize `addr'. diff --git a/binutils/readelf.c b/binutils/readelf.c index 32e0cf0..2156b78 100644 --- a/binutils/readelf.c +++ b/binutils/readelf.c @@ -7170,7 +7170,7 @@ decode_arm_unwind (struct arm_unw_aux_info * aux, { int per_index; unsigned int more_words =3D 0; - struct absaddr addr =3D { 0 }; + struct absaddr addr; bfd_vma sym_name =3D (bfd_vma) -1; =20 if (remaining =3D=3D 0) MfG, JBG --=20 Jan-Benedict Glaw jbglaw@lug-owl.de +49-172-7608481 Signature of: Friends are relatives you make for yourself. the second : --dTy3Mrz/UPE2dbVg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 198 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAlJb008ACgkQHb1edYOZ4bvwrwCfTuhKL/b7KWTWGZjO0ToagUfu oyQAn34DUa7I47R5rM+2hrcWbEbxE5eB =P7Hf -----END PGP SIGNATURE----- --dTy3Mrz/UPE2dbVg--