From: Alan Modra <amodra@gmail.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Binutils <binutils@sourceware.org>
Subject: Re: [patch] Fix PowerPC targets minor memory leaks found by Coverity
Date: Mon, 27 Jan 2014 00:12:00 -0000 [thread overview]
Message-ID: <20140127001215.GI5390@bubble.grove.modra.org> (raw)
In-Reply-To: <20140124133831.GA27933@host2.jankratochvil.net>
On Fri, Jan 24, 2014 at 02:38:31PM +0100, Jan Kratochvil wrote:
> * coff-rs6000.c (xcoff_write_archive_contents_big): Free OFFSETS in
> return paths. Three times.
This is OK.
> * elf32-ppc.c (ppc_elf_relax_section): Free FIXUPS in error_return
> return path.
This is not OK. There are paths to error_return before fixups have
been allocated and after fixups have been freed. Please change the
error_return free of fixups from a do { } while (); to a while () { }
loop. OK with that change.
> * elf64-ppc.c (ppc64_elf_link_hash_table_create): Free HTAB in all
> return paths.
> (ppc64_elf_tls_optimize): Free TOC_REF in return path.
> (ppc64_elf_edit_toc): Free USED in return path.
These are OK.
--
Alan Modra
Australia Development Lab, IBM
next prev parent reply other threads:[~2014-01-27 0:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-24 13:38 Jan Kratochvil
2014-01-27 0:12 ` Alan Modra [this message]
2014-02-04 19:19 ` [commit] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140127001215.GI5390@bubble.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).