From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25417 invoked by alias); 4 Feb 2014 19:19:28 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 25406 invoked by uid 89); 4 Feb 2014 19:19:27 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 04 Feb 2014 19:19:27 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s14JJP4p008900 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 4 Feb 2014 14:19:26 -0500 Received: from host2.jankratochvil.net (ovpn-116-25.ams2.redhat.com [10.36.116.25]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s14JJMNf024519 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) for ; Tue, 4 Feb 2014 14:19:25 -0500 Date: Tue, 04 Feb 2014 19:19:00 -0000 From: Jan Kratochvil To: Binutils Subject: [commit] [patch] Fix PowerPC targets minor memory leaks found by Coverity Message-ID: <20140204191922.GA16490@host2.jankratochvil.net> References: <20140124133831.GA27933@host2.jankratochvil.net> <20140127001215.GI5390@bubble.grove.modra.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140127001215.GI5390@bubble.grove.modra.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2014-02/txt/msg00029.txt.bz2 On Mon, 27 Jan 2014 01:12:15 +0100, Alan Modra wrote: > On Fri, Jan 24, 2014 at 02:38:31PM +0100, Jan Kratochvil wrote: > > * elf32-ppc.c (ppc_elf_relax_section): Free FIXUPS in error_return > > return path. > > This is not OK. There are paths to error_return before fixups have > been allocated and after fixups have been freed. Please change the > error_return free of fixups from a do { } while (); to a while () { } > loop. OK with that change. I see you have checked it in in the meantime as a part of: commit 5446cbdf82892a800ed7eef563a795e75223ec52 Author: Alan Modra Date: Thu Jan 30 08:26:02 2014 +1030 ppc476 icache bug workaround Checked in the other two parts as: 2915c55b41d00f12ed6bc54b4160e3367065c1c8 Thanks, Jan