From: Ilya Tocar <tocarip.intel@gmail.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Binutils <binutils@sourceware.org>
Subject: Re: [PATCH, i386][3/3] Update to match latest AVX512 spec.
Date: Tue, 25 Feb 2014 09:41:00 -0000 [thread overview]
Message-ID: <20140225094128.GB31394@msticlxl7.ims.intel.com> (raw)
In-Reply-To: <CAMe9rOqiBVCGAUY-q_HKfnxFVz2tspNCytPNz2mB1hVKrNxajQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1167 bytes --]
On 24 Feb 08:30, H.J. Lu wrote:
> On Mon, Feb 24, 2014 at 5:22 AM, Ilya Tocar <tocarip.intel@gmail.com> wrote:
> > Hi,
> >
> > Currently support version of vctps2ph with sae and only 1 register
> ^^^^^^^^^^^^^^ Please fix
> commit log. It should be vcvtps2ph.
Fixed.
> > operand. This version is encoded as if missing operand was equal to
> > ymm0. I didn't found any references to this variant in
> > http://download-software.intel.com/sites/default/files/managed/50/1a/319433-018.pdf
> > Attached patch removes it. Testing passes. Ok for trunk?
>
> vcvtps2ph supports memory destination. Please add AVX512F testcases
> with memory destination.
>
We already have such tests. See e. g. on lines 6883-6890 in
gas/testsuite/gas/i386/avx512f.s we have:
vcvtps2ph $0xab, %zmm6, (%ecx) # AVX512F
vcvtps2ph $0xab, %zmm6, (%ecx){%k7} # AVX512F
vcvtps2ph $123, %zmm6, (%ecx) # AVX512F
vcvtps2ph $123, %zmm6, -123456(%esp,%esi,8) # AVX512F
vcvtps2ph $123, %zmm6, 4064(%edx) # AVX512F Disp8
vcvtps2ph $123, %zmm6, 4096(%edx) # AVX512F
vcvtps2ph $123, %zmm6, -4096(%edx) # AVX512F Disp8
Do we need additional tests?
[-- Attachment #2: 0001-Remove-bogus-vcvtps2ph-variant.patch --]
[-- Type: text/plain, Size: 4320 bytes --]
From 1f3a59fb284f10f8f7c16e33d644e4cd9d132ee0 Mon Sep 17 00:00:00 2001
From: Ilya Tocar <ilya.tocar@intel.com>
Date: Thu, 20 Feb 2014 19:08:13 +0400
Subject: [PATCH] Remove bogus vcvtps2ph variant.
We currently support version of vcvtps2ph with sae and only 1 register operand.
This version is encoded as if missing operand was equal to ymm0.
I didn't found any references to this variant in
http://download-software.intel.com/sites/default/files/managed/50/1a/319433-018.pdf
This patch removes it.
opcodes/
* i386-opc.tbl: Remove wrong variant of vcvtps2ph
* i386-tbl.h: Regenerate.
---
opcodes/ChangeLog | 7 ++++++-
opcodes/i386-opc.tbl | 1 -
opcodes/i386-tbl.h | 18 ------------------
3 files changed, 6 insertions(+), 20 deletions(-)
diff --git a/opcodes/ChangeLog b/opcodes/ChangeLog
index 585d619..ac1d8fb 100644
--- a/opcodes/ChangeLog
+++ b/opcodes/ChangeLog
@@ -1,4 +1,9 @@
-2014-02-21 Ilya Tocar <ilya.tocar@intel.com>
+2014-02-25 Ilya Tocar <ilya.tocar@intel.com>
+
+ * i386-opc.tbl: Remove wrong variant of vcvtps2ph
+ * i386-tbl.h: Regenerate.
+
+2014-02-20 Ilya Tocar <ilya.tocar@intel.com>
* i386-gen.c (cpu_flag_init): Add CPU_PREFETCHWT1_FLAGS/
(cpu_flags): Add CpuPREFETCHWT1.
diff --git a/opcodes/i386-opc.tbl b/opcodes/i386-opc.tbl
index e0b7072..b22ecad 100644
--- a/opcodes/i386-opc.tbl
+++ b/opcodes/i386-opc.tbl
@@ -3633,7 +3633,6 @@ vcvtps2pd, 3, 0x5A, None, 1, CpuAVX512F, Modrm|EVex=1|Masking=3|VexOpcode=0|VexW
vcvtps2ph, 3, 0x661D, None, 1, CpuAVX512F, Modrm|EVex=1|Masking=3|VexOpcode=2|VexW=1|IgnoreSize|No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf, { Imm8, RegZMM, RegYMM|RegMem }
vcvtps2ph, 4, 0x661D, None, 1, CpuAVX512F, Modrm|EVex=1|Masking=3|VexOpcode=2|VexW=1|IgnoreSize|No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf|SAE, { Imm8, Imm8, RegZMM, RegYMM|RegMem }
vcvtps2ph, 3, 0x661D, None, 1, CpuAVX512F, Modrm|EVex=1|Masking=2|VexOpcode=2|VexW=1|Disp8MemShift=5|IgnoreSize|No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf, { Imm8, RegZMM, YMMword|Unspecified|BaseIndex|Disp8|Disp16|Disp32|Disp32S|Vec_Disp8 }
-vcvtps2ph, 3, 0x661D, None, 1, CpuAVX512F, Modrm|EVex=1|Masking=2|VexOpcode=2|VexW=1|IgnoreSize|No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf|SAE, { Imm8, Imm8, RegZMM|RegMem }
vcvtsd2si, 2, 0xF22D, None, 1, CpuAVX512F, Modrm|EVex=4|VexOpcode=0|VexW=1|VecESize=1|Disp8MemShift=3|IgnoreSize|No_bSuf|No_wSuf|No_sSuf|No_qSuf|No_ldSuf, { RegXMM|Qword|Unspecified|BaseIndex|Disp8|Disp16|Disp32|Disp32S|Vec_Disp8, Reg32 }
vcvtsd2si, 3, 0xF22D, None, 1, CpuAVX512F, Modrm|EVex=4|VexOpcode=0|VexW=1|VecESize=1|IgnoreSize|No_bSuf|No_wSuf|No_sSuf|No_qSuf|No_ldSuf|StaticRounding|SAE, { Imm8, RegXMM, Reg32 }
diff --git a/opcodes/i386-tbl.h b/opcodes/i386-tbl.h
index 6f910b2..a4759d2 100644
--- a/opcodes/i386-tbl.h
+++ b/opcodes/i386-tbl.h
@@ -44114,24 +44114,6 @@ const insn_template i386_optab[] =
{ { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 1, 1, 1, 1, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 1, 0, 1, 0, 0, 0, 1, 0 } } } },
- { "vcvtps2ph", 3, 0x661D, None, 1,
- { { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
- 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0,
- 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
- 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 } },
- { 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 1, 1,
- 1, 1, 1, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
- 0, 0, 0, 1, 2, 0, 0, 0, 0, 0, 1, 2, 0, 0, 0, 1, 0, 0, 0, 0,
- 0, 0 },
- { { { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0,
- 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
- 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 } },
- { { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0,
- 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
- 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 } },
- { { 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
- 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0,
- 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 } } } },
{ "vfmadd132pd", 3, 0x6698, None, 1,
{ { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
--
1.8.3.1
next prev parent reply other threads:[~2014-02-25 9:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-20 15:20 [PATCH, i386][1/3] " Ilya Tocar
2014-02-20 15:59 ` H.J. Lu
2014-02-21 13:31 ` [PATCH, i386][2/3] " Ilya Tocar
2014-02-21 16:07 ` H.J. Lu
2014-03-20 17:29 ` H.J. Lu
2014-02-24 13:22 ` [PATCH, i386][3/3] " Ilya Tocar
2014-02-24 16:30 ` H.J. Lu
2014-02-25 9:41 ` Ilya Tocar [this message]
2014-02-25 15:54 ` H.J. Lu
2014-02-25 16:03 ` H.J. Lu
2014-02-25 16:25 ` Ilya Tocar
2014-02-25 16:53 ` H.J. Lu
2014-03-20 17:30 ` H.J. Lu
2014-03-20 17:27 ` [PATCH, i386][1/3] " H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140225094128.GB31394@msticlxl7.ims.intel.com \
--to=tocarip.intel@gmail.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).